From: Roland Dreier <roland@topspin.com>
To: "Nguyen, Tom L" <tom.l.nguyen@intel.com>
Cc: <linux-kernel@vger.kernel.org>
Subject: Re: Question on using MSI in PCI driver
Date: Tue, 22 Jun 2004 11:26:44 -0700 [thread overview]
Message-ID: <524qp3o3dn.fsf@topspin.com> (raw)
In-Reply-To: <C7AB9DA4D0B1F344BF2489FA165E5024057E5196@orsmsx404.amr.corp.intel.com> (Tom L. Nguyen's message of "Tue, 22 Jun 2004 11:08:04 -0700")
Tom> What do you think of "Failure to request the MMIO address
Tom> space of the MSI-X PBA"? Or what name do you suggest?
Unless I'm misunderstanding the code, nothing is failing, and it's not
the PBA being mapped. You're ioremapping the the MSI-X vector table
so that the msi core can write vector values, etc. So I would suggest
using a name of "MSI-X vector table" in the call to
request_mem_region. (Remember that this name will be displayed in
/proc/iomem, and I don't think it makes sense to display "MSI-X iomap
Failure" to the user when MSI-X is set up and working).
- Roland
next prev parent reply other threads:[~2004-06-22 18:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-22 18:08 Question on using MSI in PCI driver Nguyen, Tom L
2004-06-22 18:26 ` Roland Dreier [this message]
2004-06-22 19:51 ` Christoph Hellwig
2004-06-22 19:55 ` Roland Dreier
-- strict thread matches above, loose matches on Subject: below --
2004-06-22 18:43 Nguyen, Tom L
2004-06-22 15:24 Nguyen, Tom L
2004-06-22 17:49 ` Roland Dreier
2004-06-22 2:22 Roland Dreier
2004-06-22 3:50 ` Jeff Garzik
2004-06-22 3:54 ` Roland Dreier
2004-06-22 4:01 ` Jeff Garzik
2004-06-22 4:04 ` Roland Dreier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=524qp3o3dn.fsf@topspin.com \
--to=roland@topspin.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tom.l.nguyen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox