From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752313Ab3JEPrM (ORCPT <rfc822;w@1wt.eu>);
	Sat, 5 Oct 2013 11:47:12 -0400
Received: from intranet.asianux.com ([58.214.24.6]:39088 "EHLO
	intranet.asianux.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751975Ab3JEPrL (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sat, 5 Oct 2013 11:47:11 -0400
X-Spam-Score: -100.9
Message-ID: <52503441.2030009@asianux.com>
Date: Sat, 05 Oct 2013 23:46:09 +0800
From: Chen Gang <gang.chen@asianux.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2
MIME-Version: 1.0
To: Joe Perches <joe@perches.com>
CC: Al Viro <viro@zeniv.linux.org.uk>, Thomas Gleixner <tglx@linutronix.de>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] kernel/irq/proc.c: set MAX_NAMELEN 11 instead of 10 which
 express the maximize size of "%d" or "%u".
References: <52502E14.5040507@asianux.com> <1380987671.2081.122.camel@joe-AO722>
In-Reply-To: <1380987671.2081.122.camel@joe-AO722>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 10/05/2013 11:41 PM, Joe Perches wrote:
> On Sat, 2013-10-05 at 23:19 +0800, Chen Gang wrote:
>> Theoretically, the maximize size of "%d" or "%u" is 11 (10 + '\0'), so
>> need set MAX_NAMELEN 11 instead of 10.
> 
> %d can be negative.
> 
> 
> 
> 

Oh, really, it is incorrect. Al Viro succeeds once.  :-(

And I should send patch v2 for it.

Thanks.
-- 
Chen Gang