From: Chen Gang <gang.chen@asianux.com>
To: Richard Weinberger <richard.weinberger@gmail.com>
Cc: Joe Perches <joe@perches.com>, Al Viro <viro@zeniv.linux.org.uk>,
Thomas Gleixner <tglx@linutronix.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] kernel/irq/proc.c: set MAX_NAMELEN 11 instead of 10 which express the maximize size of "%d" or "%u".
Date: Sun, 06 Oct 2013 00:50:59 +0800 [thread overview]
Message-ID: <52504373.8070606@asianux.com> (raw)
In-Reply-To: <CAFLxGvy0+9tu5PF2kKrUyVRobixtLaSs_u_b9zwFj64YvQrxgw@mail.gmail.com>
On 10/06/2013 12:08 AM, Richard Weinberger wrote:
> On Sat, Oct 5, 2013 at 5:46 PM, Chen Gang <gang.chen@asianux.com> wrote:
>> On 10/05/2013 11:41 PM, Joe Perches wrote:
>>> On Sat, 2013-10-05 at 23:19 +0800, Chen Gang wrote:
>>>> Theoretically, the maximize size of "%d" or "%u" is 11 (10 + '\0'), so
>>>> need set MAX_NAMELEN 11 instead of 10.
>>>
>>> %d can be negative.
>>>
>>>
>>>
>>>
>>
>> Oh, really, it is incorrect. Al Viro succeeds once. :-(
>>
>> And I should send patch v2 for it.
>
> irq is in both register_irq_proc() and unregister_irq_proc() an unsigned int.
> Therefore %d makes not really sense. Both should use %u.
> IMHO sprintf() should also get replaced by snprintf() but that's a
> matter of taste.
>
OK, thanks. your opinions sounds more reasonable to me.
After 1 day (if no additional reply), I should send patch v2 for it.
Thanks
--
Chen Gang
next prev parent reply other threads:[~2013-10-05 16:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-05 15:19 [PATCH] kernel/irq/proc.c: set MAX_NAMELEN 11 instead of 10 which express the maximize size of "%d" or "%u" Chen Gang
2013-10-05 15:21 ` Chen Gang
2013-10-05 15:41 ` Joe Perches
2013-10-05 15:46 ` Chen Gang
2013-10-05 16:08 ` Richard Weinberger
2013-10-05 16:50 ` Chen Gang [this message]
2013-10-05 17:06 ` Chen Gang
2013-10-05 17:45 ` Richard Weinberger
2013-10-06 0:37 ` Chen Gang
2013-10-06 15:57 ` Chen Gang
2013-10-07 10:47 ` [PATCH v2] kernel/irq/proc.c: set MAX_NAMELEN 11 instead of 10 and use "%u" instead of "%d" for printing 'irq' Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52504373.8070606@asianux.com \
--to=gang.chen@asianux.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=richard.weinberger@gmail.com \
--cc=tglx@linutronix.de \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox