From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752667Ab3JERHe (ORCPT ); Sat, 5 Oct 2013 13:07:34 -0400 Received: from intranet.asianux.com ([58.214.24.6]:8256 "EHLO intranet.asianux.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751406Ab3JERHe (ORCPT ); Sat, 5 Oct 2013 13:07:34 -0400 X-Spam-Score: -100.9 Message-ID: <52504718.30303@asianux.com> Date: Sun, 06 Oct 2013 01:06:32 +0800 From: Chen Gang User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Richard Weinberger CC: Joe Perches , Al Viro , Thomas Gleixner , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] kernel/irq/proc.c: set MAX_NAMELEN 11 instead of 10 which express the maximize size of "%d" or "%u". References: <52502E14.5040507@asianux.com> <1380987671.2081.122.camel@joe-AO722> <52503441.2030009@asianux.com> <52504373.8070606@asianux.com> In-Reply-To: <52504373.8070606@asianux.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/06/2013 12:50 AM, Chen Gang wrote: > On 10/06/2013 12:08 AM, Richard Weinberger wrote: >> On Sat, Oct 5, 2013 at 5:46 PM, Chen Gang wrote: >>> On 10/05/2013 11:41 PM, Joe Perches wrote: >>>> On Sat, 2013-10-05 at 23:19 +0800, Chen Gang wrote: >>>>> Theoretically, the maximize size of "%d" or "%u" is 11 (10 + '\0'), so >>>>> need set MAX_NAMELEN 11 instead of 10. >>>> >>>> %d can be negative. >>>> >>>> >>>> >>>> >>> >>> Oh, really, it is incorrect. Al Viro succeeds once. :-( >>> >>> And I should send patch v2 for it. >> >> irq is in both register_irq_proc() and unregister_irq_proc() an unsigned int. >> Therefore %d makes not really sense. Both should use %u. >> IMHO sprintf() should also get replaced by snprintf() but that's a >> matter of taste. >> Oh, commonly, snprintf() are used for the string which can be truncated, and can not be used for the string which contents must not be truncated. In our case, the name string must be not truncated (or may not unique, theoretically), so we have to still use sprintf(). Thanks. > > OK, thanks. your opinions sounds more reasonable to me. > > After 1 day (if no additional reply), I should send patch v2 for it. > > > Thanks > -- Chen Gang