From: "H. Peter Anvin" <hpa@zytor.com>
To: "Geyslan G. Bem" <geyslan@gmail.com>
Cc: tglx@linutronix.de, mingo@redhat.com, x86@kernel.org,
linux-kernel@vger.kernel.org, kernel-br@googlegroups.com
Subject: Re: [PATCH] x86: mkpiggy.c: fix resource leakage
Date: Mon, 07 Oct 2013 15:36:50 -0700 [thread overview]
Message-ID: <52533782.4050207@zytor.com> (raw)
In-Reply-To: <1381184219-10985-1-git-send-email-geyslan@gmail.com>
On 10/07/2013 03:16 PM, Geyslan G. Bem wrote:
> Even though the resource is released when the application is closed or
> when returned from main function, modified to make it in accordance.
> Now FILE pointer is always verified.
>
> Signed-off-by: Geyslan G. Bem <geyslan@gmail.com>
Perhaps you could explain what problem is solved by this patch?
Note that for correctness we really should check the return value from
fclose().
-hpa
next prev parent reply other threads:[~2013-10-07 22:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-07 22:16 [PATCH] x86: mkpiggy.c: fix resource leakage Geyslan G. Bem
2013-10-07 22:36 ` H. Peter Anvin [this message]
2013-10-07 22:44 ` H. Peter Anvin
2013-10-07 23:41 ` Geyslan Gregório Bem
2013-10-08 18:39 ` [tip:x86/cleanups] x86: mkpiggy.c: Explicitly close the output file tip-bot for Geyslan G. Bem
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52533782.4050207@zytor.com \
--to=hpa@zytor.com \
--cc=geyslan@gmail.com \
--cc=kernel-br@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).