From: Ionut Nicu <ioan.nicu.ext@nsn.com>
To: Peter Korsgaard <peter.korsgaard@barco.com>
Cc: Wolfram Sang <wsa@the-dreams.de>,
Alexander Sverdlin <alexander.sverdlin@nsn.com>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i2c-mux-gpio: use deferred probing with the device tree
Date: Tue, 08 Oct 2013 15:34:56 +0200 [thread overview]
Message-ID: <52540A00.9030505@nsn.com> (raw)
In-Reply-To: <87ob6znb3q.fsf@thor.barco.com>
On 08.10.2013 15:30, ext Peter Korsgaard wrote:
>>>>>> "IN" == Ionut Nicu <ioan.nicu.ext@nsn.com> writes:
>
> IN> If the i2c-parent bus driver is not loaded, returning
> IN> -EINVAL will force people to unload and then reload the
> IN> module again to get it working.
>
> IN> Also of_get_named_gpio could return -E_PROBE_DEFER or
> IN> another error code. This error should be passed further
> IN> instead of being ignored.
>
> Two different fixes, so should be 2 separate patches. Other that that,
> it looks good.
>
> Acked-by: Peter Korsgaard <peter.korsgaard@barco.com>
>
Right, I will split it into two patches and re-submit.
Thanks!
prev parent reply other threads:[~2013-10-08 13:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-08 13:20 [PATCH] i2c-mux-gpio: use deferred probing with the device tree Ionut Nicu
2013-10-08 13:30 ` Peter Korsgaard
2013-10-08 13:34 ` Ionut Nicu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52540A00.9030505@nsn.com \
--to=ioan.nicu.ext@nsn.com \
--cc=alexander.sverdlin@nsn.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.korsgaard@barco.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox