* [PATCH 1/2] i2c-mux-gpio: use deferred probing with the device tree
@ 2013-10-08 13:51 Ionut Nicu
2013-10-08 14:45 ` Peter Korsgaard
2013-10-08 21:36 ` Wolfram Sang
0 siblings, 2 replies; 6+ messages in thread
From: Ionut Nicu @ 2013-10-08 13:51 UTC (permalink / raw)
To: Peter Korsgaard; +Cc: Wolfram Sang, Alexander Sverdlin, linux-i2c, linux-kernel
If the i2c-parent bus driver is not loaded, returning
-EINVAL will force people to unload and then reload the
module again to get it working.
Signed-off-by: Ionut Nicu <ioan.nicu.ext@nsn.com>
---
drivers/i2c/muxes/i2c-mux-gpio.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/i2c/muxes/i2c-mux-gpio.c b/drivers/i2c/muxes/i2c-mux-gpio.c
index 5d4a99b..eb99f04 100644
--- a/drivers/i2c/muxes/i2c-mux-gpio.c
+++ b/drivers/i2c/muxes/i2c-mux-gpio.c
@@ -79,7 +79,7 @@ static int i2c_mux_gpio_probe_dt(struct gpiomux *mux,
adapter = of_find_i2c_adapter_by_node(adapter_np);
if (!adapter) {
dev_err(&pdev->dev, "Cannot find parent bus\n");
- return -ENODEV;
+ return -EPROBE_DEFER;
}
mux->data.parent = i2c_adapter_id(adapter);
put_device(&adapter->dev);
--
1.7.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 1/2] i2c-mux-gpio: use deferred probing with the device tree
2013-10-08 13:51 [PATCH 1/2] i2c-mux-gpio: use deferred probing with the device tree Ionut Nicu
@ 2013-10-08 14:45 ` Peter Korsgaard
2013-10-08 21:36 ` Wolfram Sang
1 sibling, 0 replies; 6+ messages in thread
From: Peter Korsgaard @ 2013-10-08 14:45 UTC (permalink / raw)
To: Ionut Nicu; +Cc: Wolfram Sang, Alexander Sverdlin, linux-i2c, linux-kernel
>>>>> "IN" == Ionut Nicu <ioan.nicu.ext@nsn.com> writes:
IN> If the i2c-parent bus driver is not loaded, returning
IN> -EINVAL will force people to unload and then reload the
IN> module again to get it working.
IN> Signed-off-by: Ionut Nicu <ioan.nicu.ext@nsn.com>
Acked-by: Peter Korsgaard <peter.korsgaard@barco.com>
--
Sorry about disclaimer - It's out of my control.
Bye, Peter Korsgaard
This message is subject to the following terms and conditions: MAIL DISCLAIMER<http://www.barco.com/en/maildisclaimer>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] i2c-mux-gpio: use deferred probing with the device tree
2013-10-08 13:51 [PATCH 1/2] i2c-mux-gpio: use deferred probing with the device tree Ionut Nicu
2013-10-08 14:45 ` Peter Korsgaard
@ 2013-10-08 21:36 ` Wolfram Sang
2013-10-09 6:14 ` Peter Korsgaard
1 sibling, 1 reply; 6+ messages in thread
From: Wolfram Sang @ 2013-10-08 21:36 UTC (permalink / raw)
To: Ionut Nicu; +Cc: Peter Korsgaard, Alexander Sverdlin, linux-i2c, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 989 bytes --]
On Tue, Oct 08, 2013 at 03:51:50PM +0200, Ionut Nicu wrote:
> If the i2c-parent bus driver is not loaded, returning
> -EINVAL will force people to unload and then reload the
> module again to get it working.
>
> Signed-off-by: Ionut Nicu <ioan.nicu.ext@nsn.com>
Doesn't the non-DT case need fixing, too?
> ---
> drivers/i2c/muxes/i2c-mux-gpio.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/i2c/muxes/i2c-mux-gpio.c b/drivers/i2c/muxes/i2c-mux-gpio.c
> index 5d4a99b..eb99f04 100644
> --- a/drivers/i2c/muxes/i2c-mux-gpio.c
> +++ b/drivers/i2c/muxes/i2c-mux-gpio.c
> @@ -79,7 +79,7 @@ static int i2c_mux_gpio_probe_dt(struct gpiomux *mux,
> adapter = of_find_i2c_adapter_by_node(adapter_np);
> if (!adapter) {
> dev_err(&pdev->dev, "Cannot find parent bus\n");
> - return -ENODEV;
> + return -EPROBE_DEFER;
> }
> mux->data.parent = i2c_adapter_id(adapter);
> put_device(&adapter->dev);
> --
> 1.7.1
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 1/2] i2c-mux-gpio: use deferred probing with the device tree
2013-10-08 21:36 ` Wolfram Sang
@ 2013-10-09 6:14 ` Peter Korsgaard
2013-10-09 8:30 ` Ionut Nicu
0 siblings, 1 reply; 6+ messages in thread
From: Peter Korsgaard @ 2013-10-09 6:14 UTC (permalink / raw)
To: Wolfram Sang; +Cc: Ionut Nicu, Alexander Sverdlin, linux-i2c, linux-kernel
>>>>> "WS" == Wolfram Sang <wsa@the-dreams.de> writes:
WS> On Tue, Oct 08, 2013 at 03:51:50PM +0200, Ionut Nicu wrote:
>> If the i2c-parent bus driver is not loaded, returning
>> -EINVAL will force people to unload and then reload the
>> module again to get it working.
>>
>> Signed-off-by: Ionut Nicu <ioan.nicu.ext@nsn.com>
WS> Doesn't the non-DT case need fixing, too?
Arguably yes.
--
Bye, Peter Korsgaard
This message is subject to the following terms and conditions: MAIL DISCLAIMER<http://www.barco.com/en/maildisclaimer>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] i2c-mux-gpio: use deferred probing with the device tree
2013-10-09 6:14 ` Peter Korsgaard
@ 2013-10-09 8:30 ` Ionut Nicu
2013-10-09 9:02 ` Wolfram Sang
0 siblings, 1 reply; 6+ messages in thread
From: Ionut Nicu @ 2013-10-09 8:30 UTC (permalink / raw)
To: Peter Korsgaard; +Cc: Wolfram Sang, Alexander Sverdlin, linux-i2c, linux-kernel
On 09.10.2013 08:14, ext Peter Korsgaard wrote:
>>>>>> "WS" == Wolfram Sang <wsa@the-dreams.de> writes:
>
> WS> On Tue, Oct 08, 2013 at 03:51:50PM +0200, Ionut Nicu wrote:
>>> If the i2c-parent bus driver is not loaded, returning
>>> -EINVAL will force people to unload and then reload the
>>> module again to get it working.
>>>
>>> Signed-off-by: Ionut Nicu <ioan.nicu.ext@nsn.com>
>
> WS> Doesn't the non-DT case need fixing, too?
>
> Arguably yes.
>
Yes, and it's also a one line fix. Should I do it in a separate
patch or should I change this one and resubmit?
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-10-09 9:02 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-08 13:51 [PATCH 1/2] i2c-mux-gpio: use deferred probing with the device tree Ionut Nicu
2013-10-08 14:45 ` Peter Korsgaard
2013-10-08 21:36 ` Wolfram Sang
2013-10-09 6:14 ` Peter Korsgaard
2013-10-09 8:30 ` Ionut Nicu
2013-10-09 9:02 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).