Re: [PATCH] rtc: pl030: Use devm_kzalloc() instead of kmalloc()

["sangjung.woo" <sangjung.woo@samsung.com>]

On 10/09/2013 01:07 PM, Joe Perches wrote:
> On Wed, 2013-10-09 at 13:00 +0900, Sangjung Woo wrote:
>> In order to be free automatically and make the cleanup paths more
>> simple, use devm_kzalloc() instead of kzalloc().
> []
>> diff --git a/drivers/rtc/rtc-pl030.c b/drivers/rtc/rtc-pl030.c
> []
>> @@ -106,7 +106,7 @@ static int pl030_probe(struct amba_device *dev, const struct amba_id *id)
>>   	if (ret)
>>   		goto err_req;
>>   
>> -	rtc = kmalloc(sizeof(*rtc), GFP_KERNEL);
>> +	rtc = devm_kzalloc(&dev->dev, sizeof(*rtc), GFP_KERNEL);

First of all, thanks for your review.

> You're not deleting a memset and you're
> converting a kmalloc.
You are right.
>
> Why do you need the zalloc version?
>
The key point of this patch is resource-managed memory allocation.
As you already know, memory space that is allocated by devm_kzalloc() 
function
is automatically freed on driver detach. That makes the code tidy and
reduces human's mistakes not to kfree().