From: "sangjung.woo" <sangjung.woo@samsung.com>
To: Joe Perches <joe@perches.com>
Cc: Guan Xuetao <gxt@mprc.pku.edu.cn>,
Alessandro Zummo <a.zummo@towertech.it>,
rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org,
sangjung.woo@samsung.com
Subject: Re: [PATCH] rtc: rtc-puv3: use dev_dbg() instead of pr_debug()
Date: Wed, 09 Oct 2013 15:39:50 +0900 [thread overview]
Message-ID: <5254FA36.2040803@samsung.com> (raw)
In-Reply-To: <1381299606.2040.21.camel@joe-AO722>
On 10/09/2013 03:20 PM, Joe Perches wrote:
> On Wed, 2013-10-09 at 14:49 +0900, Sangjung Woo wrote:
>> Because dev_*() are used along with pr_debug() function in this code,
>> the debug message is not tidy. This patch converts from pr_debug() to
>> dev_dbg() since dev_*() are encouraged to use in device driver code.
> []
>> diff --git a/drivers/rtc/rtc-puv3.c b/drivers/rtc/rtc-puv3.c
> []
>> @@ -57,7 +57,7 @@ static void puv3_rtc_setaie(int to)
>> {
>> unsigned int tmp;
>>
>> - pr_debug("%s: aie=%d\n", __func__, to);
>> + dev_dbg(dev, "%s: aie=%d\n", __func__, to);
> Does this compile?
>
>
Oops! I did not add my local modification into the patch.
The function parameters should be modified as below.
-static void puv3_rtc_setaie(int to)
+static void puv3_rtc_setaie(struct device *dev, int to)
I will send the new one.
Thank you for your good review.
Cheers, Sangjung
prev parent reply other threads:[~2013-10-09 6:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-09 5:49 [PATCH] rtc: rtc-puv3: use dev_dbg() instead of pr_debug() Sangjung Woo
2013-10-09 6:20 ` Joe Perches
2013-10-09 6:39 ` sangjung.woo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5254FA36.2040803@samsung.com \
--to=sangjung.woo@samsung.com \
--cc=a.zummo@towertech.it \
--cc=gxt@mprc.pku.edu.cn \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox