From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756096Ab3JIHKA (ORCPT ); Wed, 9 Oct 2013 03:10:00 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:47643 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751942Ab3JIHJ6 (ORCPT ); Wed, 9 Oct 2013 03:09:58 -0400 Message-ID: <5255012C.3050709@ti.com> Date: Wed, 9 Oct 2013 10:09:32 +0300 From: Roger Quadros User-Agent: Mozilla/5.0 (X11; Linux i686; rv:16.0) Gecko/20121011 Thunderbird/16.0.1 MIME-Version: 1.0 To: Paul Walmsley CC: , , , , , , Subject: Re: [PATCH] ARM: OMAP4: clock: Initialize USB DPLL References: <1363873705-3224-1-git-send-email-rogerq@ti.com> <514B1553.6030701@ti.com> In-Reply-To: Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/09/2013 10:05 AM, Paul Walmsley wrote: > Hi Roger, > > On Thu, 21 Mar 2013, Roger Quadros wrote: > >> +Paul >> >> On 03/21/2013 03:48 PM, Roger Quadros wrote: >>> If the bootloader doesn't configure USB DPLL (e.g. in u-boot, >>> disable CONFIG_USB_EHCI_OMAP), then we get all sorts of problems >>> like >>> - division by zero errors at boot [1] >>> - USB DPLL fails to enter locked state >>> - USB EHCI Host is non functional >>> - Device can't enter OFF mode >>> >>> Initializing the USB DPLL fixes all these issues. > > Looks like I may have lost track of this - do we still need this one? No, this is already in with the typo fix. Thanks. > > Also: > >>> diff --git a/arch/arm/mach-omap2/cclock44xx_data.c b/arch/arm/mach-omap2/cclock44xx_data.c >>> index bfc46c1..6127bb9 100644 >>> --- a/arch/arm/mach-omap2/cclock44xx_data.c >>> +++ b/arch/arm/mach-omap2/cclock44xx_data.c >>> @@ -53,6 +53,12 @@ >>> */ >>> #define OMAP4_DPLL_ABE_DEFFREQ 98304000 >>> >>> +/* >>> + * OMAP4450 TRM Rev X, section "3.6.3.9.5 DPLL_USB Preferred Settings" > > 4450? cheers, -roger