From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Michal Simek <michal.simek@xilinx.com>
Cc: <linux-kernel@vger.kernel.org>, <monstr@monstr.eu>,
Russell King <linux@arm.linux.org.uk>,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
<linux-fbdev@vger.kernel.org>
Subject: Re: [PATCH 9/9] video: amba-clcd: Remove unnecessary amba_set_drvdata()
Date: Wed, 9 Oct 2013 11:44:31 +0300 [thread overview]
Message-ID: <5255176F.1020700@ti.com> (raw)
In-Reply-To: <2f12a1d7caba382efe8d361b373da60c08e70622.1380793579.git.michal.simek@xilinx.com>
[-- Attachment #1: Type: text/plain, Size: 944 bytes --]
On 03/10/13 12:46, Michal Simek wrote:
> Driver core clears the driver data to NULL after device_release
> or on probe failure, so just remove it from here.
>
> Driver core change:
> "device-core: Ensure drvdata = NULL when no driver is bound"
> (sha1: 0998d0631001288a5974afc0b2a5f568bcdecb4d)
>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
> drivers/video/amba-clcd.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/video/amba-clcd.c b/drivers/video/amba-clcd.c
> index 0a2cce7..0bab6ab 100644
> --- a/drivers/video/amba-clcd.c
> +++ b/drivers/video/amba-clcd.c
> @@ -594,8 +594,6 @@ static int clcdfb_remove(struct amba_device *dev)
> {
> struct clcd_fb *fb = amba_get_drvdata(dev);
>
> - amba_set_drvdata(dev, NULL);
> -
> clcdfb_disable(fb);
> unregister_framebuffer(&fb->fb);
> if (fb->fb.cmap.len)
> --
> 1.8.2.3
>
Thanks, queued for 3.13.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]
next prev parent reply other threads:[~2013-10-09 8:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-03 9:46 [PATCH 1/9] dma: pl330: Remove unnecessary amba_set_drvdata() Michal Simek
2013-10-03 9:46 ` [PATCH 2/9] input: ambakmi: " Michal Simek
2013-10-03 9:46 ` [PATCH 3/9] ARM: etm: " Michal Simek
2013-10-03 9:46 ` [PATCH 4/9] mmc: mmci: " Michal Simek
2013-10-03 9:46 ` [PATCH 5/9] rtc: amba: " Michal Simek
2013-10-03 9:46 ` [PATCH 6/9] serial: " Michal Simek
2013-10-03 9:46 ` [PATCH 7/9] spi: pl022: " Michal Simek
2013-10-03 13:07 ` Mark Brown
2013-10-03 9:46 ` [PATCH 8/9] watchdog: sp805_wdt: " Michal Simek
2013-10-03 16:47 ` Guenter Roeck
2013-10-29 7:49 ` Wim Van Sebroeck
2013-10-03 9:46 ` [PATCH 9/9] video: amba-clcd: " Michal Simek
2013-10-09 8:44 ` Tomi Valkeinen [this message]
2013-10-31 14:25 ` [PATCH 1/9] dma: pl330: " Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5255176F.1020700@ti.com \
--to=tomi.valkeinen@ti.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=michal.simek@xilinx.com \
--cc=monstr@monstr.eu \
--cc=plagnioj@jcrosoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox