From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756165Ab3JIQAZ (ORCPT ); Wed, 9 Oct 2013 12:00:25 -0400 Received: from avon.wwwdotorg.org ([70.85.31.133]:36312 "EHLO avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751921Ab3JIQAX (ORCPT ); Wed, 9 Oct 2013 12:00:23 -0400 Message-ID: <52557D92.9050200@wwwdotorg.org> Date: Wed, 09 Oct 2013 10:00:18 -0600 From: Stephen Warren User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.0 MIME-Version: 1.0 To: Peter De Schrijver CC: Mike Turquette , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Prashant Gaikwad , Thierry Reding , Paul Walmsley , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-tegra@vger.kernel.org" , "devicetree@vger.kernel.org" Subject: Re: [PATCH 4/5] clk: tegra124: Add new peripheral clocks References: <1380878014-22088-1-git-send-email-pdeschrijver@nvidia.com> <1380878014-22088-5-git-send-email-pdeschrijver@nvidia.com> <525487C7.6080103@wwwdotorg.org> <20131009081123.GB3973@tbergstrom-lnx.Nvidia.com> In-Reply-To: <20131009081123.GB3973@tbergstrom-lnx.Nvidia.com> X-Enigmail-Version: 1.5.2 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/09/2013 02:11 AM, Peter De Schrijver wrote: > On Wed, Oct 09, 2013 at 12:31:35AM +0200, Stephen Warren wrote: >> On 10/04/2013 03:12 AM, Peter De Schrijver wrote: >>> Tegra124 introduces a number of new peripheral clocks. This patch adds those >>> to the common peripheral clock code. >> >> Don't you need to add AFC[0..5] in this patch and/or patch 5? > > AFC[0..5] are reset only nodes afaik. Up to now, we haven't done that. > The goal is to include them once we move to the reset framework. No, we've always added clock entries for all reset-only clocks into the clock driver. Since the port to the reset framework is not available yet, we need to continue to do this. Otherwise, we won't be able to upstream audio support.