* [PATCH 1/2] i2c-mux-gpio: test if the gpio can sleep
@ 2013-10-10 8:39 Ionut Nicu
2013-10-10 8:46 ` Wolfram Sang
2013-10-10 8:46 ` Lars-Peter Clausen
0 siblings, 2 replies; 6+ messages in thread
From: Ionut Nicu @ 2013-10-10 8:39 UTC (permalink / raw)
To: Peter Korsgaard; +Cc: Wolfram Sang, Alexander Sverdlin, linux-i2c, linux-kernel
Some gpio chips may have get/set operations that
can sleep. For this type of chips we must use the
_cansleep() version of gpio_set_value.
Signed-off-by: Ionut Nicu <ioan.nicu.ext@nsn.com>
---
drivers/i2c/muxes/i2c-mux-gpio.c | 11 ++++++++---
1 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/drivers/i2c/muxes/i2c-mux-gpio.c b/drivers/i2c/muxes/i2c-mux-gpio.c
index a764da7..b5f17ef 100644
--- a/drivers/i2c/muxes/i2c-mux-gpio.c
+++ b/drivers/i2c/muxes/i2c-mux-gpio.c
@@ -27,11 +27,16 @@ struct gpiomux {
static void i2c_mux_gpio_set(const struct gpiomux *mux, unsigned val)
{
+ unsigned gpio;
int i;
- for (i = 0; i < mux->data.n_gpios; i++)
- gpio_set_value(mux->gpio_base + mux->data.gpios[i],
- val & (1 << i));
+ for (i = 0; i < mux->data.n_gpios; i++) {
+ gpio = mux->gpio_base + mux->data.gpios[i];
+ if (gpio_cansleep(gpio))
+ gpio_set_value_cansleep(gpio, val & (1 << i));
+ else
+ gpio_set_value(gpio, val & (1 << i));
+ }
}
static int i2c_mux_gpio_select(struct i2c_adapter *adap, void *data, u32 chan)
--
1.7.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 1/2] i2c-mux-gpio: test if the gpio can sleep
2013-10-10 8:39 [PATCH 1/2] i2c-mux-gpio: test if the gpio can sleep Ionut Nicu
@ 2013-10-10 8:46 ` Wolfram Sang
2013-10-10 8:46 ` Lars-Peter Clausen
1 sibling, 0 replies; 6+ messages in thread
From: Wolfram Sang @ 2013-10-10 8:46 UTC (permalink / raw)
To: Ionut Nicu
Cc: Peter Korsgaard, Alexander Sverdlin, linux-i2c, linux-kernel,
linux-gpio
[-- Attachment #1: Type: text/plain, Size: 1220 bytes --]
On Thu, Oct 10, 2013 at 10:39:32AM +0200, Ionut Nicu wrote:
> Some gpio chips may have get/set operations that
> can sleep. For this type of chips we must use the
> _cansleep() version of gpio_set_value.
>
> Signed-off-by: Ionut Nicu <ioan.nicu.ext@nsn.com>
> ---
> drivers/i2c/muxes/i2c-mux-gpio.c | 11 ++++++++---
> 1 files changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/i2c/muxes/i2c-mux-gpio.c b/drivers/i2c/muxes/i2c-mux-gpio.c
> index a764da7..b5f17ef 100644
> --- a/drivers/i2c/muxes/i2c-mux-gpio.c
> +++ b/drivers/i2c/muxes/i2c-mux-gpio.c
> @@ -27,11 +27,16 @@ struct gpiomux {
>
> static void i2c_mux_gpio_set(const struct gpiomux *mux, unsigned val)
> {
> + unsigned gpio;
> int i;
>
> - for (i = 0; i < mux->data.n_gpios; i++)
> - gpio_set_value(mux->gpio_base + mux->data.gpios[i],
> - val & (1 << i));
> + for (i = 0; i < mux->data.n_gpios; i++) {
> + gpio = mux->gpio_base + mux->data.gpios[i];
> + if (gpio_cansleep(gpio))
> + gpio_set_value_cansleep(gpio, val & (1 << i));
> + else
> + gpio_set_value(gpio, val & (1 << i));
> + }
There should be a wrapper for that in the gpio-subsystem IMO.
Adding linux-gpio to cc.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 1/2] i2c-mux-gpio: test if the gpio can sleep
2013-10-10 8:39 [PATCH 1/2] i2c-mux-gpio: test if the gpio can sleep Ionut Nicu
2013-10-10 8:46 ` Wolfram Sang
@ 2013-10-10 8:46 ` Lars-Peter Clausen
2013-10-10 8:57 ` Ionut Nicu
2013-10-10 19:43 ` Wolfram Sang
1 sibling, 2 replies; 6+ messages in thread
From: Lars-Peter Clausen @ 2013-10-10 8:46 UTC (permalink / raw)
To: Ionut Nicu
Cc: Peter Korsgaard, Wolfram Sang, Alexander Sverdlin, linux-i2c,
linux-kernel
On 10/10/2013 10:39 AM, Ionut Nicu wrote:
> Some gpio chips may have get/set operations that
> can sleep. For this type of chips we must use the
> _cansleep() version of gpio_set_value.
>
> Signed-off-by: Ionut Nicu <ioan.nicu.ext@nsn.com>
> ---
> drivers/i2c/muxes/i2c-mux-gpio.c | 11 ++++++++---
> 1 files changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/i2c/muxes/i2c-mux-gpio.c b/drivers/i2c/muxes/i2c-mux-gpio.c
> index a764da7..b5f17ef 100644
> --- a/drivers/i2c/muxes/i2c-mux-gpio.c
> +++ b/drivers/i2c/muxes/i2c-mux-gpio.c
> @@ -27,11 +27,16 @@ struct gpiomux {
>
> static void i2c_mux_gpio_set(const struct gpiomux *mux, unsigned val)
> {
> + unsigned gpio;
> int i;
>
> - for (i = 0; i < mux->data.n_gpios; i++)
> - gpio_set_value(mux->gpio_base + mux->data.gpios[i],
> - val & (1 << i));
> + for (i = 0; i < mux->data.n_gpios; i++) {
> + gpio = mux->gpio_base + mux->data.gpios[i];
> + if (gpio_cansleep(gpio))
> + gpio_set_value_cansleep(gpio, val & (1 << i));
> + else
> + gpio_set_value(gpio, val & (1 << i));
The proper way to do this is just always use the _cansleep() version.
gpio_set_value() only works for chips which do not sleep,
gpio_set_value_cansleep() works for both those who do sleep and those who do
not.
> + }
> }
>
> static int i2c_mux_gpio_select(struct i2c_adapter *adap, void *data, u32 chan)
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 1/2] i2c-mux-gpio: test if the gpio can sleep
2013-10-10 8:46 ` Lars-Peter Clausen
@ 2013-10-10 8:57 ` Ionut Nicu
2013-10-10 19:43 ` Wolfram Sang
1 sibling, 0 replies; 6+ messages in thread
From: Ionut Nicu @ 2013-10-10 8:57 UTC (permalink / raw)
To: Lars-Peter Clausen
Cc: Peter Korsgaard, Wolfram Sang, Alexander Sverdlin, linux-i2c,
linux-kernel
On 10.10.2013 10:46, ext Lars-Peter Clausen wrote:
> On 10/10/2013 10:39 AM, Ionut Nicu wrote:
>> Some gpio chips may have get/set operations that
>> can sleep. For this type of chips we must use the
>> _cansleep() version of gpio_set_value.
>>
>> Signed-off-by: Ionut Nicu <ioan.nicu.ext@nsn.com>
>> ---
>> drivers/i2c/muxes/i2c-mux-gpio.c | 11 ++++++++---
>> 1 files changed, 8 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/i2c/muxes/i2c-mux-gpio.c b/drivers/i2c/muxes/i2c-mux-gpio.c
>> index a764da7..b5f17ef 100644
>> --- a/drivers/i2c/muxes/i2c-mux-gpio.c
>> +++ b/drivers/i2c/muxes/i2c-mux-gpio.c
>> @@ -27,11 +27,16 @@ struct gpiomux {
>>
>> static void i2c_mux_gpio_set(const struct gpiomux *mux, unsigned val)
>> {
>> + unsigned gpio;
>> int i;
>>
>> - for (i = 0; i < mux->data.n_gpios; i++)
>> - gpio_set_value(mux->gpio_base + mux->data.gpios[i],
>> - val & (1 << i));
>> + for (i = 0; i < mux->data.n_gpios; i++) {
>> + gpio = mux->gpio_base + mux->data.gpios[i];
>> + if (gpio_cansleep(gpio))
>> + gpio_set_value_cansleep(gpio, val & (1 << i));
>> + else
>> + gpio_set_value(gpio, val & (1 << i));
>
> The proper way to do this is just always use the _cansleep() version.
> gpio_set_value() only works for chips which do not sleep,
> gpio_set_value_cansleep() works for both those who do sleep and those who do
> not.
>
Ok, then I will re-work the patch to do just that. Thanks!
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 1/2] i2c-mux-gpio: test if the gpio can sleep
2013-10-10 8:46 ` Lars-Peter Clausen
2013-10-10 8:57 ` Ionut Nicu
@ 2013-10-10 19:43 ` Wolfram Sang
2013-10-10 19:51 ` Lars-Peter Clausen
1 sibling, 1 reply; 6+ messages in thread
From: Wolfram Sang @ 2013-10-10 19:43 UTC (permalink / raw)
To: Lars-Peter Clausen
Cc: Ionut Nicu, Peter Korsgaard, Alexander Sverdlin, linux-i2c,
linux-kernel, linux-gpio
[-- Attachment #1: Type: text/plain, Size: 665 bytes --]
On Thu, Oct 10, 2013 at 10:46:41AM +0200, Lars-Peter Clausen wrote:
> > + if (gpio_cansleep(gpio))
> > + gpio_set_value_cansleep(gpio, val & (1 << i));
> > + else
> > + gpio_set_value(gpio, val & (1 << i));
>
> The proper way to do this is just always use the _cansleep() version.
> gpio_set_value() only works for chips which do not sleep,
> gpio_set_value_cansleep() works for both those who do sleep and those who do
> not.
To the gpio-list: Has it been considered to have sth. like
gpio_set_value and gpio_set_value_nosleep? I'd think it makes more sense
to have the specific function have the specific name.
Regards,
Wolfram
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] i2c-mux-gpio: test if the gpio can sleep
2013-10-10 19:43 ` Wolfram Sang
@ 2013-10-10 19:51 ` Lars-Peter Clausen
0 siblings, 0 replies; 6+ messages in thread
From: Lars-Peter Clausen @ 2013-10-10 19:51 UTC (permalink / raw)
To: Wolfram Sang
Cc: Ionut Nicu, Peter Korsgaard, Alexander Sverdlin, linux-i2c,
linux-kernel, linux-gpio
On 10/10/2013 09:43 PM, Wolfram Sang wrote:
> On Thu, Oct 10, 2013 at 10:46:41AM +0200, Lars-Peter Clausen wrote:
>
>>> + if (gpio_cansleep(gpio))
>>> + gpio_set_value_cansleep(gpio, val & (1 << i));
>>> + else
>>> + gpio_set_value(gpio, val & (1 << i));
>>
>> The proper way to do this is just always use the _cansleep() version.
>> gpio_set_value() only works for chips which do not sleep,
>> gpio_set_value_cansleep() works for both those who do sleep and those who do
>> not.
>
> To the gpio-list: Has it been considered to have sth. like
> gpio_set_value and gpio_set_value_nosleep? I'd think it makes more sense
> to have the specific function have the specific name.
It has been a few times, but I think the conclusion has always been that it is
now too late to invert the semantics of gpio_set_value(). If you want to look
up the discussions the keyword is gpio_set_value_atomic().
- Lars
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-10-10 19:50 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-10 8:39 [PATCH 1/2] i2c-mux-gpio: test if the gpio can sleep Ionut Nicu
2013-10-10 8:46 ` Wolfram Sang
2013-10-10 8:46 ` Lars-Peter Clausen
2013-10-10 8:57 ` Ionut Nicu
2013-10-10 19:43 ` Wolfram Sang
2013-10-10 19:51 ` Lars-Peter Clausen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox