Re: [PATCH v6] extcon: palmas: Added a new compatible type *ti,palmas-usb-vid*

Kishon Vijay Abraham I
2013-10-11T06:15:59Z

On Thursday 10 October 2013 06:41 PM, Laxman Dewangan wrote:
> On Thursday 10 October 2013 06:07 PM, Kishon Vijay Abraham I wrote:
>> The Palmas device contains only a USB VBUS-ID detector, so added a
>> compatible type *ti,palmas-usb-vid*. Didn't remove the existing compatible
>> types for backward compatibility.
>>
> I dont have much issue on this nomenclature but just second thought:
>
> The Palmas USB module is capable of detection VBUS, ID-GND, ID-RA, ID-RB, ID-RC
> and ID-FLOAT as per BC1.2.
> This sub-module only detect the cable, does nothing more than this.
> In this case, should we say "ti,palmas-usb-extcon"?
> Again extcon is linux specific terminology and this can be defer.

I don't mind either way. Chanwoo?

-Kishon