From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752817Ab3JLCrp (ORCPT ); Fri, 11 Oct 2013 22:47:45 -0400 Received: from mail.active-venture.com ([67.228.131.205]:53096 "EHLO mail.active-venture.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751680Ab3JLCrn (ORCPT ); Fri, 11 Oct 2013 22:47:43 -0400 X-Originating-IP: 108.223.40.66 Message-ID: <5258B849.7060709@roeck-us.net> Date: Fri, 11 Oct 2013 19:47:37 -0700 From: Guenter Roeck User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.0 MIME-Version: 1.0 To: Maxime Ripard , wim@iguana.be CC: linux-arm-kernel@lists.infradead.org, carlo.caione@gmail.com, linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] wdt: sunxi: Fix section mismatch References: <1380982817-10234-1-git-send-email-maxime.ripard@free-electrons.com> <20131011191527.GO3041@lukather> In-Reply-To: <20131011191527.GO3041@lukather> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/11/2013 12:15 PM, Maxime Ripard wrote: > Hi Wim, > > On Sat, Oct 05, 2013 at 04:20:17PM +0200, Maxime Ripard wrote: >> This driver has a section mismatch, for probe and remove functions, >> leading to the following warning during the compilation. >> >> WARNING: drivers/watchdog/built-in.o(.data+0x24): Section mismatch in >> reference from the variable sunxi_wdt_driver to the function >> .init.text:sunxi_wdt_probe() >> The variable sunxi_wdt_driver references >> the function __init sunxi_wdt_probe() >> >> Signed-off-by: Maxime Ripard > > It would be great if it could go in 3.12. > Hi Maxime, Just wondering - is this a nuisance or does it cause a real problem ? > Do you want to take it, or can I merge it through my tree, with your > Acked-by? > In addition to this patch, the following two would also be good to have in 3.12. http://www.spinics.net/lists/linux-watchdog/msg02867.html http://www.spinics.net/lists/linux-watchdog/msg02950.html Thanks, Guenter