From: Shinya Kuribayashi <skuribay@pobox.com>
To: rmallon@gmail.com, mika.westerberg@linux.intel.com,
Romain.Baeriswyl@abilis.com
Cc: wsa@the-dreams.de, rob.herring@calxeda.com, pawel.moll@arm.com,
mark.rutland@arm.com, swarren@wwwdotorg.org,
ijc+devicetree@hellion.org.uk, rob@landley.net,
pierrick.hascoet@abilis.com, vgupta@synopsys.com,
christian.ruppert@abilis.com, chiau.ee.chew@intel.com,
khali@linux-fr.org, rafael.j.wysocki@intel.com,
devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org,
romainba@abilis.com
Subject: Re: [PATCH 1/2] i2c designware make SCL and SDA falling time configurable
Date: Sun, 13 Oct 2013 20:36:54 +0900 [thread overview]
Message-ID: <525A85D6.3090608@pobox.com> (raw)
In-Reply-To: <5255FAB5.7080803@gmail.com>
On 10/10/13 9:54 AM, Ryan Mallon wrote:
> On 09/10/13 18:55, Mika Westerberg wrote:
>> On Tue, Oct 08, 2013 at 05:00:54PM +0200, Romain Baeriswyl wrote:
>>> @@ -307,15 +309,25 @@ int i2c_dw_init(struct dw_i2c_dev *dev)
>>>
>>> /* set standard and fast speed deviders for high/low periods */
>>>
>>> + if (dev->sda_falling_time)
>>> + sda_falling_time = dev->sda_falling_time;
>>> + else
>>> + sda_falling_time = 300; /* ns */
>>
>> I think this looks better:
>>
>> sda_falling_time = dev->sda_falling_time ? dev->sda_falling_time : 300;
>
> You can also use the gcc-ism, which is a bit more concise:
>
> sda_falling_time = dev->sda_falling_time ?: 300;
+1
next prev parent reply other threads:[~2013-10-13 11:37 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-08 11:45 [PATCH 1/2] i2c-designware: make *CNT values configurable Mika Westerberg
2013-07-08 11:45 ` [PATCH 2/2] i2c-designware: configure *CNT values from ACPI Mika Westerberg
2013-07-10 13:01 ` Mika Westerberg
2013-07-08 13:42 ` [PATCH 1/2] i2c-designware: make *CNT values configurable Christian Ruppert
2013-07-09 8:44 ` Mika Westerberg
2013-07-09 16:19 ` Christian Ruppert
2013-07-10 10:52 ` Mika Westerberg
2013-07-10 16:56 ` Christian Ruppert
2013-07-11 7:36 ` Mika Westerberg
2013-07-11 10:13 ` Mika Westerberg
2013-07-12 7:56 ` Shinya Kuribayashi
2013-07-12 8:51 ` Mika Westerberg
2013-07-13 5:36 ` Shinya Kuribayashi
2013-07-16 11:16 ` Christian Ruppert
2013-07-17 14:39 ` Shinya Kuribayashi
2013-07-22 13:17 ` Christian Ruppert
2013-07-24 14:31 ` Shinya Kuribayashi
2013-08-05 9:31 ` Christian Ruppert
2013-08-05 10:02 ` Wolfram Sang
2013-08-12 7:48 ` Christian Ruppert
2013-08-12 11:09 ` Wolfram Sang
2013-08-16 2:15 ` Shinya Kuribayashi
2013-08-19 11:36 ` Mika Westerberg
2013-08-19 12:22 ` Shinya Kuribayashi
2013-08-21 14:39 ` Christian Ruppert
2013-08-24 4:58 ` Shinya Kuribayashi
2013-08-28 15:34 ` Christian Ruppert
2013-10-08 15:00 ` [PATCH 1/2] i2c designware make SCL and SDA falling time configurable Romain Baeriswyl
2013-10-09 7:55 ` Mika Westerberg
2013-10-10 0:54 ` Ryan Mallon
2013-10-13 11:36 ` Shinya Kuribayashi [this message]
2014-01-16 19:43 ` Wolfram Sang
2014-01-20 16:43 ` [PATCH v2 " Romain Baeriswyl
2014-03-09 8:20 ` Wolfram Sang
2013-10-08 15:00 ` [PATCH 2/2] i2c designware add support of I2C standard mode Romain Baeriswyl
2013-10-09 7:56 ` Mika Westerberg
2013-10-13 11:46 ` Shinya Kuribayashi
2014-01-16 19:33 ` Wolfram Sang
2014-01-20 16:45 ` [PATCH v2 " Romain Baeriswyl
2014-03-09 8:07 ` Wolfram Sang
2014-03-25 10:18 ` [PATCH V3 " Romain Baeriswyl
2013-08-19 6:39 ` [PATCH 1/2] i2c-designware: make *CNT values configurable Mika Westerberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=525A85D6.3090608@pobox.com \
--to=skuribay@pobox.com \
--cc=Romain.Baeriswyl@abilis.com \
--cc=chiau.ee.chew@intel.com \
--cc=christian.ruppert@abilis.com \
--cc=devicetree@vger.kernel.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=khali@linux-fr.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mika.westerberg@linux.intel.com \
--cc=pawel.moll@arm.com \
--cc=pierrick.hascoet@abilis.com \
--cc=rafael.j.wysocki@intel.com \
--cc=rmallon@gmail.com \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=romainba@abilis.com \
--cc=swarren@wwwdotorg.org \
--cc=vgupta@synopsys.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox