From: Jiang Liu <liuj97@gmail.com>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: Will Deacon <Will.Deacon@arm.com>,
Jiang Liu <jiang.liu@huawei.com>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [RFT PATCH v2 1/4] arm64: fix possible invalid FPSIMD initialization state
Date: Mon, 14 Oct 2013 21:58:36 +0800 [thread overview]
Message-ID: <525BF88C.4070608@gmail.com> (raw)
In-Reply-To: <20131014135457.GE7682@arm.com>
On 10/14/2013 09:54 PM, Catalin Marinas wrote:
> On Sun, Oct 13, 2013 at 03:20:17PM +0100, Jiang Liu wrote:
>> From: Jiang Liu <jiang.liu@huawei.com>
>>
>> If context switching happens during executing fpsimd_flush_thread(),
>> stale value in FPSIMD registers will be saved into current thread's
>> fpsimd_state by fpsimd_thread_switch(). That may cause invalid
>> initialization state for the new process, so disable preemption
>> when executing fpsimd_flush_thread().
>>
>> Signed-off-by: Jiang Liu <jiang.liu@huawei.com>
>> Cc: Jiang Liu <liuj97@gmail.com>
>
> That's already in mainline (3.12-rc4).
>
Hi Catalin,
I haven't noticed that yet, sorry for the noise:)
Thanks!
Gerry
prev parent reply other threads:[~2013-10-14 13:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-13 14:20 [RFT PATCH v2 1/4] arm64: fix possible invalid FPSIMD initialization state Jiang Liu
2013-10-13 14:20 ` [RFT PATCH v2 2/4] arm64: restore FPSIMD to default state for kernel and signal contexts Jiang Liu
2013-10-14 15:16 ` Will Deacon
2013-10-14 15:30 ` Jiang Liu
2013-10-14 15:39 ` Will Deacon
2013-10-14 15:50 ` Jiang Liu
2013-10-14 15:23 ` Catalin Marinas
2013-10-13 14:20 ` [RFT PATCH v2 3/4] arm64: reduce duplicated code when saving/restoring FPSIMD for signal handling Jiang Liu
2013-10-14 15:44 ` Catalin Marinas
2013-10-14 16:01 ` Jiang Liu
2013-10-13 14:20 ` [RFT PATCH v2 4/4] arm64: reuse FPSIMD hardware context if possible Jiang Liu
2013-10-14 13:54 ` [RFT PATCH v2 1/4] arm64: fix possible invalid FPSIMD initialization state Catalin Marinas
2013-10-14 13:58 ` Jiang Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=525BF88C.4070608@gmail.com \
--to=liuj97@gmail.com \
--cc=Will.Deacon@arm.com \
--cc=ard.biesheuvel@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=jiang.liu@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox