[PATCH 01/11] regulator: core: Fix checkpatch issue

linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed

* [PATCH 01/11] regulator: core: Fix checkpatch issue
@ 2013-10-14  8:44 Jingoo Han
  2013-10-14  8:45 ` [PATCH 02/11] regulator: anatop: " Jingoo Han
                   ` (9 more replies)
  0 siblings, 10 replies; 22+ messages in thread
From: Jingoo Han @ 2013-10-14  8:44 UTC (permalink / raw)
  To: 'Mark Brown'
  Cc: 'Liam Girdwood', linux-kernel, 'Jingoo Han'

Fix the following checkpatch errors and warnings.

  ERROR: trailing whitespace
  WARNING: braces {} are not necessary for single statement blocks

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
 drivers/regulator/core.c |   10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
index 13263d1..e8ccf20 100644
--- a/drivers/regulator/core.c
+++ b/drivers/regulator/core.c
@@ -1287,9 +1287,8 @@ static struct regulator *_regulator_get(struct device *dev, const char *id,
 	 * If we have return value from dev_lookup fail, we do not expect to
 	 * succeed, so, quit with appropriate error value
 	 */
-	if (ret && ret != -ENODEV) {
+	if (ret && ret != -ENODEV)
 		goto out;
-	}
 
 	if (!devname)
 		devname = "deviceless";
@@ -2238,7 +2237,7 @@ int regulator_set_voltage(struct regulator *regulator, int min_uV, int max_uV)
 	ret = regulator_check_voltage(rdev, &min_uV, &max_uV);
 	if (ret < 0)
 		goto out;
-	
+
 	/* restore original values in case of error */
 	old_min_uV = regulator->min_uV;
 	old_max_uV = regulator->max_uV;
@@ -2252,7 +2251,7 @@ int regulator_set_voltage(struct regulator *regulator, int min_uV, int max_uV)
 	ret = _regulator_do_set_voltage(rdev, min_uV, max_uV);
 	if (ret < 0)
 		goto out2;
-	
+
 out:
 	mutex_unlock(&rdev->mutex);
 	return ret;
@@ -3657,9 +3656,8 @@ static int __init regulator_init_complete(void)
 			 * goes wrong. */
 			rdev_info(rdev, "disabling\n");
 			ret = ops->disable(rdev);
-			if (ret != 0) {
+			if (ret != 0)
 				rdev_err(rdev, "couldn't disable: %d\n", ret);
-			}
 		} else {
 			/* The intention is that in future we will
 			 * assume that full constraints are provided
-- 
1.7.10.4



^ permalink raw reply related	[flat|nested] 22+ messages in thread

* [PATCH 02/11] regulator: anatop: Fix checkpatch issue
  2013-10-14  8:44 [PATCH 01/11] regulator: core: Fix checkpatch issue Jingoo Han
@ 2013-10-14  8:45 ` Jingoo Han
  2013-10-14  8:55   ` Shawn Guo
  2013-10-15 12:21   ` Mark Brown
  2013-10-14  8:46 ` [PATCH 03/11] regulator: fixed: " Jingoo Han
                   ` (8 subsequent siblings)
  9 siblings, 2 replies; 22+ messages in thread
From: Jingoo Han @ 2013-10-14  8:45 UTC (permalink / raw)
  To: 'Mark Brown'
  Cc: 'Liam Girdwood', linux-kernel, 'Jingoo Han',
	'Marek Vasut', 'Shawn Guo'

Fix the following checkpatch warning.

  WARNING: quoted string split across lines

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
 drivers/regulator/anatop-regulator.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/regulator/anatop-regulator.c b/drivers/regulator/anatop-regulator.c
index e42bfd1..c734d09 100644
--- a/drivers/regulator/anatop-regulator.c
+++ b/drivers/regulator/anatop-regulator.c
@@ -255,7 +255,7 @@ static void __exit anatop_regulator_exit(void)
 }
 module_exit(anatop_regulator_exit);
 
-MODULE_AUTHOR("Nancy Chen <Nancy.Chen@freescale.com>, "
-	      "Ying-Chun Liu (PaulLiu) <paul.liu@linaro.org>");
+MODULE_AUTHOR("Nancy Chen <Nancy.Chen@freescale.com>");
+MODULE_AUTHOR("Ying-Chun Liu (PaulLiu) <paul.liu@linaro.org>");
 MODULE_DESCRIPTION("ANATOP Regulator driver");
 MODULE_LICENSE("GPL v2");
-- 
1.7.10.4



^ permalink raw reply related	[flat|nested] 22+ messages in thread

* Re: [PATCH 02/11] regulator: anatop: Fix checkpatch issue
  2013-10-14  8:45 ` [PATCH 02/11] regulator: anatop: " Jingoo Han
@ 2013-10-14  8:55   ` Shawn Guo
  2013-10-15 12:21   ` Mark Brown
  1 sibling, 0 replies; 22+ messages in thread
From: Shawn Guo @ 2013-10-14  8:55 UTC (permalink / raw)
  To: Jingoo Han
  Cc: 'Mark Brown', 'Liam Girdwood', linux-kernel,
	'Marek Vasut'

On Mon, Oct 14, 2013 at 05:45:51PM +0900, Jingoo Han wrote:
> Fix the following checkpatch warning.
> 
>   WARNING: quoted string split across lines
> 
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>

Acked-by: Shawn Guo <shawn.guo@linaro.org>

> ---
>  drivers/regulator/anatop-regulator.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/regulator/anatop-regulator.c b/drivers/regulator/anatop-regulator.c
> index e42bfd1..c734d09 100644
> --- a/drivers/regulator/anatop-regulator.c
> +++ b/drivers/regulator/anatop-regulator.c
> @@ -255,7 +255,7 @@ static void __exit anatop_regulator_exit(void)
>  }
>  module_exit(anatop_regulator_exit);
>  
> -MODULE_AUTHOR("Nancy Chen <Nancy.Chen@freescale.com>, "
> -	      "Ying-Chun Liu (PaulLiu) <paul.liu@linaro.org>");
> +MODULE_AUTHOR("Nancy Chen <Nancy.Chen@freescale.com>");
> +MODULE_AUTHOR("Ying-Chun Liu (PaulLiu) <paul.liu@linaro.org>");
>  MODULE_DESCRIPTION("ANATOP Regulator driver");
>  MODULE_LICENSE("GPL v2");
> -- 
> 1.7.10.4
> 
> 


^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: [PATCH 02/11] regulator: anatop: Fix checkpatch issue
  2013-10-14  8:45 ` [PATCH 02/11] regulator: anatop: " Jingoo Han
  2013-10-14  8:55   ` Shawn Guo
@ 2013-10-15 12:21   ` Mark Brown
  1 sibling, 0 replies; 22+ messages in thread
From: Mark Brown @ 2013-10-15 12:21 UTC (permalink / raw)
  To: Jingoo Han
  Cc: 'Liam Girdwood', linux-kernel, 'Marek Vasut',
	'Shawn Guo'

[-- Attachment #1: Type: text/plain, Size: 118 bytes --]

On Mon, Oct 14, 2013 at 05:45:51PM +0900, Jingoo Han wrote:
> Fix the following checkpatch warning.

Applied, thanks.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 22+ messages in thread

* [PATCH 03/11] regulator: fixed: Fix checkpatch issue
  2013-10-14  8:44 [PATCH 01/11] regulator: core: Fix checkpatch issue Jingoo Han
  2013-10-14  8:45 ` [PATCH 02/11] regulator: anatop: " Jingoo Han
@ 2013-10-14  8:46 ` Jingoo Han
  2013-10-15 12:22   ` Mark Brown
  2013-10-14  8:47 ` [PATCH 04/11] regulator: lp3971: " Jingoo Han
                   ` (7 subsequent siblings)
  9 siblings, 1 reply; 22+ messages in thread
From: Jingoo Han @ 2013-10-14  8:46 UTC (permalink / raw)
  To: 'Mark Brown'
  Cc: 'Liam Girdwood', linux-kernel, 'Jingoo Han',
	'Laxman Dewangan'

Fix the following checkpatch warnings.

  WARNING: braces {} are not necessary for any arm of this statement

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
 drivers/regulator/fixed.c |   10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/drivers/regulator/fixed.c b/drivers/regulator/fixed.c
index de811f3..5ea64b9 100644
--- a/drivers/regulator/fixed.c
+++ b/drivers/regulator/fixed.c
@@ -168,17 +168,15 @@ static int reg_fixed_voltage_probe(struct platform_device *pdev)
 		cfg.ena_gpio = config->gpio;
 	cfg.ena_gpio_invert = !config->enable_high;
 	if (config->enabled_at_boot) {
-		if (config->enable_high) {
+		if (config->enable_high)
 			cfg.ena_gpio_flags |= GPIOF_OUT_INIT_HIGH;
-		} else {
+		else
 			cfg.ena_gpio_flags |= GPIOF_OUT_INIT_LOW;
-		}
 	} else {
-		if (config->enable_high) {
+		if (config->enable_high)
 			cfg.ena_gpio_flags |= GPIOF_OUT_INIT_LOW;
-		} else {
+		else
 			cfg.ena_gpio_flags |= GPIOF_OUT_INIT_HIGH;
-		}
 	}
 	if (config->gpio_is_open_drain)
 		cfg.ena_gpio_flags |= GPIOF_OPEN_DRAIN;
-- 
1.7.10.4



^ permalink raw reply related	[flat|nested] 22+ messages in thread

* Re: [PATCH 03/11] regulator: fixed: Fix checkpatch issue
  2013-10-14  8:46 ` [PATCH 03/11] regulator: fixed: " Jingoo Han
@ 2013-10-15 12:22   ` Mark Brown
  0 siblings, 0 replies; 22+ messages in thread
From: Mark Brown @ 2013-10-15 12:22 UTC (permalink / raw)
  To: Jingoo Han
  Cc: 'Liam Girdwood', linux-kernel, 'Laxman Dewangan'

[-- Attachment #1: Type: text/plain, Size: 119 bytes --]

On Mon, Oct 14, 2013 at 05:46:36PM +0900, Jingoo Han wrote:
> Fix the following checkpatch warnings.

Applied, thanks.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 22+ messages in thread

* [PATCH 04/11] regulator: lp3971: Fix checkpatch issue
  2013-10-14  8:44 [PATCH 01/11] regulator: core: Fix checkpatch issue Jingoo Han
  2013-10-14  8:45 ` [PATCH 02/11] regulator: anatop: " Jingoo Han
  2013-10-14  8:46 ` [PATCH 03/11] regulator: fixed: " Jingoo Han
@ 2013-10-14  8:47 ` Jingoo Han
  2013-10-15 12:23   ` Mark Brown
  2013-10-14  8:49 ` [PATCH 05/11] regulator: max8997: " Jingoo Han
                   ` (6 subsequent siblings)
  9 siblings, 1 reply; 22+ messages in thread
From: Jingoo Han @ 2013-10-14  8:47 UTC (permalink / raw)
  To: 'Mark Brown'
  Cc: 'Liam Girdwood', linux-kernel, 'Jingoo Han',
	'Marek Szyprowski'

Fix the following checkpatch warnings.

  WARNING: please, no spaces at the start of a line

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
 drivers/regulator/lp3971.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/regulator/lp3971.c b/drivers/regulator/lp3971.c
index 5a4604e..947c05f 100644
--- a/drivers/regulator/lp3971.c
+++ b/drivers/regulator/lp3971.c
@@ -474,8 +474,8 @@ static int lp3971_i2c_remove(struct i2c_client *i2c)
 }
 
 static const struct i2c_device_id lp3971_i2c_id[] = {
-       { "lp3971", 0 },
-       { }
+	{ "lp3971", 0 },
+	{ }
 };
 MODULE_DEVICE_TABLE(i2c, lp3971_i2c_id);
 
-- 
1.7.10.4



^ permalink raw reply related	[flat|nested] 22+ messages in thread

* Re: [PATCH 04/11] regulator: lp3971: Fix checkpatch issue
  2013-10-14  8:47 ` [PATCH 04/11] regulator: lp3971: " Jingoo Han
@ 2013-10-15 12:23   ` Mark Brown
  0 siblings, 0 replies; 22+ messages in thread
From: Mark Brown @ 2013-10-15 12:23 UTC (permalink / raw)
  To: Jingoo Han
  Cc: 'Liam Girdwood', linux-kernel, 'Marek Szyprowski'

[-- Attachment #1: Type: text/plain, Size: 119 bytes --]

On Mon, Oct 14, 2013 at 05:47:31PM +0900, Jingoo Han wrote:
> Fix the following checkpatch warnings.

Applied, thanks.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 22+ messages in thread

* [PATCH 05/11] regulator: max8997: Fix checkpatch issue
  2013-10-14  8:44 [PATCH 01/11] regulator: core: Fix checkpatch issue Jingoo Han
                   ` (2 preceding siblings ...)
  2013-10-14  8:47 ` [PATCH 04/11] regulator: lp3971: " Jingoo Han
@ 2013-10-14  8:49 ` Jingoo Han
  2013-10-15 12:24   ` Mark Brown
  2013-10-14  8:49 ` [PATCH 06/11] regulator: mc13783: " Jingoo Han
                   ` (5 subsequent siblings)
  9 siblings, 1 reply; 22+ messages in thread
From: Jingoo Han @ 2013-10-14  8:49 UTC (permalink / raw)
  To: 'Mark Brown'
  Cc: 'Liam Girdwood', linux-kernel, 'Jingoo Han',
	'MyungJoo Ham'

Fix the following checkpatch warning.

  WARNING: quoted string split across lines

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
 drivers/regulator/max8997.c |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/regulator/max8997.c b/drivers/regulator/max8997.c
index bcd2488..2d618fc 100644
--- a/drivers/regulator/max8997.c
+++ b/drivers/regulator/max8997.c
@@ -690,8 +690,9 @@ static int max8997_set_voltage_buck(struct regulator_dev *rdev,
 	if (max8997->ignore_gpiodvs_side_effect == false)
 		return -EINVAL;
 
-	dev_warn(&rdev->dev, "MAX8997 GPIO-DVS Side Effect Warning: GPIO SET:"
-			" %d -> %d\n", max8997->buck125_gpioindex, tmp_idx);
+	dev_warn(&rdev->dev,
+		"MAX8997 GPIO-DVS Side Effect Warning: GPIO SET:  %d -> %d\n",
+		max8997->buck125_gpioindex, tmp_idx);
 
 out:
 	if (new_idx < 0 || new_val < 0)
-- 
1.7.10.4



^ permalink raw reply related	[flat|nested] 22+ messages in thread

* Re: [PATCH 05/11] regulator: max8997: Fix checkpatch issue
  2013-10-14  8:49 ` [PATCH 05/11] regulator: max8997: " Jingoo Han
@ 2013-10-15 12:24   ` Mark Brown
  0 siblings, 0 replies; 22+ messages in thread
From: Mark Brown @ 2013-10-15 12:24 UTC (permalink / raw)
  To: Jingoo Han; +Cc: 'Liam Girdwood', linux-kernel, 'MyungJoo Ham'

[-- Attachment #1: Type: text/plain, Size: 118 bytes --]

On Mon, Oct 14, 2013 at 05:49:11PM +0900, Jingoo Han wrote:
> Fix the following checkpatch warning.

Applied, thanks.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 22+ messages in thread

* [PATCH 06/11] regulator: mc13783: Fix checkpatch issue
  2013-10-14  8:44 [PATCH 01/11] regulator: core: Fix checkpatch issue Jingoo Han
                   ` (3 preceding siblings ...)
  2013-10-14  8:49 ` [PATCH 05/11] regulator: max8997: " Jingoo Han
@ 2013-10-14  8:49 ` Jingoo Han
  2013-10-15 12:25   ` Mark Brown
  2013-10-14  8:51 ` [PATCH 07/11] regulator: mc13892: " Jingoo Han
                   ` (4 subsequent siblings)
  9 siblings, 1 reply; 22+ messages in thread
From: Jingoo Han @ 2013-10-14  8:49 UTC (permalink / raw)
  To: 'Mark Brown'
  Cc: 'Liam Girdwood', linux-kernel, 'Jingoo Han',
	'Sascha Hauer'

Fix the following checkpatch warnings.

  WARNING: Avoid unnecessary line continuations

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
 drivers/regulator/mc13783-regulator.c |   28 ++++++++++++++--------------
 1 file changed, 14 insertions(+), 14 deletions(-)

diff --git a/drivers/regulator/mc13783-regulator.c b/drivers/regulator/mc13783-regulator.c
index f036b26..7f4a67e 100644
--- a/drivers/regulator/mc13783-regulator.c
+++ b/drivers/regulator/mc13783-regulator.c
@@ -258,34 +258,34 @@ static struct mc13xxx_regulator mc13783_regulators[] = {
 
 	MC13783_FIXED_DEFINE(REG, VAUDIO, REGULATORMODE0, mc13783_vaudio_val),
 	MC13783_FIXED_DEFINE(REG, VIOHI, REGULATORMODE0, mc13783_viohi_val),
-	MC13783_DEFINE_REGU(VIOLO, REGULATORMODE0, REGULATORSETTING0,	\
+	MC13783_DEFINE_REGU(VIOLO, REGULATORMODE0, REGULATORSETTING0,
 			    mc13783_violo_val),
-	MC13783_DEFINE_REGU(VDIG, REGULATORMODE0, REGULATORSETTING0,	\
+	MC13783_DEFINE_REGU(VDIG, REGULATORMODE0, REGULATORSETTING0,
 			    mc13783_vdig_val),
-	MC13783_DEFINE_REGU(VGEN, REGULATORMODE0, REGULATORSETTING0,	\
+	MC13783_DEFINE_REGU(VGEN, REGULATORMODE0, REGULATORSETTING0,
 			    mc13783_vgen_val),
-	MC13783_DEFINE_REGU(VRFDIG, REGULATORMODE0, REGULATORSETTING0,	\
+	MC13783_DEFINE_REGU(VRFDIG, REGULATORMODE0, REGULATORSETTING0,
 			    mc13783_vrfdig_val),
-	MC13783_DEFINE_REGU(VRFREF, REGULATORMODE0, REGULATORSETTING0,	\
+	MC13783_DEFINE_REGU(VRFREF, REGULATORMODE0, REGULATORSETTING0,
 			    mc13783_vrfref_val),
-	MC13783_DEFINE_REGU(VRFCP, REGULATORMODE0, REGULATORSETTING0,	\
+	MC13783_DEFINE_REGU(VRFCP, REGULATORMODE0, REGULATORSETTING0,
 			    mc13783_vrfcp_val),
-	MC13783_DEFINE_REGU(VSIM, REGULATORMODE1, REGULATORSETTING0,	\
+	MC13783_DEFINE_REGU(VSIM, REGULATORMODE1, REGULATORSETTING0,
 			    mc13783_vsim_val),
-	MC13783_DEFINE_REGU(VESIM, REGULATORMODE1, REGULATORSETTING0,	\
+	MC13783_DEFINE_REGU(VESIM, REGULATORMODE1, REGULATORSETTING0,
 			    mc13783_vesim_val),
-	MC13783_DEFINE_REGU(VCAM, REGULATORMODE1, REGULATORSETTING0,	\
+	MC13783_DEFINE_REGU(VCAM, REGULATORMODE1, REGULATORSETTING0,
 			    mc13783_vcam_val),
 	MC13783_FIXED_DEFINE(REG, VRFBG, REGULATORMODE1, mc13783_vrfbg_val),
-	MC13783_DEFINE_REGU(VVIB, REGULATORMODE1, REGULATORSETTING1,	\
+	MC13783_DEFINE_REGU(VVIB, REGULATORMODE1, REGULATORSETTING1,
 			    mc13783_vvib_val),
-	MC13783_DEFINE_REGU(VRF1, REGULATORMODE1, REGULATORSETTING1,	\
+	MC13783_DEFINE_REGU(VRF1, REGULATORMODE1, REGULATORSETTING1,
 			    mc13783_vrf_val),
-	MC13783_DEFINE_REGU(VRF2, REGULATORMODE1, REGULATORSETTING1,	\
+	MC13783_DEFINE_REGU(VRF2, REGULATORMODE1, REGULATORSETTING1,
 			    mc13783_vrf_val),
-	MC13783_DEFINE_REGU(VMMC1, REGULATORMODE1, REGULATORSETTING1,	\
+	MC13783_DEFINE_REGU(VMMC1, REGULATORMODE1, REGULATORSETTING1,
 			    mc13783_vmmc_val),
-	MC13783_DEFINE_REGU(VMMC2, REGULATORMODE1, REGULATORSETTING1,	\
+	MC13783_DEFINE_REGU(VMMC2, REGULATORMODE1, REGULATORSETTING1,
 			    mc13783_vmmc_val),
 	MC13783_GPO_DEFINE(REG, GPO1, POWERMISC, mc13783_gpo_val),
 	MC13783_GPO_DEFINE(REG, GPO2, POWERMISC, mc13783_gpo_val),
-- 
1.7.10.4



^ permalink raw reply related	[flat|nested] 22+ messages in thread

* Re: [PATCH 06/11] regulator: mc13783: Fix checkpatch issue
  2013-10-14  8:49 ` [PATCH 06/11] regulator: mc13783: " Jingoo Han
@ 2013-10-15 12:25   ` Mark Brown
  0 siblings, 0 replies; 22+ messages in thread
From: Mark Brown @ 2013-10-15 12:25 UTC (permalink / raw)
  To: Jingoo Han; +Cc: 'Liam Girdwood', linux-kernel, 'Sascha Hauer'

[-- Attachment #1: Type: text/plain, Size: 119 bytes --]

On Mon, Oct 14, 2013 at 05:49:55PM +0900, Jingoo Han wrote:
> Fix the following checkpatch warnings.

Applied, thanks.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 22+ messages in thread

* [PATCH 07/11] regulator: mc13892: Fix checkpatch issue
  2013-10-14  8:44 [PATCH 01/11] regulator: core: Fix checkpatch issue Jingoo Han
                   ` (4 preceding siblings ...)
  2013-10-14  8:49 ` [PATCH 06/11] regulator: mc13783: " Jingoo Han
@ 2013-10-14  8:51 ` Jingoo Han
  2013-10-15 12:26   ` Mark Brown
  2013-10-14  8:51 ` [PATCH 08/11] regulator: tps6105x: " Jingoo Han
                   ` (3 subsequent siblings)
  9 siblings, 1 reply; 22+ messages in thread
From: Jingoo Han @ 2013-10-14  8:51 UTC (permalink / raw)
  To: 'Mark Brown'
  Cc: 'Liam Girdwood', linux-kernel, 'Jingoo Han',
	'Sascha Hauer'

Fix the following checkpatch warnings.

  WARNING: Avoid unnecessary line continuations
  WARNING: line over 80 characters

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
 drivers/regulator/mc13892-regulator.c |   24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/drivers/regulator/mc13892-regulator.c b/drivers/regulator/mc13892-regulator.c
index 96c9f80..f374fa5 100644
--- a/drivers/regulator/mc13892-regulator.c
+++ b/drivers/regulator/mc13892-regulator.c
@@ -274,25 +274,25 @@ static struct mc13xxx_regulator mc13892_regulators[] = {
 	MC13892_SW_DEFINE(SW4, SWITCHERS3, SWITCHERS3, mc13892_sw),
 	MC13892_FIXED_DEFINE(SWBST, SWITCHERS5, mc13892_swbst),
 	MC13892_FIXED_DEFINE(VIOHI, REGULATORMODE0, mc13892_viohi),
-	MC13892_DEFINE_REGU(VPLL, REGULATORMODE0, REGULATORSETTING0,	\
+	MC13892_DEFINE_REGU(VPLL, REGULATORMODE0, REGULATORSETTING0,
 		mc13892_vpll),
-	MC13892_DEFINE_REGU(VDIG, REGULATORMODE0, REGULATORSETTING0,	\
+	MC13892_DEFINE_REGU(VDIG, REGULATORMODE0, REGULATORSETTING0,
 		mc13892_vdig),
-	MC13892_DEFINE_REGU(VSD, REGULATORMODE1, REGULATORSETTING1,	\
+	MC13892_DEFINE_REGU(VSD, REGULATORMODE1, REGULATORSETTING1,
 		mc13892_vsd),
-	MC13892_DEFINE_REGU(VUSB2, REGULATORMODE0, REGULATORSETTING0,	\
+	MC13892_DEFINE_REGU(VUSB2, REGULATORMODE0, REGULATORSETTING0,
 		mc13892_vusb2),
-	MC13892_DEFINE_REGU(VVIDEO, REGULATORMODE1, REGULATORSETTING1,	\
+	MC13892_DEFINE_REGU(VVIDEO, REGULATORMODE1, REGULATORSETTING1,
 		mc13892_vvideo),
-	MC13892_DEFINE_REGU(VAUDIO, REGULATORMODE1, REGULATORSETTING1,	\
+	MC13892_DEFINE_REGU(VAUDIO, REGULATORMODE1, REGULATORSETTING1,
 		mc13892_vaudio),
-	MC13892_DEFINE_REGU(VCAM, REGULATORMODE1, REGULATORSETTING0,	\
+	MC13892_DEFINE_REGU(VCAM, REGULATORMODE1, REGULATORSETTING0,
 		mc13892_vcam),
-	MC13892_DEFINE_REGU(VGEN1, REGULATORMODE0, REGULATORSETTING0,	\
+	MC13892_DEFINE_REGU(VGEN1, REGULATORMODE0, REGULATORSETTING0,
 		mc13892_vgen1),
-	MC13892_DEFINE_REGU(VGEN2, REGULATORMODE0, REGULATORSETTING0,	\
+	MC13892_DEFINE_REGU(VGEN2, REGULATORMODE0, REGULATORSETTING0,
 		mc13892_vgen2),
-	MC13892_DEFINE_REGU(VGEN3, REGULATORMODE1, REGULATORSETTING0,	\
+	MC13892_DEFINE_REGU(VGEN3, REGULATORMODE1, REGULATORSETTING0,
 		mc13892_vgen3),
 	MC13892_FIXED_DEFINE(VUSB, USB1, mc13892_vusb),
 	MC13892_GPO_DEFINE(GPO1, POWERMISC, mc13892_gpo),
@@ -476,8 +476,8 @@ static int mc13892_sw_regulator_set_voltage_sel(struct regulator_dev *rdev,
 	}
 
 	mc13xxx_lock(priv->mc13xxx);
-	ret = mc13xxx_reg_rmw(priv->mc13xxx, mc13892_regulators[id].vsel_reg, mask,
-			      reg_value);
+	ret = mc13xxx_reg_rmw(priv->mc13xxx, mc13892_regulators[id].vsel_reg,
+			      mask, reg_value);
 	mc13xxx_unlock(priv->mc13xxx);
 
 	return ret;
-- 
1.7.10.4



^ permalink raw reply related	[flat|nested] 22+ messages in thread

* Re: [PATCH 07/11] regulator: mc13892: Fix checkpatch issue
  2013-10-14  8:51 ` [PATCH 07/11] regulator: mc13892: " Jingoo Han
@ 2013-10-15 12:26   ` Mark Brown
  0 siblings, 0 replies; 22+ messages in thread
From: Mark Brown @ 2013-10-15 12:26 UTC (permalink / raw)
  To: Jingoo Han; +Cc: 'Liam Girdwood', linux-kernel, 'Sascha Hauer'

[-- Attachment #1: Type: text/plain, Size: 119 bytes --]

On Mon, Oct 14, 2013 at 05:51:19PM +0900, Jingoo Han wrote:
> Fix the following checkpatch warnings.

Applied, thanks.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 22+ messages in thread

* [PATCH 08/11] regulator: tps6105x: Fix checkpatch issue
  2013-10-14  8:44 [PATCH 01/11] regulator: core: Fix checkpatch issue Jingoo Han
                   ` (5 preceding siblings ...)
  2013-10-14  8:51 ` [PATCH 07/11] regulator: mc13892: " Jingoo Han
@ 2013-10-14  8:51 ` Jingoo Han
  2013-10-14  9:47   ` Linus Walleij
  2013-10-14  8:52 ` [PATCH 09/11] regulator: tps65023: " Jingoo Han
                   ` (2 subsequent siblings)
  9 siblings, 1 reply; 22+ messages in thread
From: Jingoo Han @ 2013-10-14  8:51 UTC (permalink / raw)
  To: 'Mark Brown'
  Cc: 'Liam Girdwood', linux-kernel, 'Jingoo Han',
	'Linus Walleij'

Fix the following checkpatch warning.

  WARNING: unnecessary whitespace before a quoted newline

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
 drivers/regulator/tps6105x-regulator.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/regulator/tps6105x-regulator.c b/drivers/regulator/tps6105x-regulator.c
index e0e818d..c1e33a3 100644
--- a/drivers/regulator/tps6105x-regulator.c
+++ b/drivers/regulator/tps6105x-regulator.c
@@ -137,7 +137,7 @@ static int tps6105x_regulator_probe(struct platform_device *pdev)
 	/* This instance is not set for regulator mode so bail out */
 	if (pdata->mode != TPS6105X_MODE_VOLTAGE) {
 		dev_info(&pdev->dev,
-			 "chip not in voltage mode mode, exit probe \n");
+			"chip not in voltage mode mode, exit probe\n");
 		return 0;
 	}
 
-- 
1.7.10.4



^ permalink raw reply related	[flat|nested] 22+ messages in thread

* Re: [PATCH 08/11] regulator: tps6105x: Fix checkpatch issue
  2013-10-14  8:51 ` [PATCH 08/11] regulator: tps6105x: " Jingoo Han
@ 2013-10-14  9:47   ` Linus Walleij
  0 siblings, 0 replies; 22+ messages in thread
From: Linus Walleij @ 2013-10-14  9:47 UTC (permalink / raw)
  To: Jingoo Han; +Cc: Mark Brown, Liam Girdwood, linux-kernel@vger.kernel.org

On Mon, Oct 14, 2013 at 10:51 AM, Jingoo Han <jg1.han@samsung.com> wrote:

> Fix the following checkpatch warning.
>
>   WARNING: unnecessary whitespace before a quoted newline
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>

Acked-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 22+ messages in thread

* [PATCH 09/11] regulator: tps65023: Fix checkpatch issue
  2013-10-14  8:44 [PATCH 01/11] regulator: core: Fix checkpatch issue Jingoo Han
                   ` (6 preceding siblings ...)
  2013-10-14  8:51 ` [PATCH 08/11] regulator: tps6105x: " Jingoo Han
@ 2013-10-14  8:52 ` Jingoo Han
  2013-10-15 12:36   ` Mark Brown
  2013-10-14  8:53 ` [PATCH 10/11] regulator: tps65910: " Jingoo Han
  2013-10-14  8:55 ` [PATCH 11/11] regulator: twl: " Jingoo Han
  9 siblings, 1 reply; 22+ messages in thread
From: Jingoo Han @ 2013-10-14  8:52 UTC (permalink / raw)
  To: 'Mark Brown'
  Cc: 'Liam Girdwood', linux-kernel, 'Jingoo Han'

Fix the following checkpatch warning.

  WARNING: line over 80 characters

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
 drivers/regulator/tps65023-regulator.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/regulator/tps65023-regulator.c b/drivers/regulator/tps65023-regulator.c
index a957579..3ef67a8 100644
--- a/drivers/regulator/tps65023-regulator.c
+++ b/drivers/regulator/tps65023-regulator.c
@@ -293,7 +293,8 @@ static int tps_65023_probe(struct i2c_client *client,
 
 	/* Enable setting output voltage by I2C */
 	regmap_update_bits(tps->regmap, TPS65023_REG_CON_CTRL2,
-			TPS65023_REG_CTRL2_CORE_ADJ, TPS65023_REG_CTRL2_CORE_ADJ);
+					TPS65023_REG_CTRL2_CORE_ADJ,
+					TPS65023_REG_CTRL2_CORE_ADJ);
 
 	return 0;
 }
-- 
1.7.10.4



^ permalink raw reply related	[flat|nested] 22+ messages in thread

* Re: [PATCH 09/11] regulator: tps65023: Fix checkpatch issue
  2013-10-14  8:52 ` [PATCH 09/11] regulator: tps65023: " Jingoo Han
@ 2013-10-15 12:36   ` Mark Brown
  0 siblings, 0 replies; 22+ messages in thread
From: Mark Brown @ 2013-10-15 12:36 UTC (permalink / raw)
  To: Jingoo Han; +Cc: 'Liam Girdwood', linux-kernel

[-- Attachment #1: Type: text/plain, Size: 118 bytes --]

On Mon, Oct 14, 2013 at 05:52:45PM +0900, Jingoo Han wrote:
> Fix the following checkpatch warning.

Applied, thanks.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 22+ messages in thread

* [PATCH 10/11] regulator: tps65910: Fix checkpatch issue
  2013-10-14  8:44 [PATCH 01/11] regulator: core: Fix checkpatch issue Jingoo Han
                   ` (7 preceding siblings ...)
  2013-10-14  8:52 ` [PATCH 09/11] regulator: tps65023: " Jingoo Han
@ 2013-10-14  8:53 ` Jingoo Han
  2013-10-15 12:38   ` Mark Brown
  2013-10-14  8:55 ` [PATCH 11/11] regulator: twl: " Jingoo Han
  9 siblings, 1 reply; 22+ messages in thread
From: Jingoo Han @ 2013-10-14  8:53 UTC (permalink / raw)
  To: 'Mark Brown'
  Cc: 'Liam Girdwood', linux-kernel, 'Jingoo Han',
	'Laxman Dewangan'

Fix the following checkpatch errors and warning.

  ERROR: spaces required around that '=' (ctx:VxV)
  ERROR: space required before the open parenthesis '('
  WARNING: line over 80 characters

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
 drivers/regulator/tps65910-regulator.c |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/regulator/tps65910-regulator.c b/drivers/regulator/tps65910-regulator.c
index ccde074..23f8d1c 100644
--- a/drivers/regulator/tps65910-regulator.c
+++ b/drivers/regulator/tps65910-regulator.c
@@ -481,7 +481,7 @@ static int tps65910_get_voltage_dcdc_sel(struct regulator_dev *dev)
 
 	/* multiplier 0 == 1 but 2,3 normal */
 	if (!mult)
-		mult=1;
+		mult = 1;
 
 	if (sr) {
 		/* normalise to valid range */
@@ -685,7 +685,7 @@ static int tps65910_list_voltage_dcdc(struct regulator_dev *dev,
 	case TPS65910_REG_VDD2:
 		mult = (selector / VDD1_2_NUM_VOLT_FINE) + 1;
 		volt = VDD1_2_MIN_VOLT +
-				(selector % VDD1_2_NUM_VOLT_FINE) * VDD1_2_OFFSET;
+			(selector % VDD1_2_NUM_VOLT_FINE) * VDD1_2_OFFSET;
 		break;
 	case TPS65911_REG_VDDCTRL:
 		volt = VDDCTRL_MIN_VOLT + (selector * VDDCTRL_OFFSET);
@@ -703,7 +703,7 @@ static int tps65911_list_voltage(struct regulator_dev *dev, unsigned selector)
 	struct tps65910_reg *pmic = rdev_get_drvdata(dev);
 	int step_mv = 0, id = rdev_get_id(dev);
 
-	switch(id) {
+	switch (id) {
 	case TPS65911_REG_LDO1:
 	case TPS65911_REG_LDO2:
 	case TPS65911_REG_LDO4:
@@ -1074,7 +1074,7 @@ static int tps65910_probe(struct platform_device *pdev)
 	tps65910_reg_set_bits(pmic->mfd, TPS65910_DEVCTRL,
 				DEVCTRL_SR_CTL_I2C_SEL_MASK);
 
-	switch(tps65910_chip_id(tps65910)) {
+	switch (tps65910_chip_id(tps65910)) {
 	case TPS65910:
 		pmic->get_ctrl_reg = &tps65910_get_ctrl_register;
 		pmic->num_regulators = ARRAY_SIZE(tps65910_regs);
-- 
1.7.10.4



^ permalink raw reply related	[flat|nested] 22+ messages in thread

* Re: [PATCH 10/11] regulator: tps65910: Fix checkpatch issue
  2013-10-14  8:53 ` [PATCH 10/11] regulator: tps65910: " Jingoo Han
@ 2013-10-15 12:38   ` Mark Brown
  0 siblings, 0 replies; 22+ messages in thread
From: Mark Brown @ 2013-10-15 12:38 UTC (permalink / raw)
  To: Jingoo Han
  Cc: 'Liam Girdwood', linux-kernel, 'Laxman Dewangan'

[-- Attachment #1: Type: text/plain, Size: 129 bytes --]

On Mon, Oct 14, 2013 at 05:53:40PM +0900, Jingoo Han wrote:
> Fix the following checkpatch errors and warning.

Applied, thanks.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 22+ messages in thread

* [PATCH 11/11] regulator: twl: Fix checkpatch issue
  2013-10-14  8:44 [PATCH 01/11] regulator: core: Fix checkpatch issue Jingoo Han
                   ` (8 preceding siblings ...)
  2013-10-14  8:53 ` [PATCH 10/11] regulator: tps65910: " Jingoo Han
@ 2013-10-14  8:55 ` Jingoo Han
  2013-10-14 18:32   ` Nishanth Menon
  9 siblings, 1 reply; 22+ messages in thread
From: Jingoo Han @ 2013-10-14  8:55 UTC (permalink / raw)
  To: 'Mark Brown'
  Cc: 'Liam Girdwood', linux-kernel, 'Jingoo Han',
	'Balaji T K', 'Nishanth Menon'

Fix the following checkpatch warnings.

  WARNING: please, no space before tabs
  WARNING: space prohibited between function name and open parenthesis '('

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
 drivers/regulator/twl-regulator.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/regulator/twl-regulator.c b/drivers/regulator/twl-regulator.c
index 8ebd785..fed28ab 100644
--- a/drivers/regulator/twl-regulator.c
+++ b/drivers/regulator/twl-regulator.c
@@ -58,7 +58,7 @@ struct twlreg_info {
 	struct regulator_desc	desc;
 
 	/* chip specific features */
-	unsigned long 		features;
+	unsigned long		features;
 
 	/*
 	 * optional override functions for voltage set/get
@@ -1128,7 +1128,7 @@ static int twlreg_probe(struct platform_device *pdev)
 	if (!initdata)
 		return -EINVAL;
 
-	info = kmemdup(template, sizeof (*info), GFP_KERNEL);
+	info = kmemdup(template, sizeof(*info), GFP_KERNEL);
 	if (!info)
 		return -ENOMEM;
 
-- 
1.7.10.4



^ permalink raw reply related	[flat|nested] 22+ messages in thread

* Re: [PATCH 11/11] regulator: twl: Fix checkpatch issue
  2013-10-14  8:55 ` [PATCH 11/11] regulator: twl: " Jingoo Han
@ 2013-10-14 18:32   ` Nishanth Menon
  0 siblings, 0 replies; 22+ messages in thread
From: Nishanth Menon @ 2013-10-14 18:32 UTC (permalink / raw)
  To: Jingoo Han, 'Mark Brown'
  Cc: 'Liam Girdwood', linux-kernel, 'Balaji T K'

On 10/14/2013 03:55 AM, Jingoo Han wrote:
> Fix the following checkpatch warnings.
> 
>   WARNING: please, no space before tabs
>   WARNING: space prohibited between function name and open parenthesis '('
> 
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
>  drivers/regulator/twl-regulator.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/regulator/twl-regulator.c b/drivers/regulator/twl-regulator.c
> index 8ebd785..fed28ab 100644
> --- a/drivers/regulator/twl-regulator.c
> +++ b/drivers/regulator/twl-regulator.c
> @@ -58,7 +58,7 @@ struct twlreg_info {
>  	struct regulator_desc	desc;
>  
>  	/* chip specific features */
> -	unsigned long 		features;
> +	unsigned long		features;
>  
>  	/*
>  	 * optional override functions for voltage set/get
> @@ -1128,7 +1128,7 @@ static int twlreg_probe(struct platform_device *pdev)
>  	if (!initdata)
>  		return -EINVAL;
>  
> -	info = kmemdup(template, sizeof (*info), GFP_KERNEL);
> +	info = kmemdup(template, sizeof(*info), GFP_KERNEL);
>  	if (!info)
>  		return -ENOMEM;
>  
> 

Acked-by: Nishanth Menon <nm@ti.com>
-- 
Regards,
Nishanth Menon

^ permalink raw reply	[flat|nested] 22+ messages in thread

end of thread, other threads:[~2013-10-15 12:38 UTC | newest]

Thread overview: 22+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-14  8:44 [PATCH 01/11] regulator: core: Fix checkpatch issue Jingoo Han
2013-10-14  8:45 ` [PATCH 02/11] regulator: anatop: " Jingoo Han
2013-10-14  8:55   ` Shawn Guo
2013-10-15 12:21   ` Mark Brown
2013-10-14  8:46 ` [PATCH 03/11] regulator: fixed: " Jingoo Han
2013-10-15 12:22   ` Mark Brown
2013-10-14  8:47 ` [PATCH 04/11] regulator: lp3971: " Jingoo Han
2013-10-15 12:23   ` Mark Brown
2013-10-14  8:49 ` [PATCH 05/11] regulator: max8997: " Jingoo Han
2013-10-15 12:24   ` Mark Brown
2013-10-14  8:49 ` [PATCH 06/11] regulator: mc13783: " Jingoo Han
2013-10-15 12:25   ` Mark Brown
2013-10-14  8:51 ` [PATCH 07/11] regulator: mc13892: " Jingoo Han
2013-10-15 12:26   ` Mark Brown
2013-10-14  8:51 ` [PATCH 08/11] regulator: tps6105x: " Jingoo Han
2013-10-14  9:47   ` Linus Walleij
2013-10-14  8:52 ` [PATCH 09/11] regulator: tps65023: " Jingoo Han
2013-10-15 12:36   ` Mark Brown
2013-10-14  8:53 ` [PATCH 10/11] regulator: tps65910: " Jingoo Han
2013-10-15 12:38   ` Mark Brown
2013-10-14  8:55 ` [PATCH 11/11] regulator: twl: " Jingoo Han
2013-10-14 18:32   ` Nishanth Menon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).