Re: [PATCH RFC 5/5] net: macb: Adjust tx_clk when link speed changes

Sören Brinkmann
2013-10-15T15:34:43Z

On Tue, Oct 15, 2013 at 09:58:09AM +0200, Michal Simek wrote:
> On 10/15/2013 09:54 AM, Nicolas Ferre wrote:
> > On 15/10/2013 01:59, Soren Brinkmann :
> >> Adjust the ethernet clock according to the negotiated link speed.
> >>
> >> Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com>
> >
> > I will need more time to study this one.
> >
> > Moreover, I will have to add the "tx_clk" to every user of this driver before switchin to the addition of this clock.
>
> As I am reading this patch, Soren just protected this
> case that if this clk is not specified then it is not used.
That is how I sketched things in this patch. But as I said, I'm not
fully convinced this approach fits all or is the best. So, if anybody
has a better approach, let us know.

Sören