Re: [PATCH RFC 4/5] net: macb: Use devm_request_irq()

Sergei Shtylyov
2013-10-15T20:39:14Z

On 10/16/2013 12:20 AM, Sören Brinkmann wrote:

>>> Use the device managed interface to request the IRQ, simplifying error
>>> paths.

>>> Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com>
>>> ---
>>> drivers/net/ethernet/cadence/macb.c | 8 +++-----
>>> 1 file changed, 3 insertions(+), 5 deletions(-)

>>> diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c
>>> index 436aecc31732..603844b1d483 100644
>>> --- a/drivers/net/ethernet/cadence/macb.c
>>> +++ b/drivers/net/ethernet/cadence/macb.c
>>> @@ -1825,7 +1825,8 @@ static int __init macb_probe(struct platform_device *pdev)
>>> }
>>>
>>> dev->irq = platform_get_irq(pdev, 0);
>>> - err = request_irq(dev->irq, macb_interrupt, 0, dev->name, dev);
>>> + err = devm_request_irq(&pdev->dev, dev->irq, macb_interrupt, 0,
>>> + dev->name, dev);

>> You should start the continuation line right under &.

> Actually this one is a good example why I don't do such alignment: You
> do a simple search & replace - in this case request_irq ->
> devm_request_irq - and all alignment is gone.

I didn't understand why this is a good example. In this case you broke the
line yourself and did it incorrectly, not following the networking coding
style which assumes Emacs-style alignment for broken lines.

> Sören

WBR, Sergei