Re: [PATCH RFC 4/5] net: macb: Use devm_request_irq()

Sören Brinkmann
2013-10-15T20:20:36Z

On Tue, Oct 15, 2013 at 11:21:08PM +0400, Sergei Shtylyov wrote:
> Hello.
>
> On 10/15/2013 03:58 AM, Soren Brinkmann wrote:
>
> >Use the device managed interface to request the IRQ, simplifying error
> >paths.
>
> >Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com>
> >---
> > drivers/net/ethernet/cadence/macb.c | 8 +++-----
> > 1 file changed, 3 insertions(+), 5 deletions(-)
>
> >diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c
> >index 436aecc31732..603844b1d483 100644
> >--- a/drivers/net/ethernet/cadence/macb.c
> >+++ b/drivers/net/ethernet/cadence/macb.c
> >@@ -1825,7 +1825,8 @@ static int __init macb_probe(struct platform_device *pdev)
> > }
> >
> > dev->irq = platform_get_irq(pdev, 0);
> >- err = request_irq(dev->irq, macb_interrupt, 0, dev->name, dev);
> >+ err = devm_request_irq(&pdev->dev, dev->irq, macb_interrupt, 0,
> >+ dev->name, dev);
>
> You should start the continuation line right under &.
Actually this one is a good example why I don't do such alignment: You
do a simple search & replace - in this case request_irq ->
devm_request_irq - and all alignment is gone.

Sören