From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754507Ab3JOJTX (ORCPT ); Tue, 15 Oct 2013 05:19:23 -0400 Received: from eusmtp01.atmel.com ([212.144.249.242]:16156 "EHLO eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751219Ab3JOJTV (ORCPT ); Tue, 15 Oct 2013 05:19:21 -0400 Message-ID: <525D0896.6020907@atmel.com> Date: Tue, 15 Oct 2013 11:19:18 +0200 From: Nicolas Ferre Organization: atmel User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.0 MIME-Version: 1.0 To: Jean-Christophe PLAGNIOL-VILLARD , "Greg Kroah-Hartman" CC: Josh Wu , Bo Shen , , , Ludovic Desroches , Subject: Re: [PATCH 2/2] tty/serial: at91: add a fallback option to determine uart/usart property References: <64f8f1db6f888456be8ee410a7e9bb9851d070a5.1381394411.git.nicolas.ferre@atmel.com> <20131014135921.GG11420@ns203013.ovh.net> In-Reply-To: <20131014135921.GG11420@ns203013.ovh.net> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.161.30.18] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14/10/2013 15:59, Jean-Christophe PLAGNIOL-VILLARD : > On 10:43 Thu 10 Oct , Nicolas Ferre wrote: >> On older SoC, the "name" field is not filled in the register map. >> Fix the way to figure out if the serial port is an uart or an usart for these >> older products (with corresponding properties). >> >> Signed-off-by: Nicolas Ferre >> --- >> drivers/tty/serial/atmel_serial.c | 19 ++++++++++++++++++- >> include/linux/atmel_serial.h | 1 + >> 2 files changed, 19 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/tty/serial/atmel_serial.c b/drivers/tty/serial/atmel_serial.c >> index 6b0f75e..c7d99af 100644 >> --- a/drivers/tty/serial/atmel_serial.c >> +++ b/drivers/tty/serial/atmel_serial.c >> @@ -99,6 +99,7 @@ static void atmel_stop_rx(struct uart_port *port); >> #define UART_PUT_RTOR(port,v) __raw_writel(v, (port)->membase + ATMEL_US_RTOR) >> #define UART_PUT_TTGR(port, v) __raw_writel(v, (port)->membase + ATMEL_US_TTGR) >> #define UART_GET_IP_NAME(port) __raw_readl((port)->membase + ATMEL_US_NAME) >> +#define UART_GET_IP_VERSION(port) __raw_readl((port)->membase + ATMEL_US_VERSION) >> >> /* PDC registers */ >> #define UART_PUT_PTCR(port,v) __raw_writel(v, (port)->membase + ATMEL_PDC_PTCR) >> @@ -1503,6 +1504,7 @@ static void atmel_get_ip_name(struct uart_port *port) >> { >> struct atmel_uart_port *atmel_port = to_atmel_uart_port(port); >> int name = UART_GET_IP_NAME(port); >> + u32 version; >> int usart, uart; >> /* usart and uart ascii */ >> usart = 0x55534152; >> @@ -1517,7 +1519,22 @@ static void atmel_get_ip_name(struct uart_port *port) >> dev_dbg(port->dev, "This is uart\n"); >> atmel_port->is_usart = false; >> } else { >> - dev_err(port->dev, "Not supported ip name, set to uart\n"); >> + /* fallback for older SoCs: use version field */ >> + version = UART_GET_IP_VERSION(port); >> + switch (version) { >> + case 0x302: >> + case 0x10213: >> + dev_dbg(port->dev, "This version is usart\n"); >> + atmel_port->is_usart = true; >> + break; >> + case 0x203: >> + case 0x10202: >> + dev_dbg(port->dev, "This version is uart\n"); >> + atmel_port->is_usart = false; >> + break; >> + default: >> + dev_err(port->dev, "Not supported ip name nor version, set to uart\n"); > > it's not really an error a dev_warn is more oppropriate As we are already in -rc5 and that these fixes are critical for at91 platforms, I will not re-spin another patch just for this. Moreover, I have the feeling that if we end up in this case, it means that we are in big troubles because the usart/uart included in the product triggering this log is not known (I recall that newer products do not have to hit these lines of code). With these 2 reasons, I prefer to keep my patch like it is. Greg, can you consider taking these two patches as regression fixes for 3.12 (with Tested-by tag from Thomas)? Thanks, bye, >> + } >> } >> } >> >> diff --git a/include/linux/atmel_serial.h b/include/linux/atmel_serial.h >> index be201ca..00beddf 100644 >> --- a/include/linux/atmel_serial.h >> +++ b/include/linux/atmel_serial.h >> @@ -125,5 +125,6 @@ >> #define ATMEL_US_IF 0x4c /* IrDA Filter Register */ >> >> #define ATMEL_US_NAME 0xf0 /* Ip Name */ >> +#define ATMEL_US_VERSION 0xfc /* Ip Version */ >> >> #endif >> -- >> 1.8.2.2 >> > > -- Nicolas Ferre