From: Stephen Warren <swarren@wwwdotorg.org>
To: Peter De Schrijver <pdeschrijver@nvidia.com>
Cc: Prashant Gaikwad <pgaikwad@nvidia.com>,
Mike Turquette <mturquette@linaro.org>,
Thierry Reding <thierry.reding@gmail.com>,
Rob Herring <rob.herring@calxeda.com>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Hiroshi Doyu <hdoyu@nvidia.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-tegra@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v3 11/19] clk: tegra: move periph clocks to common file
Date: Tue, 15 Oct 2013 13:19:44 -0600 [thread overview]
Message-ID: <525D9550.2030701@wwwdotorg.org> (raw)
In-Reply-To: <1381848794-11761-12-git-send-email-pdeschrijver@nvidia.com>
On 10/15/2013 08:52 AM, Peter De Schrijver wrote:
> Introduce a new file for peripheral clocks common between several Tegra
> SoCs and move Tegra114 to this new infrastructure. Also PLLP and the PLLP_OUT
> clocks will be initialized here.
> diff --git a/drivers/clk/tegra/clk-tegra114.c b/drivers/clk/tegra/clk-tegra114.c
> @@ -966,22 +699,22 @@ static struct tegra_clk tegra114_clks[tegra_clk_max] __initdata = {
> [tegra_clk_pwm] = { .dt_id = TEGRA114_CLK_PWM, .present = true },
> [tegra_clk_i2s0] = { .dt_id = TEGRA114_CLK_I2S0, .present = true },
> [tegra_clk_i2s2] = { .dt_id = TEGRA114_CLK_I2S2, .present = true },
> - [tegra_clk_epp] = { .dt_id = TEGRA114_CLK_EPP, .present = true },
> - [tegra_clk_gr2d] = { .dt_id = TEGRA114_CLK_GR2D, .present = true },
> + [tegra_clk_epp_8] = { .dt_id = TEGRA114_CLK_EPP, .present = true },
> + [tegra_clk_gr2d_8] = { .dt_id = TEGRA114_CLK_GR2D, .present = true },
> [tegra_clk_usbd] = { .dt_id = TEGRA114_CLK_USBD, .present = true },
> [tegra_clk_isp] = { .dt_id = TEGRA114_CLK_ISP, .present = true },
> - [tegra_clk_gr3d] = { .dt_id = TEGRA114_CLK_GR3D, .present = true },
> + [tegra_clk_gr3d_8] = { .dt_id = TEGRA114_CLK_GR3D, .present = true },
...
Why the need to edit this table in this patch? Why not just get it right
in the previous patch, where it's first added?
> @@ -2166,9 +1606,10 @@ static void __init tegra114_clock_init(struct device_node *np)
>
> tegra114_fixed_clk_init(clk_base);
> tegra114_pll_init(clk_base, pmc_base);
> - tegra114_periph_clk_init(clk_base);
> + tegra114_periph_clk_init(clk_base, pmc_base);
> tegra_audio_clk_init(clk_base, pmc_base, tegra114_clks, &pll_a_params);
> tegra114_pmc_clk_init(pmc_base);
> +
> tegra114_super_clk_init(clk_base);
That seems like an unrelated whitespace change. There's one in the
previous patch too:
> @@ -502,7 +492,6 @@ static struct tegra_clk_pll_freq_table pll_a_freq_table[] = {
> {0, 0, 0, 0, 0, 0},
> };
>
> -
> static struct tegra_clk_pll_params pll_a_params = {
> .input_min = 2000000,
> .input_max = 31000000,
next prev parent reply other threads:[~2013-10-15 19:19 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-15 14:52 [PATCH v3 00/19] Introduce common infra for tegra clocks Peter De Schrijver
2013-10-15 14:52 ` [PATCH v3 01/19] ARM: tegra30: add missing CLK IDs Peter De Schrijver
2013-10-15 14:52 ` [PATCH v3 02/19] clk: tegra: simplify periph clock data Peter De Schrijver
2013-10-15 18:46 ` Stephen Warren
2013-10-16 15:06 ` Peter De Schrijver
2013-10-16 17:06 ` Stephen Warren
2013-10-15 14:52 ` [PATCH v3 03/19] clk: tegra: common periph_clk_enb_refcnt and clks Peter De Schrijver
2013-10-15 18:52 ` Stephen Warren
2013-10-15 14:52 ` [PATCH v3 04/19] clk: tegra: Add TEGRA_PERIPH_NO_DIV flag Peter De Schrijver
2013-10-15 14:52 ` [PATCH v3 05/19] clk: tegra: move some PLLC and PLLXC init to clk-pll.c Peter De Schrijver
2013-10-15 18:59 ` Stephen Warren
2013-10-15 14:52 ` [PATCH v3 06/19] clk: tegra: move fields to tegra_clk_pll_params Peter De Schrijver
2013-10-15 14:52 ` [PATCH v3 07/19] clk: tegra: add header for common tegra clock IDs Peter De Schrijver
2013-10-15 14:52 ` [PATCH v3 08/19] clk: tegra: add common infra for DT clocks Peter De Schrijver
2013-10-15 19:01 ` Stephen Warren
2013-10-16 14:34 ` Peter De Schrijver
2013-10-16 17:02 ` Stephen Warren
2013-10-15 14:52 ` [PATCH v3 09/19] clk: tegra: add clkdev registration infra Peter De Schrijver
2013-10-15 19:08 ` Stephen Warren
2013-10-15 14:52 ` [PATCH v3 10/19] clk: tegra: move audio clk to common file Peter De Schrijver
2013-10-15 19:13 ` Stephen Warren
2013-10-16 7:35 ` Peter De Schrijver
2013-10-15 14:52 ` [PATCH v3 11/19] clk: tegra: move periph clocks " Peter De Schrijver
2013-10-15 19:19 ` Stephen Warren [this message]
2013-10-15 14:52 ` [PATCH v3 12/19] clk: tegra: move PMC, fixed clocks to common files Peter De Schrijver
2013-10-15 14:52 ` [PATCH v3 13/19] clk: tegra: introduce common gen4 super clock Peter De Schrijver
2013-10-15 19:37 ` Stephen Warren
2013-10-16 7:38 ` Peter De Schrijver
2013-10-15 14:52 ` [PATCH v3 14/19] clk: tegra30: replace enum by binding header Peter De Schrijver
2013-10-15 19:41 ` Stephen Warren
2013-10-16 14:46 ` Peter De Schrijver
2013-10-16 17:02 ` Stephen Warren
2013-10-15 14:53 ` [PATCH v3 15/19] clk: tegra20: " Peter De Schrijver
2013-10-15 14:53 ` [PATCH v3 16/19] clk: tegra20: move tegra20 to common clkdev Peter De Schrijver
2013-10-15 14:53 ` [PATCH v3 17/19] clk: tegra30: move tegra30 " Peter De Schrijver
2013-10-15 14:53 ` [PATCH v3 18/19] clk: tegra20: move to common periph clk Peter De Schrijver
2013-10-15 14:53 ` [PATCH v3 19/19] clk: tegra30: move to common tegra clk infra Peter De Schrijver
2013-10-15 19:43 ` Stephen Warren
2013-10-15 17:48 ` [PATCH v3 00/19] Introduce common infra for tegra clocks Stephen Warren
2013-10-16 9:06 ` Peter De Schrijver
2013-10-16 17:14 ` Stephen Warren
2013-10-17 7:52 ` Peter De Schrijver
2013-10-15 19:43 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=525D9550.2030701@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=devicetree@vger.kernel.org \
--cc=hdoyu@nvidia.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mturquette@linaro.org \
--cc=pawel.moll@arm.com \
--cc=pdeschrijver@nvidia.com \
--cc=pgaikwad@nvidia.com \
--cc=rob.herring@calxeda.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox