From: "Wendy Ng" <wendy.ng@broadcom.com>
To: "Eduardo Valentin" <eduardo.valentin@ti.com>
Cc: "Rob Herring" <rob.herring@calxeda.com>,
"Stephen Warren" <swarren@wwwdotorg.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org, "Christian Daudt" <bcm@fixthebug.org>,
"Markus Mayer" <mmayer@broadcom.com>
Subject: Re: [PATCH v2 3/3] ARM: bcm281xx: Add thermal driver to device tree.
Date: Tue, 15 Oct 2013 14:10:07 -0700 [thread overview]
Message-ID: <525DAF2F.7080009@broadcom.com> (raw)
In-Reply-To: <525B1C77.1070809@ti.com>
On 10/13/2013 3:19 PM, Eduardo Valentin wrote:
> On 27-09-2013 18:37, Wendy Ng wrote:
>> This patch adds the device tree node for Broadcom bcm281xx SoCs thermal
>> driver.
>>
>> Signed-off-by: Wendy Ng <wendy.ng@broadcom.com>
>> Reviewed-by: Markus Mayer <mmayer@broadcom.com>
>> Reviewed-by: Christian Daudt <csd@broadcom.com>
>> ---
>> arch/arm/boot/dts/bcm11351-brt.dts | 4 +++-
>> arch/arm/boot/dts/bcm11351.dtsi | 6 ++++++
>> arch/arm/boot/dts/bcm28155-ap.dts | 4 ++++
>> 3 files changed, 13 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/bcm11351-brt.dts b/arch/arm/boot/dts/bcm11351-brt.dts
>> index 9d36eb4..0771b6b 100644
>> --- a/arch/arm/boot/dts/bcm11351-brt.dts
>> +++ b/arch/arm/boot/dts/bcm11351-brt.dts
>> @@ -43,5 +43,7 @@
>> status = "okay";
>> };
>>
>> -
>> + thermal@34008000 {
>> + status = "okay";
>> + };
>> };
>> diff --git a/arch/arm/boot/dts/bcm11351.dtsi b/arch/arm/boot/dts/bcm11351.dtsi
>> index 05a5aab..aa13353 100644
>> --- a/arch/arm/boot/dts/bcm11351.dtsi
>> +++ b/arch/arm/boot/dts/bcm11351.dtsi
>> @@ -96,4 +96,10 @@
>> status = "disabled";
>> };
>>
>> + thermal@34008000 {
>> + compatible = "brcm,bcm11351-thermal", "brcm,kona-thermal";
>> + reg = <0x34008000 0x0024>;
>> + thermal-name = "bcm_kona_therm";
>
> As I mentioned previously, my only concern is this thermal binding,
> which is specific to your driver (BTW, you would need to do
> bcm,thermal-name)
>
Hi Eduardo,
I have a local working copy of the thermal driver that does not use the
'thermal-name' from this DTS file. It has been re-based to your working
version of the new thermal DT binding.
>> + status = "disabled";
>> + };
>> };
>> diff --git a/arch/arm/boot/dts/bcm28155-ap.dts b/arch/arm/boot/dts/bcm28155-ap.dts
>> index 96ae67a..a39aa47 100644
>> --- a/arch/arm/boot/dts/bcm28155-ap.dts
>> +++ b/arch/arm/boot/dts/bcm28155-ap.dts
>> @@ -42,4 +42,8 @@
>> max-frequency = <48000000>;
>> status = "okay";
>> };
>> +
>> + thermal@34008000 {
>> + status = "okay";
>> + };
>> };
>>
>
>
--
Best regards,
-Wendy
prev parent reply other threads:[~2013-10-15 21:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-27 22:37 [PATCH v2 0/3] thermal: bcm281xx: Add thermal driver Wendy Ng
2013-09-27 22:37 ` [PATCH v2 1/3] " Wendy Ng
2013-10-13 23:14 ` Eduardo Valentin
2013-10-15 21:57 ` Wendy Ng
2013-09-27 22:37 ` [PATCH v2 2/3] ARM: bcm281xx: Turn on Thermal and HWMON drivers Wendy Ng
2013-10-13 22:16 ` Eduardo Valentin
2013-10-16 21:18 ` Wendy Ng
2013-09-27 22:37 ` [PATCH v2 3/3] ARM: bcm281xx: Add thermal driver to device tree Wendy Ng
2013-10-13 22:19 ` Eduardo Valentin
2013-10-15 21:10 ` Wendy Ng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=525DAF2F.7080009@broadcom.com \
--to=wendy.ng@broadcom.com \
--cc=bcm@fixthebug.org \
--cc=devicetree@vger.kernel.org \
--cc=eduardo.valentin@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mmayer@broadcom.com \
--cc=rob.herring@calxeda.com \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox