From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750943Ab3JPEBf (ORCPT ); Wed, 16 Oct 2013 00:01:35 -0400 Received: from mga02.intel.com ([134.134.136.20]:28774 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750758Ab3JPEBe (ORCPT ); Wed, 16 Oct 2013 00:01:34 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.93,504,1378882800"; d="scan'208";a="393567287" Message-ID: <525E0F27.4030502@linux.intel.com> Date: Tue, 15 Oct 2013 20:59:35 -0700 From: David Cohen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20131005 Icedove/17.0.9 MIME-Version: 1.0 To: "H. Peter Anvin" CC: mingo@redhat.com, tglx@linutronix.de, x86@kernel.org, linux-kernel@vger.kernel.org, Kuppuswamy Sathyanarayanan Subject: Re: [PATCH v4 12/12] intel_mid: Moved board related code to a new file References: <1381880568-20730-1-git-send-email-david.a.cohen@linux.intel.com> <1381880568-20730-13-git-send-email-david.a.cohen@linux.intel.com> <525DD362.4070807@zytor.com> <525DD571.20107@linux.intel.com> <525DE197.5040607@zytor.com> In-Reply-To: <525DE197.5040607@zytor.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/15/2013 05:45 PM, H. Peter Anvin wrote: > On 10/15/2013 04:53 PM, David Cohen wrote: >> On 10/15/2013 04:44 PM, H. Peter Anvin wrote: >>> On 10/15/2013 04:42 PM, David Cohen wrote: >>>> >>>> +#define intel_mid_sfi_dev(i) \ >>>> + static const struct devs_id *__intel_mid_sfi_##i##_dev __used \ >>>> + __attribute__((__section__(".x86_intel_mid_dev.init"))) = &i >>>> + >>> >>> Any reason to not just call this "sfi_device()" or something similar? >>> "Intel MID SFI" seems a bit redundant... >> >> I had the same though. But struct devs_id is defined by asm/intel-mid.h. >> This function is not meant to be used by any other user beside >> intel-mid. >> But I can change if you prefer. >> > > Hm, I guess it doesn't really matter. After all, no other devices will > probably ever see SFI (we hope). I hope too :) Let me send a new version with this change. Br, David Cohen