From: "H. Peter Anvin" <hpa@zytor.com>
To: Dave Young <dyoung@redhat.com>,
matt@console-pimps.org, x86@kernel.org,
linux-kernel@vger.kernel.org, mjg59@srcf.ucam.org,
James.Bottomley@HansenPartnership.com, vgoyal@redhat.com,
linux-efi@vger.kernel.org
Subject: Re: [PATCH] x86 efi: efi reverve boot service fix
Date: Wed, 16 Oct 2013 00:29:58 -0700 [thread overview]
Message-ID: <525E4076.2070107@zytor.com> (raw)
In-Reply-To: <20131016071122.GB18241@dhcp-16-126.nay.redhat.com>
On 10/16/2013 12:11 AM, Dave Young wrote:
>>
>> --- linux-2.6.orig/arch/x86/platform/efi/efi.c
>> +++ linux-2.6/arch/x86/platform/efi/efi.c
>> @@ -440,7 +440,7 @@ void __init efi_reserve_boot_services(vo
>> * - Not within any part of the kernel
>> * - Not the bios reserved area
>> */
>> - if ((start+size >= __pa_symbol(_text)
>> + if ((start + size - 1 >= __pa_symbol(_text)
>> && start <= __pa_symbol(_end)) ||
>> !e820_all_mapped(start, start+size, E820_RAM) ||
>> memblock_is_region_reserved(start, size)) {
It would be better to change >= to >.
-hpa
next prev parent reply other threads:[~2013-10-16 7:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-16 7:03 [PATCH] x86 efi: efi reverve boot service fix Dave Young
2013-10-16 7:11 ` Dave Young
2013-10-16 7:29 ` H. Peter Anvin [this message]
2013-10-16 8:24 ` Dave Young
2013-10-16 8:07 ` Matt Fleming
2013-10-16 8:28 ` Dave Young
2013-10-16 8:36 ` Maarten Lankhorst
2013-10-16 8:35 ` [PATCH v2] " Dave Young
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=525E4076.2070107@zytor.com \
--to=hpa@zytor.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=dyoung@redhat.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@console-pimps.org \
--cc=mjg59@srcf.ucam.org \
--cc=vgoyal@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox