From: David Cohen <david.a.cohen@linux.intel.com>
To: ohad@wizery.com
Cc: linux-kernel@vger.kernel.org,
Jocelyn Falempe <jocelyn.falempe@intel.com>
Subject: Re: [PATCH] rpmsg: reduce rpmsg_virtio verbosity
Date: Wed, 16 Oct 2013 09:15:38 -0700 [thread overview]
Message-ID: <525EBBAA.9000209@linux.intel.com> (raw)
In-Reply-To: <1380825415-20481-1-git-send-email-david.a.cohen@linux.intel.com>
On 10/03/2013 11:36 AM, David Cohen wrote:
> From: Jocelyn Falempe <jocelyn.falempe@intel.com>
>
> rpmsg_virtio TX/RX messages are very verbose, overflowing kernel printk
> buffer. This patch makes the guilty print_hex_dump()'s to act as
> dev_dbg() and do nothing in case neither DEBUG nor CONFIG_DYNAMIC_DEBUG
> are defined.
>
> Signed-off-by: Jocelyn Falempe <jocelyn.falempe@intel.com>
> Signed-off-by: David Cohen <david.a.cohen@linux.intel.com>
> ---
Ping :)
Comments here?
Br, David Cohen
> drivers/rpmsg/virtio_rpmsg_bus.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/rpmsg/virtio_rpmsg_bus.c b/drivers/rpmsg/virtio_rpmsg_bus.c
> index b6135d4..e7c5927 100644
> --- a/drivers/rpmsg/virtio_rpmsg_bus.c
> +++ b/drivers/rpmsg/virtio_rpmsg_bus.c
> @@ -749,8 +749,10 @@ int rpmsg_send_offchannel_raw(struct rpmsg_channel *rpdev, u32 src, u32 dst,
> dev_dbg(dev, "TX From 0x%x, To 0x%x, Len %d, Flags %d, Reserved %d\n",
> msg->src, msg->dst, msg->len,
> msg->flags, msg->reserved);
> - print_hex_dump(KERN_DEBUG, "rpmsg_virtio TX: ", DUMP_PREFIX_NONE, 16, 1,
> +#if defined(CONFIG_DYNAMIC_DEBUG) || defined(DEBUG)
> + print_hex_dump_debug("rpmsg_virtio TX: ", DUMP_PREFIX_NONE, 16, 1,
> msg, sizeof(*msg) + msg->len, true);
> +#endif
>
> sg_init_one(&sg, msg, sizeof(*msg) + len);
>
> @@ -786,8 +788,10 @@ static int rpmsg_recv_single(struct virtproc_info *vrp, struct device *dev,
> dev_dbg(dev, "From: 0x%x, To: 0x%x, Len: %d, Flags: %d, Reserved: %d\n",
> msg->src, msg->dst, msg->len,
> msg->flags, msg->reserved);
> - print_hex_dump(KERN_DEBUG, "rpmsg_virtio RX: ", DUMP_PREFIX_NONE, 16, 1,
> +#if defined(CONFIG_DYNAMIC_DEBUG) || defined(DEBUG)
> + print_hex_dump_debug("rpmsg_virtio RX: ", DUMP_PREFIX_NONE, 16, 1,
> msg, sizeof(*msg) + msg->len, true);
> +#endif
>
> /*
> * We currently use fixed-sized buffers, so trivially sanitize
>
next prev parent reply other threads:[~2013-10-16 16:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-03 18:36 [PATCH] rpmsg: reduce rpmsg_virtio verbosity David Cohen
2013-10-16 16:15 ` David Cohen [this message]
2013-11-12 21:48 ` David Cohen
2014-02-24 15:11 ` Ohad Ben-Cohen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=525EBBAA.9000209@linux.intel.com \
--to=david.a.cohen@linux.intel.com \
--cc=jocelyn.falempe@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ohad@wizery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox