* [PATCH] spi/s3c64xx: Add missing pm_runtime_set_active() call in probe()
@ 2013-10-17 16:06 Krzysztof Kozlowski
2013-10-17 16:10 ` Sylwester Nawrocki
2013-10-17 23:33 ` Mark Brown
0 siblings, 2 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2013-10-17 16:06 UTC (permalink / raw)
To: Ben Dooks, Kukjin Kim, Mark Brown
Cc: linux-arm-kernel, linux-samsung-soc, linux-spi, linux-kernel,
Sylwester Nawrocki, Krzysztof Kozlowski, Kyungmin Park
Mark device as PM runtime active during initialization to reflect
actual device power/clocks state. This reduces the enable count for SPI
bus controller gate clock so it can be disabled when the bus controller
is not used.
Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---
drivers/spi/spi-s3c64xx.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c
index 0ddaff2..ae07c3a 100644
--- a/drivers/spi/spi-s3c64xx.c
+++ b/drivers/spi/spi-s3c64xx.c
@@ -1429,6 +1429,7 @@ static int s3c64xx_spi_probe(struct platform_device *pdev)
S3C64XX_SPI_INT_TX_OVERRUN_EN | S3C64XX_SPI_INT_TX_UNDERRUN_EN,
sdd->regs + S3C64XX_SPI_INT_EN);
+ pm_runtime_set_active(&pdev->dev);
pm_runtime_enable(&pdev->dev);
if (spi_register_master(master)) {
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] spi/s3c64xx: Add missing pm_runtime_set_active() call in probe()
2013-10-17 16:06 [PATCH] spi/s3c64xx: Add missing pm_runtime_set_active() call in probe() Krzysztof Kozlowski
@ 2013-10-17 16:10 ` Sylwester Nawrocki
2013-10-17 23:33 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Sylwester Nawrocki @ 2013-10-17 16:10 UTC (permalink / raw)
To: Krzysztof Kozlowski, Ben Dooks, Kukjin Kim, Mark Brown
Cc: linux-arm-kernel, linux-samsung-soc, linux-spi, linux-kernel,
Kyungmin Park
On 17/10/13 18:06, Krzysztof Kozlowski wrote:
> Mark device as PM runtime active during initialization to reflect
> actual device power/clocks state. This reduces the enable count for SPI
> bus controller gate clock so it can be disabled when the bus controller
> is not used.
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] spi/s3c64xx: Add missing pm_runtime_set_active() call in probe()
2013-10-17 16:06 [PATCH] spi/s3c64xx: Add missing pm_runtime_set_active() call in probe() Krzysztof Kozlowski
2013-10-17 16:10 ` Sylwester Nawrocki
@ 2013-10-17 23:33 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2013-10-17 23:33 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Ben Dooks, Kukjin Kim, linux-arm-kernel, linux-samsung-soc,
linux-spi, linux-kernel, Sylwester Nawrocki, Kyungmin Park
[-- Attachment #1: Type: text/plain, Size: 318 bytes --]
On Thu, Oct 17, 2013 at 06:06:46PM +0200, Krzysztof Kozlowski wrote:
> Mark device as PM runtime active during initialization to reflect
> actual device power/clocks state. This reduces the enable count for SPI
> bus controller gate clock so it can be disabled when the bus controller
> is not used.
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-10-17 23:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-17 16:06 [PATCH] spi/s3c64xx: Add missing pm_runtime_set_active() call in probe() Krzysztof Kozlowski
2013-10-17 16:10 ` Sylwester Nawrocki
2013-10-17 23:33 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox