* [PATCH] scripts/kernel-doc: make unknown function prototype a Warning instead of an Error
@ 2013-10-17 23:32 Randy Dunlap
2013-10-18 0:17 ` Mark Brown
2013-11-06 21:01 ` Michal Marek
0 siblings, 2 replies; 3+ messages in thread
From: Randy Dunlap @ 2013-10-17 23:32 UTC (permalink / raw)
To: linux-doc@vger.kernel.org, Rob Landley, Michal Marek,
Andrew Morton
Cc: LKML, Mark Brown
From: Randy Dunlap <rdunlap@infradead.org>
When scripts/kernel-doc cannot understand a function prototype,
it had been generating a fatal error and stopping immediately.
Make this a Warning instead of an Error and keep going.
Note that this can happen if the kernel-doc notation that is being
parsed is not actually a function prototype; maybe it's a struct or
something else, so I added "function" to the warning message to try
to make it clearer that scripts/kernel-doc is looking for a function
prototype here.
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Mark Brown <broonie@kernel.org>
---
scripts/kernel-doc | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
--- linux-3.12-rc5.orig/scripts/kernel-doc
+++ linux-3.12-rc5/scripts/kernel-doc
@@ -2125,8 +2125,7 @@ sub dump_function($$) {
create_parameterlist($args, ',', $file);
} else {
- print STDERR "Error(${file}:$.): cannot understand prototype: '$prototype'\n";
- ++$errors;
+ print STDERR "Warning(${file}:$.): cannot understand function prototype: '$prototype'\n";
return;
}
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] scripts/kernel-doc: make unknown function prototype a Warning instead of an Error
2013-10-17 23:32 [PATCH] scripts/kernel-doc: make unknown function prototype a Warning instead of an Error Randy Dunlap
@ 2013-10-18 0:17 ` Mark Brown
2013-11-06 21:01 ` Michal Marek
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2013-10-18 0:17 UTC (permalink / raw)
To: Randy Dunlap
Cc: linux-doc@vger.kernel.org, Rob Landley, Michal Marek,
Andrew Morton, LKML
[-- Attachment #1: Type: text/plain, Size: 316 bytes --]
On Thu, Oct 17, 2013 at 04:32:01PM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> When scripts/kernel-doc cannot understand a function prototype,
> it had been generating a fatal error and stopping immediately.
> Make this a Warning instead of an Error and keep going.
Thanks!
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] scripts/kernel-doc: make unknown function prototype a Warning instead of an Error
2013-10-17 23:32 [PATCH] scripts/kernel-doc: make unknown function prototype a Warning instead of an Error Randy Dunlap
2013-10-18 0:17 ` Mark Brown
@ 2013-11-06 21:01 ` Michal Marek
1 sibling, 0 replies; 3+ messages in thread
From: Michal Marek @ 2013-11-06 21:01 UTC (permalink / raw)
To: Randy Dunlap
Cc: linux-doc@vger.kernel.org, Rob Landley, Andrew Morton, LKML,
Mark Brown
On Thu, Oct 17, 2013 at 04:32:01PM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> When scripts/kernel-doc cannot understand a function prototype,
> it had been generating a fatal error and stopping immediately.
> Make this a Warning instead of an Error and keep going.
>
> Note that this can happen if the kernel-doc notation that is being
> parsed is not actually a function prototype; maybe it's a struct or
> something else, so I added "function" to the warning message to try
> to make it clearer that scripts/kernel-doc is looking for a function
> prototype here.
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Mark Brown <broonie@kernel.org>
Applied to kbuild.git#misc, thanks.
Michal
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-11-07 5:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-17 23:32 [PATCH] scripts/kernel-doc: make unknown function prototype a Warning instead of an Error Randy Dunlap
2013-10-18 0:17 ` Mark Brown
2013-11-06 21:01 ` Michal Marek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox