From: David Cohen <david.a.cohen@linux.intel.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: x86@kernel.org, hpa@zytor.com, mingo@redhat.com,
tglx@linutronix.de, linux-kernel@vger.kernel.org,
sathyanarayanan.kuppuswamy@linux.intel.com
Subject: Re: [PATCH v10 00/12] rework arch/x86/platform/[mrst => intel-mid]
Date: Fri, 18 Oct 2013 06:39:43 -0700 [thread overview]
Message-ID: <52613A1F.5000609@linux.intel.com> (raw)
In-Reply-To: <20131018060929.GB3411@gmail.com>
Hi Ingo,
On 10/17/2013 11:09 PM, Ingo Molnar wrote:
>
> * David Cohen <david.a.cohen@linux.intel.com> wrote:
>
>> David Cohen (3):
>> intel-mid: sfi: allow struct devs_id.get_platform_data to be NULL
>> x86: intel-mid: add section for sfi device table
>> intel_mid: move board related codes to their own platform_<device>.*
>> files
>>
>> Fengguang Wu (1):
>> pci: intel_mid: return true/false in function returning bool
>>
>> Kuppuswamy Sathyanarayanan (8):
>> mrst: Fixed printk/pr_* related issues
>> mrst: Fixed indentation issues
>> intel_mid: Renamed *mrst* to *intel_mid*
>> intel_mid: Renamed *mrst* to *intel_mid*
>> intel_mid: Refactored sfi_parse_devs() function
>> intel_mid: Added custom device_handler support
>> intel_mid: Added custom handler for ipc devices
>> intel_mid: Moved SFI related code to sfi.c
>
> Btw., when submitting a series _please_ harmonize the patch titles.
>
> 1)
>
> Verbs should be present tense, i.e.:
>
> -> intel_mid: Renamed *mrst* to *intel_mid*
> -> intel_mid: Renamed *mrst* to *intel_mid*
> +> intel_mid: Rename *mrst* to *intel_mid*
> +> intel_mid: Rename *mrst* to *intel_mid*
>
> 2)
>
> Use consistent capitalization:
>
> -> pci: intel_mid: return true/false in function returning bool
> +> pci: intel_mid: Return true/false in function returning bool
>
> 3)
>
> Use standard, consistent subsystem prefixes:
>
> -> x86: intel-mid: add section for sfi device table
> -> intel_mid: Renamed *mrst* to *intel_mid*
> +> x86/intel-mid: Add section for sfi device table
> +> x86/intel/mid: Rename *mrst* to *intel_mid*
>
> etc.
Thanks for the suggestion. I'll take care of it next time.
Br, David Cohen
prev parent reply other threads:[~2013-10-18 13:41 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-17 22:35 [PATCH v10 00/12] rework arch/x86/platform/[mrst => intel-mid] David Cohen
2013-10-17 22:35 ` [PATCH v10 01/12] mrst: Fixed printk/pr_* related issues David Cohen
2013-10-18 0:33 ` [tip:x86/intel-mid] " tip-bot for Kuppuswamy Sathyanarayanan
2013-10-17 22:35 ` [PATCH v10 02/12] mrst: Fixed indentation issues David Cohen
2013-10-18 0:33 ` [tip:x86/intel-mid] " tip-bot for Kuppuswamy Sathyanarayanan
2013-10-17 22:35 ` [PATCH v10 03/12] intel_mid: Renamed *mrst* to *intel_mid* David Cohen
2013-10-18 0:33 ` [tip:x86/intel-mid] " tip-bot for Kuppuswamy Sathyanarayanan
2013-10-17 22:35 ` [PATCH v10 04/12] pci: intel_mid: return true/false in function returning bool David Cohen
2013-10-18 0:33 ` [tip:x86/intel-mid] pci: intel_mid: Return true/ false " tip-bot for Fengguang Wu
2013-10-17 22:35 ` [PATCH v10 05/12] intel_mid: Renamed *mrst* to *intel_mid* David Cohen
2013-10-18 0:34 ` [tip:x86/intel-mid] " tip-bot for Kuppuswamy Sathyanarayanan
2013-10-17 22:35 ` [PATCH v10 06/12] intel_mid: Refactored sfi_parse_devs() function David Cohen
2013-10-18 0:34 ` [tip:x86/intel-mid] " tip-bot for Kuppuswamy Sathyanarayanan
2013-10-17 22:35 ` [PATCH v10 07/12] intel_mid: Added custom device_handler support David Cohen
2013-10-18 0:34 ` [tip:x86/intel-mid] " tip-bot for Kuppuswamy Sathyanarayanan
2013-10-17 22:35 ` [PATCH v10 08/12] intel_mid: Added custom handler for ipc devices David Cohen
2013-10-18 0:34 ` [tip:x86/intel-mid] " tip-bot for Kuppuswamy Sathyanarayanan
2013-10-17 22:35 ` [PATCH v10 09/12] intel_mid: Moved SFI related code to sfi.c David Cohen
2013-10-18 0:34 ` [tip:x86/intel-mid] " tip-bot for Kuppuswamy Sathyanarayanan
2013-10-17 22:35 ` [PATCH v10 10/12] intel-mid: sfi: allow struct devs_id.get_platform_data to be NULL David Cohen
2013-10-18 0:34 ` [tip:x86/intel-mid] intel-mid: sfi: Allow " tip-bot for David Cohen
2013-10-17 22:35 ` [PATCH v10 11/12] x86: intel-mid: add section for sfi device table David Cohen
2013-10-18 0:35 ` [tip:x86/intel-mid] x86: intel-mid: Add " tip-bot for David Cohen
2013-10-17 22:35 ` [PATCH v10 12/12] intel_mid: move board related codes to their own platform_<device>.* files David Cohen
2013-10-18 0:35 ` [tip:x86/intel-mid] intel_mid: Move platform device setups " tip-bot for David Cohen
2013-10-18 6:09 ` [PATCH v10 00/12] rework arch/x86/platform/[mrst => intel-mid] Ingo Molnar
2013-10-18 13:39 ` David Cohen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52613A1F.5000609@linux.intel.com \
--to=david.a.cohen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox