From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6088E95A90 for ; Sun, 8 Oct 2023 23:21:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344963AbjJHXVX (ORCPT ); Sun, 8 Oct 2023 19:21:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60010 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344922AbjJHXVT (ORCPT ); Sun, 8 Oct 2023 19:21:19 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D8D10A6; Sun, 8 Oct 2023 16:21:18 -0700 (PDT) Received: from [192.168.0.206] (unknown [179.221.49.143]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: koike) by madras.collabora.co.uk (Postfix) with ESMTPSA id 5F5AB660708F; Mon, 9 Oct 2023 00:21:12 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1696807277; bh=n6FyZS8CpZQUQ33bu6wL3AYnS1Dftji3soEkyzZ0Od8=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=GSjmJuCEEU/d63ysqmYNF+ppD8PPHjhJmgIZCbe/H2M9L+kqYc1HsZB+5ouw1YaDF tgvM4WojDp1WpdjG+iCtOQpQphyhycBHXKhR23lmFys6vSioZxfjnAuezCLXVl3YB3 Qz9BH2x80q5aU19QDIWGVXUIGxbuIBuKel1eeS+oVmEk/qlji5E7Pf14retQP7WY2X a2LBo3FgO6cvptP3lJfZ0wID7eyIB9FcnvV2P/c3Si+KM7Cuzi4U48YrQ6AigPSM82 7dXbSSR8kAE3jw4DqAauqNJFlBKxMNKQttu8LyKAFRXvg2R4Ih2N2qE5MqTe2H4c6+ /jEgajdueChEQ== Message-ID: <526457dd-37f2-467d-b583-b710a5e84b97@collabora.com> Date: Sun, 8 Oct 2023 20:21:07 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] drm/msm/dpu: Use the encoder for default CRC source Content-Language: en-US To: Dmitry Baryshkov , Rob Clark Cc: dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, Rob Clark , David Airlie , Daniel Vetter , Abhinav Kumar , Sean Paul , Marijn Suijten , Daniel Stone , Vinod Polimera , Kalyan Thota , Jiasheng Jiang , open list References: <20231008175615.413497-1-robdclark@gmail.com> From: Helen Koike In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/10/2023 16:59, Dmitry Baryshkov wrote: > On Sun, 8 Oct 2023 at 20:56, Rob Clark wrote: >> >> From: Rob Clark >> >> i-g-t expects the CRC to reflect any applied CTM. But the layer mixer >> source is upstream of the DSPP, so it is before the CTM is applied. >> >> Switch the default source to 'encoder' instead so that the CRC is >> captured downstream of the DSPP. >> >> Signed-off-by: Rob Clark >> --- >> drivers/gpu/drm/ci/xfails/msm-sc7180-fails.txt | 4 ---- >> drivers/gpu/drm/ci/xfails/msm-sc7180-skips.txt | 5 ----- >> drivers/gpu/drm/ci/xfails/msm-sdm845-fails.txt | 11 +---------- >> drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 6 +++--- > > I'm not sure, if updating the CI skip list together with the > functional changs is a good idea, my preference would be towards two > separate patches. On the other hand, having both together in the same patch documents which tests this PATCH is fixing. Regards, Helen > > Nevertheless: > > Reviewed-by: Dmitry Baryshkov > >> 4 files changed, 4 insertions(+), 22 deletions(-) > >