From: Michael Opdenacker <michael.opdenacker@free-electrons.com>
To: divy@chelsio.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Michael Opdenacker <michael.opdenacker@free-electrons.com>
Subject: Re: [PATCH] chelsio: remove duplicate defines
Date: Mon, 21 Oct 2013 07:08:23 +0200 [thread overview]
Message-ID: <5264B6C7.9000206@free-electrons.com> (raw)
In-Reply-To: <1382331307-4962-1-git-send-email-michael.opdenacker@free-electrons.com>
On 10/21/2013 06:55 AM, Michael Opdenacker wrote:
> This removes duplicate definitions of S_BUSY, V_BUSY() and F_BUSY
> in drivers/net/ethernet/chelsio/cxgb3/regs.h
Forget this version. There are other duplicates in this file. I'll
submit a new version of this patch.
>
> Signed-off-by: Michael Opdenacker <michael.opdenacker@free-electrons.com>
> ---
> drivers/net/ethernet/chelsio/cxgb3/regs.h | 12 ------------
> 1 file changed, 12 deletions(-)
>
> diff --git a/drivers/net/ethernet/chelsio/cxgb3/regs.h b/drivers/net/ethernet/chelsio/cxgb3/regs.h
> index 6990f6c..b8367ec 100644
> --- a/drivers/net/ethernet/chelsio/cxgb3/regs.h
> +++ b/drivers/net/ethernet/chelsio/cxgb3/regs.h
> @@ -685,10 +685,6 @@
> #define V_BUSY(x) ((x) << S_BUSY)
> #define F_BUSY V_BUSY(1U)
>
> -#define S_BUSY 31
> -#define V_BUSY(x) ((x) << S_BUSY)
> -#define F_BUSY V_BUSY(1U)
> -
> #define A_MC7_EXT_MODE1 0x108
>
> #define A_MC7_EXT_MODE2 0x10c
> @@ -749,14 +745,6 @@
>
> #define A_MC7_CAL 0x128
>
> -#define S_BUSY 31
> -#define V_BUSY(x) ((x) << S_BUSY)
> -#define F_BUSY V_BUSY(1U)
> -
> -#define S_BUSY 31
> -#define V_BUSY(x) ((x) << S_BUSY)
> -#define F_BUSY V_BUSY(1U)
> -
> #define S_CAL_FAULT 30
> #define V_CAL_FAULT(x) ((x) << S_CAL_FAULT)
> #define F_CAL_FAULT V_CAL_FAULT(1U)
--
Michael Opdenacker, CEO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
+33 484 258 098
prev parent reply other threads:[~2013-10-21 5:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-21 4:55 [PATCH] chelsio: remove duplicate defines Michael Opdenacker
2013-10-21 5:08 ` Michael Opdenacker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5264B6C7.9000206@free-electrons.com \
--to=michael.opdenacker@free-electrons.com \
--cc=divy@chelsio.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox