From: Mugunthan V N <mugunthanvnm@ti.com>
To: Mariusz Ceier <mceier+kernel@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Lad Prabhakar <prabhakar.csengg@gmail.com>,
Jingoo Han <jg1.han@samsung.com>, Jiri Pirko <jiri@resnulli.us>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] davinci_emac.c: Fix IFF_ALLMULTI setup
Date: Mon, 21 Oct 2013 23:20:41 +0530 [thread overview]
Message-ID: <52656971.3020509@ti.com> (raw)
In-Reply-To: <1382377504-24688-1-git-send-email-mceier+kernel@gmail.com>
On Monday 21 October 2013 11:15 PM, Mariusz Ceier wrote:
> When IFF_ALLMULTI flag is set on interface and IFF_PROMISC isn't,
> emac_dev_mcast_set should only enable RX of multicasts and reset
> MACHASH registers.
>
> It does this, but afterwards it either sets up multicast MACs
> filtering or disables RX of multicasts and resets MACHASH registers
> again, rendering IFF_ALLMULTI flag useless.
>
> This patch fixes emac_dev_mcast_set, so that multicast MACs filtering and
> disabling of RX of multicasts are skipped when IFF_ALLMULTI flag is set.
>
> Tested with kernel 2.6.37.
>
> Signed-off-by: Mariusz Ceier <mceier+kernel@gmail.com>
> ---
Can you add [PATCH v2] in your subject in future so that it will be
easier to the maintainer to pick the latest version of the patch.
Acked-by: Mugunthan V N <mugunthanvnm@ti.com>
Regards
Mugunthan V N
next prev parent reply other threads:[~2013-10-21 17:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-21 16:59 [PATCH] davinci_emac.c: Fix IFF_ALLMULTI setup Mariusz Ceier
2013-10-21 17:27 ` Sergei Shtylyov
2013-10-21 17:45 ` Mariusz Ceier
2013-10-21 17:50 ` Mugunthan V N [this message]
2013-10-21 17:59 ` Mariusz Ceier
2013-10-21 22:57 ` David Miller
2013-10-22 2:34 ` Prabhakar Lad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52656971.3020509@ti.com \
--to=mugunthanvnm@ti.com \
--cc=davem@davemloft.net \
--cc=jg1.han@samsung.com \
--cc=jiri@resnulli.us \
--cc=linux-kernel@vger.kernel.org \
--cc=mceier+kernel@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=prabhakar.csengg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox