From: Bo Shen <voice.shen@atmel.com>
To: Thierry Reding <thierry.reding@gmail.com>,
Rob Herring <rob.herring@calxeda.com>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Stephen Warren <swarren@wwwdotorg.org>,
Ian Campbell <ijc+devicetree@hellion.org.uk>
Cc: <plagnioj@jcrosoft.com>, <nicolas.ferre@atmel.com>,
<linux-pwm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>,
<alexandre.belloni@free-electrons.com>
Subject: Re: [PATCH v5] PWM: atmel-pwm: add PWM controller driver
Date: Tue, 22 Oct 2013 18:13:10 +0800 [thread overview]
Message-ID: <52664FB6.4000004@atmel.com> (raw)
In-Reply-To: <20131008131727.GB12839@ulmo.nvidia.com>
Hi All,
On 10/8/2013 21:17, Thierry Reding wrote:
> On Mon, Sep 30, 2013 at 05:10:40PM +0800, Bo Shen wrote:
>> Add Atmel PWM controller driver based on PWM framework.
>>
>> This is the basic function implementation of Atmel PWM controller.
>> It can work with PWM based led and backlight.
>>
>> Signed-off-by: Bo Shen <voice.shen@atmel.com>
>>
>> ---
>> Changes in v5:
>> - call clk_disable directly, if so, it won't cause more than one channel
>> enabled, the clock can not be disabled.
>>
>> Changes in v4:
>> - check the return value of clk_prepare()
>> - change channel register size as constant
>>
>> Changes in v3:
>> - change compatible string from "atmel,sama5-pwm" to "atmel,sama5d3-pwm"
>> - Add PWM led example in binding documentation
>> - Using micro replace hard code
>>
>> Changes in v2:
>> - Address the comments from Thierry Reding
>>
>> .../devicetree/bindings/pwm/atmel-pwm.txt | 41 +++
>> drivers/pwm/Kconfig | 9 +
>> drivers/pwm/Makefile | 1 +
>> drivers/pwm/pwm-atmel.c | 344 ++++++++++++++++++++
>> 4 files changed, 395 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/pwm/atmel-pwm.txt
>> create mode 100644 drivers/pwm/pwm-atmel.c
>
> I haven't seen an Acked-by from the device tree bindings maintainers on
> this. I've Cc'ed them, so hopefully one of them has time to review.
Any comments?
Best Regards,
Bo Shen
next prev parent reply other threads:[~2013-10-22 10:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-30 9:10 [PATCH v5] PWM: atmel-pwm: add PWM controller driver Bo Shen
2013-09-30 15:23 ` Alexandre Belloni
2013-10-08 13:17 ` Thierry Reding
2013-10-22 10:13 ` Bo Shen [this message]
2013-10-28 14:49 ` Nicolas Ferre
2013-10-31 5:30 ` Bo Shen
2013-10-31 5:42 ` Jean-Christophe PLAGNIOL-VILLARD
[not found] <ABFEDD1A8D2AAF42A54E3C074D49DC727313EB16@penmbx01>
2013-10-31 7:40 ` Bo Shen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52664FB6.4000004@atmel.com \
--to=voice.shen@atmel.com \
--cc=alexandre.belloni@free-electrons.com \
--cc=devicetree@vger.kernel.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=nicolas.ferre@atmel.com \
--cc=pawel.moll@arm.com \
--cc=plagnioj@jcrosoft.com \
--cc=rob.herring@calxeda.com \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox