From: Levente Kurusa <levex@linux.com>
To: jiaweiwei <jiaweiwei.xiyou@gmail.com>
Cc: "Theodore Ts'o" <tytso@mit.edu>,
Vyacheslav Dubeyko <slava@dubeyko.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Harry Wei <harryxiyou@gmail.com>
Subject: Re: [RFC] Rollback FS
Date: Tue, 22 Oct 2013 16:29:02 +0200 [thread overview]
Message-ID: <52668BAE.2000301@linux.com> (raw)
In-Reply-To: <CABjrhvomv62ww9z3_LXosWVMPCrAe7jME2NhBa4AkaZP5TQN3Q@mail.gmail.com>
2013-10-20 17:22 keltezéssel, jiaweiwei írta:
> On Sun, Oct 20, 2013 at 9:26 PM, Levente Kurusa <levex@linux.com> wrote:
>> 2013-10-20 15:19 keltezéssel, jiaweiwei írta:
>>> On Sun, Oct 20, 2013 at 9:07 PM, Levente Kurusa <levex@linux.com> wrote:
>>> [...]
>>>>> A good catch. Following ideas would be suitable.
>>>>>
>>>>> 1, Keep the blocks or inodes by a parameter we give.
>>>>> 2, Keep the blocks or inodes for several seconds.
>>>> Keep them where? On the HDD? We just deleted/moved that.
>>>
>>> Delete/move a file with a parameter, which would keep the blocks or inodes
>>> in-place. Or we would keep the blocks or inodes for several seconds.
>>
>> The problem with keeping the inodes/blocks for several seconds is
>> that you would need to find a magic number that is not small enough,
>> because if it is, then what if the user doesn't notice the problem
>> during a long operation? If the magic number is big, then we waste a
>> lot of space.
>>
>> The problem with the parameter thing is that again, all the different
>> filesystems need to support that feature. We can't just tell Ext3 or JFFS2 on the VFS level,
>> that 'Hey, keep those inodes in place incase someone just made himself some headache.'
>>
>
> Above you said are what we should do.
I never said that.
> Don't waste time, let me design and
> implement it. I would send design document for review, thanks.
Do it, but I don't think it would be accepted.
--
Regards,
Levente Kurusa
next prev parent reply other threads:[~2013-10-22 14:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-20 7:06 [RFC] Rollback FS jiaweiwei
2013-10-20 7:57 ` Richard Weinberger
2013-10-20 11:33 ` jiaweiwei
2013-10-20 10:22 ` Kristof Provost
2013-10-20 11:41 ` jiaweiwei
2013-10-20 10:43 ` Vyacheslav Dubeyko
2013-10-20 11:37 ` jiaweiwei
2013-10-20 11:46 ` Richard Weinberger
2013-10-20 12:32 ` Vyacheslav Dubeyko
2013-10-20 12:35 ` Theodore Ts'o
2013-10-20 12:59 ` jiaweiwei
2013-10-20 13:07 ` Levente Kurusa
2013-10-20 13:19 ` jiaweiwei
2013-10-20 13:26 ` Levente Kurusa
2013-10-20 15:22 ` jiaweiwei
2013-10-22 14:29 ` Levente Kurusa [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-10-25 19:22 Nick Warne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52668BAE.2000301@linux.com \
--to=levex@linux.com \
--cc=harryxiyou@gmail.com \
--cc=jiaweiwei.xiyou@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=slava@dubeyko.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).