From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 304EF3DA5A5 for ; Wed, 20 May 2026 12:58:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.11.138.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779281892; cv=none; b=Dru5WvKPODUPMHN4NJGM1C2dE68+OnB6RJr6XBh5mEqQ2lv22Xhh2FmQxoWlBKWo2eJnpr2V+yBVJXkq/x4iPdpgISgu0NjslJ0WRme9GOIKuqJ/YbDtMO+bQag+cS8NTdf5JYXFMEcHqnUu39np0YPqJKvkqm5Uqcf3CxbxdwE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779281892; c=relaxed/simple; bh=z3PwAlYtT95AgT7gRDkQhtNRQK82G71olOTAVn2Qk2g=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=H/Si3QLQx660zRm2bwWw3VCI5vUbipcL1RAMTW45T7xFg4MiLfAzlDJgfMLDVh29Jmuh2YbmWg6cS0e/X+7l03nf5Gu2K2GPgqajf6NayM5ZrNjtgv+OduCZg7FzOlXMDKQtmR8RP8CsZQxUYUAbyM6yisPIDc/5zN+F0zSFJEU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=sntech.de; spf=pass smtp.mailfrom=sntech.de; dkim=pass (2048-bit key) header.d=sntech.de header.i=@sntech.de header.b=hLz4TQ3h; arc=none smtp.client-ip=185.11.138.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=sntech.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sntech.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sntech.de header.i=@sntech.de header.b="hLz4TQ3h" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sntech.de; s=gloria202408; h=Content-Type:Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Reply-To; bh=HHt+TFrYjMfuRQl1MVKyeuc2S+ijjqDSWSoLDdYR0l8=; b=hLz4TQ3hna8ofoDEFHiDj/e1LS TrhQQrdvYA6zU+UWTod7JWwPpx8fc+Aa1/Ikw/aND2X2DZuFwACPyNOrvmlMYlQJORJVfRNcmrE5I duuSidF2B3I20C4cJ4iXerzImbtTAxmYMg69HD1RCE6yeKssaqEQ0CNw6QKgOKd7ezQwXZjUj93yD ng4K2bMg9LlcrouWgu3osCSQpFb2c2qeXP5QTEyInpmTAm3edF4wBqrF3chd1UmuPhxN+lbr2/4Md aLFFcpB5bHSQNHwzAUgc6dpBC/kq9LHiBuHc+vjj4Z4Bg/EI5CsYh8yKPYIL27NSkdL5rnKQaTyVs jwNC7ghg==; From: Heiko Stuebner To: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Cc: Javier Martinez Canillas , Maxime Ripard , David Airlie , Dmitry Baryshkov , Jani Nikula , Nicolas Frattaroli , Simona Vetter , dri-devel@lists.freedesktop.org, Javier Martinez Canillas Subject: Re: [PATCH 1/8] drm/display: hdmi: Add common TMDS character rate constants Date: Wed, 20 May 2026 14:58:04 +0200 Message-ID: <5267693.KgjxqYA5nG@phil> In-Reply-To: <20260519144712.1418302-2-javierm@redhat.com> References: <20260519144712.1418302-1-javierm@redhat.com> <20260519144712.1418302-2-javierm@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Am Dienstag, 19. Mai 2026, 16:46:57 Mitteleurop=C3=A4ische Sommerzeit schri= eb Javier Martinez Canillas: > Several DRM drivers already define their own constants for minimum and > maximum TMDS character rates. >=20 > By defining common rate constants in a shared header, drivers can just use > them instead of having driver local define macros or use magic numbers. >=20 > The values defined in the header correspo= nd > to maximum TMDS character rates defined by each HDMI specification versio= n: >=20 > - DRM_HDMI_TMDS_CHAR_RATE_MIN: 25 MHz (minimum for all versions) > - DRM_HDMI_TMDS_CHAR_RATE_MAX_1_0: 165 MHz (HDMI 1.0 maximum) > - DRM_HDMI_TMDS_CHAR_RATE_MAX_1_3: 340 MHz (HDMI 1.3 maximum) > - DRM_HDMI_TMDS_CHAR_RATE_MAX_2_0: 600 MHz (HDMI 2.0 maximum) >=20 > Suggested-by: Maxime Ripard > Signed-off-by: Javier Martinez Canillas checked against the rate definitions, and of course they match :-) Reviewed-by: Heiko Stuebner > --- >=20 > include/drm/display/drm_hdmi_helper.h | 6 ++++++ > 1 file changed, 6 insertions(+) >=20 > diff --git a/include/drm/display/drm_hdmi_helper.h b/include/drm/display/= drm_hdmi_helper.h > index 9c31ed90516b..0ee246ff82e0 100644 > --- a/include/drm/display/drm_hdmi_helper.h > +++ b/include/drm/display/drm_hdmi_helper.h > @@ -5,6 +5,12 @@ > =20 > #include > =20 > +/* HDMI spec TMDS character rate limits (in Hz) */ > +#define DRM_HDMI_TMDS_CHAR_RATE_MIN 25000000 > +#define DRM_HDMI_TMDS_CHAR_RATE_MAX_1_0 165000000 > +#define DRM_HDMI_TMDS_CHAR_RATE_MAX_1_3 340000000 > +#define DRM_HDMI_TMDS_CHAR_RATE_MAX_2_0 600000000 > + > struct drm_connector; > struct drm_connector_state; > struct drm_display_mode; >=20