From: Jonathan Cameron <jic23@kernel.org>
To: Joe Perches <joe@perches.com>, linux-kernel@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, linux-iio@vger.kernel.org
Subject: Re: [PATCH 7/8] staging: Remove OOM message after input_allocate_device
Date: Thu, 24 Oct 2013 09:30:46 +0100 [thread overview]
Message-ID: <5268DAB6.3080608@kernel.org> (raw)
In-Reply-To: <607933414008a7de55bcd88348d525cbec238ed1.1382555436.git.joe@perches.com>
On 10/23/13 20:14, Joe Perches wrote:
> Emitting an OOM message isn't necessary after input_allocate_device
> as there's a generic OOM and a dump_stack already done.
>
> Signed-off-by: Joe Perches <joe@perches.com>
Acked-by: Jonathan Cameron <jic23@kernel.org>
(for iio driver)
> ---
> drivers/staging/cptm1217/clearpad_tm1217.c | 2 --
> drivers/staging/iio/adc/mxs-lradc.c | 4 +---
> drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c | 2 --
> 3 files changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/drivers/staging/cptm1217/clearpad_tm1217.c b/drivers/staging/cptm1217/clearpad_tm1217.c
> index 42a5f5c..ca4c2c6 100644
> --- a/drivers/staging/cptm1217/clearpad_tm1217.c
> +++ b/drivers/staging/cptm1217/clearpad_tm1217.c
> @@ -457,8 +457,6 @@ static int cp_tm1217_probe(struct i2c_client *client,
> for (i = 0; i < TOUCH_SUPPORTED; i++) {
> input_dev = input_allocate_device();
> if (input_dev == NULL) {
> - dev_err(ts->dev,
> - "cp_tm1217:Input Device Struct alloc failed\n");
> retval = -ENOMEM;
> goto fail;
> }
> diff --git a/drivers/staging/iio/adc/mxs-lradc.c b/drivers/staging/iio/adc/mxs-lradc.c
> index 9da64bf..696fbb3 100644
> --- a/drivers/staging/iio/adc/mxs-lradc.c
> +++ b/drivers/staging/iio/adc/mxs-lradc.c
> @@ -529,10 +529,8 @@ static int mxs_lradc_ts_register(struct mxs_lradc *lradc)
> return 0;
>
> input = input_allocate_device();
> - if (!input) {
> - dev_err(dev, "Failed to allocate TS device!\n");
> + if (!input)
> return -ENOMEM;
> - }
>
> input->name = DRIVER_NAME;
> input->id.bustype = BUS_HOST;
> diff --git a/drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c b/drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c
> index 386362c..28b3930 100644
> --- a/drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c
> +++ b/drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c
> @@ -911,8 +911,6 @@ static int synaptics_rmi4_probe
>
> rmi4_data->input_dev = input_allocate_device();
> if (rmi4_data->input_dev == NULL) {
> - dev_err(&client->dev, "%s:input device alloc failed\n",
> - __func__);
> retval = -ENOMEM;
> goto err_input;
> }
>
next prev parent reply other threads:[~2013-10-24 7:30 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-23 19:14 [PATCH 0/8] treewide: Remove OOM message after input_alloc_device Joe Perches
2013-10-23 19:14 ` [PATCH 1/8] Documentation: Remove OOM message after input_allocate_device Joe Perches
2013-10-23 19:14 ` [PATCH 2/8] cell: " Joe Perches
2013-10-23 20:49 ` [Cbe-oss-dev] " Geoff Levand
2013-10-23 19:14 ` [PATCH 3/8] hid: " Joe Perches
2013-10-23 19:14 ` [PATCH 4/8] input: " Joe Perches
2013-10-24 18:26 ` Uwe Kleine-König
2013-10-24 18:43 ` Joe Perches
2013-10-24 18:46 ` Uwe Kleine-König
2013-10-24 18:48 ` Joe Perches
2013-10-24 19:15 ` Uwe Kleine-König
2013-10-24 18:37 ` Dmitry Torokhov
2013-10-24 18:45 ` Joe Perches
2013-10-24 19:10 ` Dmitry Torokhov
2013-10-24 19:20 ` Joe Perches
2013-10-23 19:14 ` [PATCH 5/8] media: " Joe Perches
2013-10-23 19:14 ` [PATCH 6/8] platform:x86: " Joe Perches
2013-10-24 9:31 ` Henrique de Moraes Holschuh
2013-11-20 23:55 ` Matthew Garrett
2013-10-23 19:14 ` [PATCH 7/8] staging: " Joe Perches
2013-10-24 8:30 ` Jonathan Cameron [this message]
2013-10-23 19:14 ` [PATCH 8/8] sound: " Joe Perches
2013-10-24 9:26 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5268DAB6.3080608@kernel.org \
--to=jic23@kernel.org \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox