From: Vineet Gupta <vineetg76@gmail.com>
To: Richard Weinberger <richard.weinberger@gmail.com>,
Chen Gang <gang.chen@asianux.com>
Cc: Joern Rennecke <joern.rennecke@embecosm.com>,
James Hogan <james.hogan@imgtec.com>,
Rusty Russell <rusty@rustcorp.com.au>,
Takashi Iwai <tiwai@suse.de>,
Vineet Gupta <Vineet.Gupta1@synopsys.com>,
"jeremy.bennett@embecosm.com" <jeremy.bennett@embecosm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Claudiu Zissulescu <Claudiu.Zissulescu@synopsys.com>,
Francois Bedard <Francois.Bedard@synopsys.com>,
Sam Ravnborg <sam@ravnborg.org>, Joe Perches <joe@perches.com>,
"linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>
Subject: Portable assmbler code - newline (was Re: [PATCH] kernel/modsign_certificate.S: use real contents instead of macro GLOBAL())
Date: Thu, 24 Oct 2013 22:58:56 +0530 [thread overview]
Message-ID: <526958D8.6030102@synopsys.com> (raw)
In-Reply-To: <CAFLxGvzERDqwZhb_5d=bXKmqz6-Yrema_TLMTM7rjyeFeDJG_w@mail.gmail.com>
+CC linux-arch
On 10/24/2013 11:33 AM, Richard Weinberger wrote:
> On Thu, Oct 24, 2013 at 7:31 AM, Chen Gang <gang.chen@asianux.com> wrote:
>> > For some architectures, tool chain is not smart enough to recognize the
>> > macro with multiple lines (e.g. arc tool chain), and for common ".S"
>> > file, this kind of macro is also rarely used.
> Does not "not smart enough" mean than the said toolchain is broken/buggy
> or is the kernel using an unsupported notation?
>
IMHO this is not broken - rather the code is not fully portable - given that gas
ports of arches have differnet notions of what to treat as comment and what newline.
Looking as binutils/gas/config, I can see that avr, cris,...are likely broken in
the same way as ARC is.
Historically ARC has had ';' as comment char, which Joern relatively recently
augmented to have '#' as well. However there's legacy codebase which relies on ';'
being a comment and we can't change that fact.
So can we introduce an ARCH over-ridable newline annotation in linkage.h and other
places after auditing. Since asm/linkage.h preempts linux/linkage.h by way of
#include it shd be pretty strightforward.
Something like below. I can send the formal patch if people think the approach is OK.
----------------->
diff --git a/include/linux/linkage.h b/include/linux/linkage.h
index d3e8ad23a8e0..4188c632f2b8 100644
--- a/include/linux/linkage.h
+++ b/include/linux/linkage.h
@@ -6,6 +6,10 @@
#include <linux/export.h>
#include <asm/linkage.h>
+#ifndef __ARCH_NL
+#define __ARCH_NL
+#endif
+
#ifdef __cplusplus
#define CPP_ASMLINKAGE extern "C"
#else
@@ -75,7 +79,7 @@
#ifndef ENTRY
#define ENTRY(name) \
- .globl name; \
+ .globl name; __ARCH_NL \
ALIGN; \
name:
#endif
@@ -83,7 +87,7 @@
#ifndef WEAK
#define WEAK(name) \
- .weak name; \
+ .weak name; __ARCH_NL \
name:
#endif
next prev parent reply other threads:[~2013-10-24 17:29 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-23 6:04 [Suggestion] arc: compiler: bug: about an arc compiler's bug which is not in gcc main source code Chen Gang
2013-09-23 6:12 ` Chen Gang
2013-09-23 6:39 ` Vineet Gupta
2013-09-23 6:53 ` Chen Gang
2013-10-23 2:00 ` Chen Gang
2013-10-23 2:48 ` Joern Rennecke
2013-10-23 3:10 ` Chen Gang
2013-10-23 11:14 ` Chen Gang
2013-10-24 5:31 ` [PATCH] kernel/modsign_certificate.S: use real contents instead of macro GLOBAL() Chen Gang
2013-10-24 6:03 ` Richard Weinberger
2013-10-24 6:26 ` Chen Gang
2013-10-24 6:44 ` Richard Weinberger
2013-10-24 7:40 ` Chen Gang
2013-10-24 17:28 ` Vineet Gupta [this message]
2013-10-24 19:41 ` Portable assmbler code - newline (was Re: [PATCH] kernel/modsign_certificate.S: use real contents instead of macro GLOBAL()) Geert Uytterhoeven
2013-10-25 5:10 ` Vineet Gupta
2013-10-26 13:38 ` Chen Gang
2013-10-27 7:28 ` Portable assmbler code - newline Vineet Gupta
2013-10-27 12:34 ` Chen Gang
2013-10-27 13:57 ` Chen Gang
2013-10-24 15:29 ` [PATCH] kernel/modsign_certificate.S: use real contents instead of macro GLOBAL() Josh Boyer
2013-10-26 2:42 ` Chen Gang
2013-10-26 14:40 ` Chen Gang F T
2013-10-29 2:17 ` [PATCH v2] " Chen Gang
2013-10-30 1:11 ` [PATCH-next v3] kernel/system_certificate.S: " Chen Gang
2013-10-30 12:57 ` David Howells
2013-10-31 0:47 ` Chen Gang
2013-10-23 2:51 ` [Suggestion] arc: compiler: bug: about an arc compiler's bug which is not in gcc main source code Francois Bedard
2013-10-23 3:12 ` Chen Gang
2013-10-30 1:43 ` Chen Gang
2013-10-30 12:10 ` Chen Gang
2013-10-31 7:48 ` Vineet Gupta
2013-10-31 8:50 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=526958D8.6030102@synopsys.com \
--to=vineetg76@gmail.com \
--cc=Claudiu.Zissulescu@synopsys.com \
--cc=Francois.Bedard@synopsys.com \
--cc=Vineet.Gupta1@synopsys.com \
--cc=gang.chen@asianux.com \
--cc=james.hogan@imgtec.com \
--cc=jeremy.bennett@embecosm.com \
--cc=joe@perches.com \
--cc=joern.rennecke@embecosm.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=richard.weinberger@gmail.com \
--cc=rusty@rustcorp.com.au \
--cc=sam@ravnborg.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).