Re: [PATCH] arc: kernel: add default extern variable 'screen_info' in "setup.c"

[Chen Gang <gang.chen@asianux.com>]

On 10/24/2013 07:51 PM, Geert Uytterhoeven wrote:
> Hi Chen,
> 
> On Thu, Oct 24, 2013 at 1:23 PM, Chen Gang <gang.chen@asianux.com> wrote:
>>> Lot's of negative dependencies are missing for VGA_CONSOLE.
>>> I think only alpha, some arm, ia64, some mips, some powerpc, and x86
>>> may use it.
>>>
>>
>> in "arch" sub-directory, contents 13/30 (43.3%) architectures contents
>> VGA_CONSOLE.
>>
>>   1 alpha/kernel/setup.c:137:struct screen_info screen_info = {
>>   2 arm/kernel/setup.c:743:struct screen_info screen_info = {
>>   3 cris/kernel/setup.c:28:struct screen_info screen_info;
>>   4 ia64/kernel/setup.c:79:struct screen_info screen_info;
>>   5 m32r/kernel/setup.c:55:struct screen_info screen_info = {
>>   6 mips/kernel/setup.c:43:struct screen_info screen_info;
>>   7 powerpc/kernel/setup-common.c:88:struct screen_info screen_info = {
>>   8 score/kernel/setup.c:37:struct screen_info screen_info;
>>   9 sh/kernel/setup.c:68:struct screen_info screen_info;
>>  10 sparc/kernel/setup_64.c:66:struct screen_info screen_info = {
>>  11 sparc/kernel/setup_32.c:53:struct screen_info screen_info = {
>>  12 tile/kernel/setup.c:54:struct screen_info screen_info;
>>  13 x86/kernel/setup.c:220:struct screen_info screen_info;
>>  14 xtensa/kernel/setup.c:55:struct screen_info screen_info = { 0, 24, 0, 0, 0, 80, 0, 0, 0, 24, 1, 16};
>>
>> It seems most of pc and servers support VGA_CONSOLE.
> 
> I'm quite sure many of these just provide a screen_info to make vgacon compile.
> 

Thank you for your confirmation.

>>> Compare this to a shiny new feature that available on all new architectures,
>>> but not on a few old one. There it makes sense to have the negative
>>> dependencies on the old architectures, that will never have the new feature.
>>> While new architectures have enabled it by default.
>>>
>>
>> Excuse me, my English is not quite well, I do not quite understand your
>> meaning, but it seems not quite important for our discussing, so I just
>> skip it, now.
> 
> Sorry, I should stop writing complex sentences.
> For now, nevermind. There aren't that many real cases like this.
> 

And I should be still improving my English. :-)

> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds
> 
> 

Thanks.
-- 
Chen Gang