From: Chen Gang <gang.chen@asianux.com>
To: "vgupta@synopsys.com" <vgupta@synopsys.com>, noamc@ezchip.com
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: [PATCH] arc: kernel: use exporting symbol instead of static inline for arc_get_core_freq()
Date: Mon, 28 Oct 2013 11:32:53 +0800 [thread overview]
Message-ID: <526DDAE5.9040803@asianux.com> (raw)
Need export arc_get_core_freq() instead of let it static inline, or if
other individual modules use it (e.g. use BASE_BAUD), it can not find
core_freq variable.
Signed-off-by: Chen Gang <gang.chen@asianux.com>
---
arch/arc/include/asm/clk.h | 9 +--------
arch/arc/kernel/clk.c | 9 ++++++++-
2 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/arch/arc/include/asm/clk.h b/arch/arc/include/asm/clk.h
index bf9d29f..256321a 100644
--- a/arch/arc/include/asm/clk.h
+++ b/arch/arc/include/asm/clk.h
@@ -9,14 +9,7 @@
#ifndef _ASM_ARC_CLK_H
#define _ASM_ARC_CLK_H
-/* Although we can't really hide core_freq, the accessor is still better way */
-extern unsigned long core_freq;
-
-static inline unsigned long arc_get_core_freq(void)
-{
- return core_freq;
-}
-
+extern unsigned long arc_get_core_freq(void);
extern int arc_set_core_freq(unsigned long);
#endif
diff --git a/arch/arc/kernel/clk.c b/arch/arc/kernel/clk.c
index 10c7b0b..9f4602f 100644
--- a/arch/arc/kernel/clk.c
+++ b/arch/arc/kernel/clk.c
@@ -6,9 +6,16 @@
* published by the Free Software Foundation.
*/
+#include <linux/module.h>
#include <asm/clk.h>
-unsigned long core_freq = 80000000;
+static unsigned long core_freq = 80000000;
+
+unsigned long arc_get_core_freq(void)
+{
+ return core_freq;
+}
+EXPORT_SYMBOL_GPL(arc_get_core_freq);
/*
* As of now we default to device-tree provided clock
--
1.7.7.6
next reply other threads:[~2013-10-28 3:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-28 3:32 Chen Gang [this message]
2013-10-28 6:15 ` [PATCH] arc: kernel: use exporting symbol instead of static inline for arc_get_core_freq() Chen Gang
2013-10-28 6:18 ` [PATCH v2] " Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=526DDAE5.9040803@asianux.com \
--to=gang.chen@asianux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=noamc@ezchip.com \
--cc=vgupta@synopsys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox