From: Vineet Gupta <vineetg76@gmail.com>
To: Chen Gang <gang.chen@asianux.com>, Arnd Bergmann <arnd@arndb.de>,
noamc@ezchip.com
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] arc: kernel: remove '__init' for first_lines_of_secondary()
Date: Mon, 28 Oct 2013 19:23:47 +0530 [thread overview]
Message-ID: <526E6C6B.9020507@synopsys.com> (raw)
In-Reply-To: <52673186.4050806@asianux.com>
On 10/23/2013 07:46 AM, Chen Gang wrote:
> first_lines_of_secondary() is a '__init' function, but it may be called
> by __cpu_up() by _cpu_up() by cpu_up() which is a normal export symbol
> function. So recommend to remove '__init'.
>
> The related warning (with allmodconfig):
>
> MODPOST vmlinux.o
> WARNING: vmlinux.o(.text+0x315c): Section mismatch in reference from the function __cpu_up() to the function .init.text:first_lines_of_secondary()
> The function __cpu_up() references
> the function __init first_lines_of_secondary().
> This is often because __cpu_up lacks a __init
> annotation or the annotation of first_lines_of_secondary is wrong.
>
>
> Signed-off-by: Chen Gang <gang.chen@asianux.com>
Applied for 3.13. But I'm planning to squash all the __init section annotation
fixes into one patch. OK with you ?
Thx,
-Vineet
next prev parent reply other threads:[~2013-10-28 13:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-23 2:16 [PATCH] arc: kernel: remove '__init' for first_lines_of_secondary() Chen Gang
2013-10-28 13:53 ` Vineet Gupta [this message]
2013-10-29 1:08 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=526E6C6B.9020507@synopsys.com \
--to=vineetg76@gmail.com \
--cc=arnd@arndb.de \
--cc=gang.chen@asianux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=noamc@ezchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox