Re: [PATCH] arc: kernel: remove '__init' for first_lines_of_secondary()

[Chen Gang <gang.chen@asianux.com>]

On 10/28/2013 09:53 PM, Vineet Gupta wrote:
> On 10/23/2013 07:46 AM, Chen Gang wrote:
>> first_lines_of_secondary() is a '__init' function, but it may be called
>> by __cpu_up() by _cpu_up() by cpu_up() which is a normal export symbol
>> function. So recommend to remove '__init'.
>>
>> The related warning (with allmodconfig):
>>
>>     MODPOST vmlinux.o
>>   WARNING: vmlinux.o(.text+0x315c): Section mismatch in reference from the function __cpu_up() to the function .init.text:first_lines_of_secondary()
>>   The function __cpu_up() references
>>   the function __init first_lines_of_secondary().
>>   This is often because __cpu_up lacks a __init
>>   annotation or the annotation of first_lines_of_secondary is wrong.
>>
>>
>> Signed-off-by: Chen Gang <gang.chen@asianux.com>
> 
> Applied for 3.13. But I'm planning to squash all the __init section annotation
> fixes into one patch. OK with you ?
> 

It is OK to me. They are all related with each other, although toolchain
reports several warnings (originally, I made them based on warning items).


Thanks.
-- 
Chen Gang