From: David Cohen <david.a.cohen@linux.intel.com>
To: Joe Perches <joe@perches.com>
Cc: broonie@kernel.org, ning.li@intel.com,
linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
Fei Yang <fei.yang@intel.com>
Subject: Re: [PATCH 1/2] spi: add Intel Mid SSP driver
Date: Tue, 29 Oct 2013 12:32:28 -0700 [thread overview]
Message-ID: <52700D4C.10008@linux.intel.com> (raw)
In-Reply-To: <1383071755.12439.17.camel@joe-AO722>
On 10/29/2013 11:35 AM, Joe Perches wrote:
> On Tue, 2013-10-29 at 11:30 -0700, David Cohen wrote:
>> Hi Joe,
>>
>> On 10/29/2013 11:19 AM, Joe Perches wrote:
>>> On Tue, 2013-10-29 at 11:05 -0700, David Cohen wrote:
>>>> This patch adds driver for ssp spi interface on Intel Mid platform.
>>>
>>> A few simple notes:
>>>
>>> Please consider using checkpatch.
>>
>> I did and got no warnings. But haven't used --strict option.
>
> Interesting. I thought there was a return (foo);
> statement that should have been marked, but I didn't
> actually run checkpatch.
It seems odd checkpatch didn't catch it. I'll investigate.
>
> static inline u32 is_rx_fifo_empty(struct ssp_drv_context *sspc)
> +{
> + return ((read_SSSR(sspc->ioaddr) & SSSR_RNE) == 0);
> +}
>
> This could be bool too
u32 seems unusual, but I'd prefer 'int' if it's fine for you.
Br, David
next prev parent reply other threads:[~2013-10-29 19:28 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-29 18:05 [PATCH 1/2] spi: add Intel Mid SSP driver David Cohen
2013-10-29 18:05 ` [PATCH 2/2] MAINTAINERS: add Intel MID SSP SPI maintainers David Cohen
2013-10-29 18:20 ` Joe Perches
2013-10-29 18:33 ` David Cohen
2013-10-29 18:57 ` Mark Brown
2013-10-29 18:19 ` [PATCH 1/2] spi: add Intel Mid SSP driver Joe Perches
2013-10-29 18:30 ` David Cohen
2013-10-29 18:35 ` Joe Perches
2013-10-29 19:32 ` David Cohen [this message]
2013-10-29 19:38 ` Joe Perches
2013-10-29 20:28 ` [PATCH] checkpatch: Improve "return is not a function" test Joe Perches
2013-10-31 23:12 ` [PATCH V2] " Joe Perches
2013-11-01 1:03 ` David Cohen
2013-11-04 22:21 ` Andrew Morton
2013-11-04 22:24 ` Joe Perches
2013-10-29 18:29 ` [PATCH 1/2] spi: add Intel Mid SSP driver Randy Dunlap
2013-10-29 18:35 ` David Cohen
2013-10-29 18:31 ` Felipe Balbi
2013-10-29 20:18 ` David Cohen
2013-10-30 3:26 ` Ning Li
2013-10-29 18:56 ` Mark Brown
2013-10-29 20:08 ` David Cohen
2013-10-30 1:42 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52700D4C.10008@linux.intel.com \
--to=david.a.cohen@linux.intel.com \
--cc=broonie@kernel.org \
--cc=fei.yang@intel.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=ning.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox