From: Randy Dunlap <rdunlap@infradead.org>
To: David Cohen <david.a.cohen@linux.intel.com>, broonie@kernel.org
Cc: ning.li@intel.com, linux-kernel@vger.kernel.org,
linux-spi@vger.kernel.org, Fei Yang <fei.yang@intel.com>
Subject: Re: [PATCH 1/2] spi: add Intel Mid SSP driver
Date: Tue, 29 Oct 2013 18:42:19 -0700 [thread overview]
Message-ID: <527063FB.7070400@infradead.org> (raw)
In-Reply-To: <1383069950-27754-1-git-send-email-david.a.cohen@linux.intel.com>
On 10/29/13 11:05, David Cohen wrote:
a few more comments:
> +static unsigned int ssp_get_clk_div(int speed)
> +{
> + return max(100000000 / speed, 4) - 1;
Divide uses library call? I dunno...
Bad if so. Would need to use some function from
#include <asm-generic/div64.h>
> +}
> +/**
> + * setup() - Driver setup procedure
> + * @spi: Pointeur to the spi_device struct
Pointer
> + */
> +static int setup(struct spi_device *spi)
> +{
> +}
> +/**
> + * ssp_spi_probe() - Driver probe procedure
> + * @pdev: Pointer to the pci_dev struct
> + * @ent: Pointer to the pci_device_id struct
> + */
> +static int ssp_spi_probe(struct pci_dev *pdev,
> + const struct pci_device_id *ent)
> +{
> + /* Set platform & configuration quirks */
> + if (sspc->quirks & QUIRKS_PLATFORM_MRST) {
> + /* Apply bit banging workarround on MRST */
workaround
> + sspc->quirks |= QUIRKS_BIT_BANGING;
> + /* MRST slave mode workarrounds */
workarounds
> + if (ssp_cfg_is_spi_slave(ssp_cfg))
> + sspc->quirks |= QUIRKS_USE_PM_QOS |
> + QUIRKS_SRAM_ADDITIONAL_CPY;
> + }
> + if (intel_mid_identify_cpu() == INTEL_MID_CPU_CHIP_TANGIER)
> + ssp_timing_wr = 1;
> +
> + if (status < 0) {
> + dev_err(&pdev->dev, "can not get IRQ\n");
cannot
> + goto err_free_4;
> + }
> +
> +}
> +MODULE_AUTHOR("Ken Mills");
> +MODULE_DESCRIPTION("Bulverde SSP core SPI contoller");
controller
> +MODULE_LICENSE("GPL");
--
~Randy
prev parent reply other threads:[~2013-10-30 1:42 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-29 18:05 [PATCH 1/2] spi: add Intel Mid SSP driver David Cohen
2013-10-29 18:05 ` [PATCH 2/2] MAINTAINERS: add Intel MID SSP SPI maintainers David Cohen
2013-10-29 18:20 ` Joe Perches
2013-10-29 18:33 ` David Cohen
2013-10-29 18:57 ` Mark Brown
2013-10-29 18:19 ` [PATCH 1/2] spi: add Intel Mid SSP driver Joe Perches
2013-10-29 18:30 ` David Cohen
2013-10-29 18:35 ` Joe Perches
2013-10-29 19:32 ` David Cohen
2013-10-29 19:38 ` Joe Perches
2013-10-29 20:28 ` [PATCH] checkpatch: Improve "return is not a function" test Joe Perches
2013-10-31 23:12 ` [PATCH V2] " Joe Perches
2013-11-01 1:03 ` David Cohen
2013-11-04 22:21 ` Andrew Morton
2013-11-04 22:24 ` Joe Perches
2013-10-29 18:29 ` [PATCH 1/2] spi: add Intel Mid SSP driver Randy Dunlap
2013-10-29 18:35 ` David Cohen
2013-10-29 18:31 ` Felipe Balbi
2013-10-29 20:18 ` David Cohen
2013-10-30 3:26 ` Ning Li
2013-10-29 18:56 ` Mark Brown
2013-10-29 20:08 ` David Cohen
2013-10-30 1:42 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=527063FB.7070400@infradead.org \
--to=rdunlap@infradead.org \
--cc=broonie@kernel.org \
--cc=david.a.cohen@linux.intel.com \
--cc=fei.yang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=ning.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox