public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Nikolai Kondrashov <spbnick@gmail.com>
To: AceLan Kao <acelan.kao@canonical.com>
Cc: Josh Boyer <jwboyer@fedoraproject.org>,
	Kevin Fenzi <kevin@scrye.com>,
	"Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>,
	Jiri Kosina <jkosina@suse.cz>
Subject: Re: ELAN Touchscreen regression in recent 3.12 rc's? (USB)
Date: Wed, 30 Oct 2013 10:37:29 +0200	[thread overview]
Message-ID: <5270C549.30201@gmail.com> (raw)
In-Reply-To: <CAFv23QmGeGMCVAJCQHv8oDk_ZrXHKsemP1MHnn+uaQQ5DKoFOA@mail.gmail.com>

Hi AceLan,

On 10/30/2013 03:41 AM, AceLan Kao wrote:
> It's hard to believe that those quirks will lead to the problem.
> And actually, there are 4 new commits introduced to -rc7, and 3 of
> them are quirks.
>
> % git log --pretty=oneline v3.12-rc6..v3.12-rc7 drivers/hid
> 86b84167d4e67372376a57ea9955c5d53dae232f HID: wiimote: add LEGO-wiimote VID
> ad0e669b922c7790182cf19f8015b30e23ad9499 HID: Fix unit exponent parsing again
> 684524d35fe8d13be1f2649633e43bd02c96c695 HID: usbhid: quirk for SiS Touchscreen
> 8171a67d587a09e14a4949a81e070345fedcf410 HID: usbhid: quirk for
> Synaptics Large Touchccreen
>
> CC'd Nikolai, since his commit changes the protocol.

My change is very unlikely to produce such problems. It changes calculation of
axes resolution at the time the report descriptor is processed. The results of
the calculation are not used by the kernel, AFAIK, but only by userspace
drivers. The results should not be used to affect the interactions with the
device, but only the interpretation of the reports (again, in userspace), and
even that is barely done currently.

Please try reverting that particular commit and see if it affects the
behavior.

Sincerely,
Nick

  parent reply	other threads:[~2013-10-30  8:37 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-28 21:02 ELAN Touchscreen regression in recent 3.12 rc's? (USB) Kevin Fenzi
2013-10-29 12:33 ` Josh Boyer
2013-10-30  1:41   ` AceLan Kao
2013-10-30  1:48     ` Kevin Fenzi
2013-10-30  8:37     ` Nikolai Kondrashov [this message]
2013-11-05  9:52       ` Jiri Kosina
2013-11-06  1:44         ` AceLan Kao
2013-11-06 17:28           ` Kevin Fenzi
2013-11-07  8:10             ` AceLan Kao
2013-11-09 21:23               ` Kevin Fenzi
2013-11-10  6:35             ` Kevin Fenzi
2014-01-19  9:25               ` cire831

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5270C549.30201@gmail.com \
    --to=spbnick@gmail.com \
    --cc=acelan.kao@canonical.com \
    --cc=jkosina@suse.cz \
    --cc=jwboyer@fedoraproject.org \
    --cc=kevin@scrye.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox