From: Randy Dunlap <rdunlap@infradead.org>
To: Chen Gang <gang.chen@asianux.com>,
"mingo@redhat.com" <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] include/linux/wait.h: add ';' for the statement which missed it.
Date: Wed, 30 Oct 2013 08:15:31 -0700 [thread overview]
Message-ID: <52712293.90808@infradead.org> (raw)
In-Reply-To: <52708623.504@asianux.com>
On 10/29/13 21:08, Chen Gang wrote:
> Add ';' for the statement, or can not pass compiling. The related error
> (for powerpc allmodconfig):
>
> CC block/blk-mq.o
> block/blk-mq.c: In function ‘blk_mq_queue_enter’:
> block/blk-mq.c:108:8: error: expected ‘;’ before ‘__ret’
> block/blk-mq.c:108:6: error: void value not ignored as it ought to be
>
>
> Signed-off-by: Chen Gang <gang.chen@asianux.com>
Acked-by: Randy Dunlap <rdunlap@infradead.org>
I have that same patch on my machine but never posted it.
Thanks.
> ---
> include/linux/wait.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/include/linux/wait.h b/include/linux/wait.h
> index 7f8caa5..fcc9680 100644
> --- a/include/linux/wait.h
> +++ b/include/linux/wait.h
> @@ -768,7 +768,7 @@ do { \
> int __ret = 0; \
> if (!(condition)) \
> __ret = __wait_event_interruptible_lock_irq(wq, \
> - condition, lock,) \
> + condition, lock,); \
> __ret; \
> })
>
>
--
~Randy
next prev parent reply other threads:[~2013-10-30 15:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-30 4:08 [PATCH] include/linux/wait.h: add ';' for the statement which missed it Chen Gang
2013-10-30 15:15 ` Randy Dunlap [this message]
2013-10-30 15:40 ` Peter Zijlstra
2013-10-31 0:51 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52712293.90808@infradead.org \
--to=rdunlap@infradead.org \
--cc=gang.chen@asianux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox