* [PATCH] include/linux/wait.h: add ';' for the statement which missed it.
@ 2013-10-30 4:08 Chen Gang
2013-10-30 15:15 ` Randy Dunlap
0 siblings, 1 reply; 4+ messages in thread
From: Chen Gang @ 2013-10-30 4:08 UTC (permalink / raw)
To: mingo@redhat.com, Peter Zijlstra, linux-kernel@vger.kernel.org
Add ';' for the statement, or can not pass compiling. The related error
(for powerpc allmodconfig):
CC block/blk-mq.o
block/blk-mq.c: In function ‘blk_mq_queue_enter’:
block/blk-mq.c:108:8: error: expected ‘;’ before ‘__ret’
block/blk-mq.c:108:6: error: void value not ignored as it ought to be
Signed-off-by: Chen Gang <gang.chen@asianux.com>
---
include/linux/wait.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/linux/wait.h b/include/linux/wait.h
index 7f8caa5..fcc9680 100644
--- a/include/linux/wait.h
+++ b/include/linux/wait.h
@@ -768,7 +768,7 @@ do { \
int __ret = 0; \
if (!(condition)) \
__ret = __wait_event_interruptible_lock_irq(wq, \
- condition, lock,) \
+ condition, lock,); \
__ret; \
})
--
1.7.7.6
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] include/linux/wait.h: add ';' for the statement which missed it.
2013-10-30 4:08 [PATCH] include/linux/wait.h: add ';' for the statement which missed it Chen Gang
@ 2013-10-30 15:15 ` Randy Dunlap
2013-10-30 15:40 ` Peter Zijlstra
0 siblings, 1 reply; 4+ messages in thread
From: Randy Dunlap @ 2013-10-30 15:15 UTC (permalink / raw)
To: Chen Gang, mingo@redhat.com, Peter Zijlstra,
linux-kernel@vger.kernel.org
On 10/29/13 21:08, Chen Gang wrote:
> Add ';' for the statement, or can not pass compiling. The related error
> (for powerpc allmodconfig):
>
> CC block/blk-mq.o
> block/blk-mq.c: In function ‘blk_mq_queue_enter’:
> block/blk-mq.c:108:8: error: expected ‘;’ before ‘__ret’
> block/blk-mq.c:108:6: error: void value not ignored as it ought to be
>
>
> Signed-off-by: Chen Gang <gang.chen@asianux.com>
Acked-by: Randy Dunlap <rdunlap@infradead.org>
I have that same patch on my machine but never posted it.
Thanks.
> ---
> include/linux/wait.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/include/linux/wait.h b/include/linux/wait.h
> index 7f8caa5..fcc9680 100644
> --- a/include/linux/wait.h
> +++ b/include/linux/wait.h
> @@ -768,7 +768,7 @@ do { \
> int __ret = 0; \
> if (!(condition)) \
> __ret = __wait_event_interruptible_lock_irq(wq, \
> - condition, lock,) \
> + condition, lock,); \
> __ret; \
> })
>
>
--
~Randy
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] include/linux/wait.h: add ';' for the statement which missed it.
2013-10-30 15:15 ` Randy Dunlap
@ 2013-10-30 15:40 ` Peter Zijlstra
2013-10-31 0:51 ` Chen Gang
0 siblings, 1 reply; 4+ messages in thread
From: Peter Zijlstra @ 2013-10-30 15:40 UTC (permalink / raw)
To: Randy Dunlap; +Cc: Chen Gang, mingo@redhat.com, linux-kernel@vger.kernel.org
On Wed, Oct 30, 2013 at 08:15:31AM -0700, Randy Dunlap wrote:
> On 10/29/13 21:08, Chen Gang wrote:
> > Add ';' for the statement, or can not pass compiling. The related error
> > (for powerpc allmodconfig):
> >
> > CC block/blk-mq.o
> > block/blk-mq.c: In function ‘blk_mq_queue_enter’:
> > block/blk-mq.c:108:8: error: expected ‘;’ before ‘__ret’
> > block/blk-mq.c:108:6: error: void value not ignored as it ought to be
> >
> >
> > Signed-off-by: Chen Gang <gang.chen@asianux.com>
>
> Acked-by: Randy Dunlap <rdunlap@infradead.org>
>
> I have that same patch on my machine but never posted it.
tip already includes commit 92ec11809565cf6429c75204e99e0f583b5c9d7c
from the 23th which should fix this.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] include/linux/wait.h: add ';' for the statement which missed it.
2013-10-30 15:40 ` Peter Zijlstra
@ 2013-10-31 0:51 ` Chen Gang
0 siblings, 0 replies; 4+ messages in thread
From: Chen Gang @ 2013-10-31 0:51 UTC (permalink / raw)
To: Peter Zijlstra
Cc: Randy Dunlap, mingo@redhat.com, linux-kernel@vger.kernel.org
On 10/30/2013 11:40 PM, Peter Zijlstra wrote:
> On Wed, Oct 30, 2013 at 08:15:31AM -0700, Randy Dunlap wrote:
>> On 10/29/13 21:08, Chen Gang wrote:
>>> Add ';' for the statement, or can not pass compiling. The related error
>>> (for powerpc allmodconfig):
>>>
>>> CC block/blk-mq.o
>>> block/blk-mq.c: In function ‘blk_mq_queue_enter’:
>>> block/blk-mq.c:108:8: error: expected ‘;’ before ‘__ret’
>>> block/blk-mq.c:108:6: error: void value not ignored as it ought to be
>>>
>>>
>>> Signed-off-by: Chen Gang <gang.chen@asianux.com>
>>
>> Acked-by: Randy Dunlap <rdunlap@infradead.org>
>>
>> I have that same patch on my machine but never posted it.
>
> tip already includes commit 92ec11809565cf6429c75204e99e0f583b5c9d7c
> from the 23th which should fix this.
>
>
Thank all of you.
--
Chen Gang
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-10-31 0:52 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-30 4:08 [PATCH] include/linux/wait.h: add ';' for the statement which missed it Chen Gang
2013-10-30 15:15 ` Randy Dunlap
2013-10-30 15:40 ` Peter Zijlstra
2013-10-31 0:51 ` Chen Gang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox