From: Ryan Mallon <rmallon@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Frank Haverkamp <haver@linux.vnet.ibm.com>,
linux-kernel@vger.kernel.org, arnd@arndb.de,
cody@linux.vnet.ibm.com, schwidefsky@de.ibm.com,
utz.bacher@de.ibm.com, mmarek@suse.cz, jsvogt@de.ibm.com,
MIJUNG@de.ibm.com, cascardo@linux.vnet.ibm.com, michael@ibmra.de,
Frank Haverkamp <haver@vnet.ibm.com>
Subject: Re: [PATCH] Generic WorkQueue Engine (GenWQE) device driver (v4)
Date: Thu, 31 Oct 2013 07:38:05 +1100 [thread overview]
Message-ID: <52716E2D.8060708@gmail.com> (raw)
In-Reply-To: <20131030173521.GB20147@kroah.com>
On 31/10/13 04:35, Greg KH wrote:
> On Wed, Oct 30, 2013 at 10:32:58AM +0100, Frank Haverkamp wrote:
>> +if GENWQE
>> +
>> +config GENWQE_DEVNAME
>> + string "Name for sysfs and device nodes"
>> + default "genwqe"
>> + help
>> + Select alternate name for sysfs and device nodes.
>
> Don't let the user pick this, it's up to the driver to set this once and
> then live with it.
>
> And, from what I can tell in the driver, this help text is wrong (there
> are no device nodes with this name in it, right?)
The indentation is also messed up here. Kconfig should use hard tabs, with
two additional spaces for the help text. This has mixed tabs and spaces
between lines.
~Ryan
next prev parent reply other threads:[~2013-10-30 20:37 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-30 9:32 [PATCH] Generic WorkQueue Engine (GenWQE) device driver (v4) Frank Haverkamp
2013-10-30 9:32 ` Frank Haverkamp
2013-10-30 17:35 ` Greg KH
2013-10-30 20:38 ` Ryan Mallon [this message]
2013-11-04 16:19 ` Frank Haverkamp
2013-11-04 16:18 ` Frank Haverkamp
2013-10-30 17:36 ` Greg KH
2013-11-04 16:20 ` Frank Haverkamp
2013-10-30 17:37 ` Greg KH
2013-11-04 16:30 ` Frank Haverkamp
2013-10-30 17:39 ` Greg KH
2013-10-30 17:44 ` Greg KH
2013-11-04 16:41 ` Frank Haverkamp
2013-11-04 22:15 ` Greg KH
2013-11-05 7:16 ` Frank Haverkamp
2013-11-05 12:50 ` Greg KH
2013-10-31 3:49 ` Ryan Mallon
2013-11-04 16:44 ` Frank Haverkamp
2013-11-04 16:45 ` Frank Haverkamp
2013-11-12 13:50 ` Pavel Machek
2013-11-13 12:36 ` Frank Haverkamp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52716E2D.8060708@gmail.com \
--to=rmallon@gmail.com \
--cc=MIJUNG@de.ibm.com \
--cc=arnd@arndb.de \
--cc=cascardo@linux.vnet.ibm.com \
--cc=cody@linux.vnet.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=haver@linux.vnet.ibm.com \
--cc=haver@vnet.ibm.com \
--cc=jsvogt@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michael@ibmra.de \
--cc=mmarek@suse.cz \
--cc=schwidefsky@de.ibm.com \
--cc=utz.bacher@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox