From: Chen Gang <gang.chen@asianux.com>
To: Greg KH <gregkh@linuxfoundation.org>,
"vgupta@synopsys.com" <vgupta@synopsys.com>,
Vineet Gupta <Vineet.Gupta1@synopsys.com>
Cc: w.d.hubbs@gmail.com, chris@the-brannons.com, kirk@reisers.ca,
samuel.thibault@ens-lyon.org,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
speakup@braille.uwo.ca,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: [PATCH] arc: include: asm: define empty SERIAL_PORT_DFNS in serial.h
Date: Thu, 31 Oct 2013 09:44:41 +0800 [thread overview]
Message-ID: <5271B609.90805@asianux.com> (raw)
In-Reply-To: <5271B1D2.6020301@asianux.com>
For some architectures (e.g. arc, openrisc), BASE_BAUD isn't constant
And SERIAL_PORT_DFNS always use BASE_BAUND, and also all drivers use
SERIAL_PORT_DFNS to initialize static variables, statically.
So need define SERIAL_PORT_DFNS as empty to tell drivers they don't
support SERIAL_PORT_DFNS (mostly like frv and parisc did), or can not
pass compiling
The related error (allmodconfig for arc with gcc-4.8.0):
CC [M] drivers/staging/speakup/serialio.o
drivers/staging/speakup/serialio.c:12:2: error: initializer element is not constant
SERIAL_PORT_DFNS
^
drivers/staging/speakup/serialio.c:12:2: error: (near initialization for 'rs_table[0].baud_base')
drivers/staging/speakup/serialio.c:12:2: error: initializer element is not constant
drivers/staging/speakup/serialio.c:12:2: error: (near initialization for 'rs_table[1].baud_base')
drivers/staging/speakup/serialio.c:12:2: error: initializer element is not constant
drivers/staging/speakup/serialio.c:12:2: error: (near initialization for 'rs_table[2].baud_base')
drivers/staging/speakup/serialio.c:12:2: error: initializer element is not constant
drivers/staging/speakup/serialio.c:12:2: error: (near initialization for 'rs_table[3].baud_base')
Signed-off-by: Chen Gang <gang.chen@asianux.com>
---
arch/arc/include/asm/serial.h | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/arch/arc/include/asm/serial.h b/arch/arc/include/asm/serial.h
index 602b097..f18b772 100644
--- a/arch/arc/include/asm/serial.h
+++ b/arch/arc/include/asm/serial.h
@@ -32,4 +32,6 @@
#define BASE_BAUD (arc_get_core_freq() / 16 / 3)
#endif
+#define SERIAL_PORT_DFNS
+
#endif /* _ASM_ARC_SERIAL_H */
--
1.7.7.6
next parent reply other threads:[~2013-10-31 1:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <5267406C.9030805@asianux.com>
[not found] ` <20131025052926.GA26786@kroah.com>
[not found] ` <526BC113.3040003@asianux.com>
[not found] ` <5271B1D2.6020301@asianux.com>
2013-10-31 1:44 ` Chen Gang [this message]
2013-10-31 6:47 ` [PATCH] arc: include: asm: define empty SERIAL_PORT_DFNS in serial.h Vineet Gupta
[not found] ` <C2D7FE5348E1B147BCA15975FBA230751538D9@IN01WEMBXA.internal.synopsys.com>
[not found] ` <527202EF.6080704@asianux.com>
2013-10-31 7:37 ` [PATCH] arch: * : include: asm: remove " Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5271B609.90805@asianux.com \
--to=gang.chen@asianux.com \
--cc=Vineet.Gupta1@synopsys.com \
--cc=chris@the-brannons.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=kirk@reisers.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=samuel.thibault@ens-lyon.org \
--cc=speakup@braille.uwo.ca \
--cc=vgupta@synopsys.com \
--cc=w.d.hubbs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox