From: David Cohen <david.a.cohen@linux.intel.com>
To: balbi@ti.com
Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, stern@rowland.harvard.edu,
Paul.Zimmerman@synopsys.com
Subject: Re: [PATCH v3 3/3] usb: dwc3: add quirk USB_GADGET_QUIRK_EP_OUT_ALIGNED_SIZE to gadget driver
Date: Thu, 31 Oct 2013 12:58:51 -0700 [thread overview]
Message-ID: <5272B67B.6050509@linux.intel.com> (raw)
In-Reply-To: <20131030173553.GP12193@gimli>
On 10/30/2013 10:35 AM, Felipe Balbi wrote:
> On Wed, Oct 30, 2013 at 10:06:18AM -0700, David Cohen wrote:
>> DWC3 requires epout to have buffer size aligned to MaxPacketSize value.
>> This patch adds necessary quirk for it.
>>
>> Signed-off-by: David Cohen <david.a.cohen@linux.intel.com>
>> ---
>> drivers/usb/dwc3/gadget.c | 6 ++++++
>> 1 file changed, 6 insertions(+)
>>
>> diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c
>> index 5452c0f..528c7d7 100644
>> --- a/drivers/usb/dwc3/gadget.c
>> +++ b/drivers/usb/dwc3/gadget.c
>> @@ -2600,6 +2600,12 @@ int dwc3_gadget_init(struct dwc3 *dwc)
>> dwc->gadget.name = "dwc3-gadget";
>>
>> /*
>> + * Per databook, DWC3 needs buffer size to be aligned to MaxPacketSize
>> + * on ep out.
>> + */
>> + dwc->gadget.quirk_ep_out_aligned_size = 1;
>
> just to make it look cooler and neater, could you set to 'true' instead
> :-)
'bool' is an alien in C :)
But I can change to true in next patch set.
Br, David Cohen
next prev parent reply other threads:[~2013-10-31 20:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-30 17:06 [PATCH v3 0/3] add gadget quirk to adapt f_fs for DWC3 David Cohen
2013-10-30 17:06 ` [PATCH v3 1/3] usb: gadget: add quirk_ep_out_aligned_size field to struct usb_gadget David Cohen
2013-10-30 17:31 ` Alan Stern
2013-10-30 17:36 ` Felipe Balbi
2013-10-30 17:33 ` Felipe Balbi
2013-10-30 17:06 ` [PATCH v3 2/3] usb: ffs: check quirk to pad epout buf size when not aligned to maxpacketsize David Cohen
2013-10-30 17:35 ` Alan Stern
2013-11-04 19:02 ` David Cohen
2013-10-30 17:06 ` [PATCH v3 3/3] usb: dwc3: add quirk USB_GADGET_QUIRK_EP_OUT_ALIGNED_SIZE to gadget driver David Cohen
2013-10-30 17:35 ` Felipe Balbi
2013-10-31 19:58 ` David Cohen [this message]
2013-10-31 21:16 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5272B67B.6050509@linux.intel.com \
--to=david.a.cohen@linux.intel.com \
--cc=Paul.Zimmerman@synopsys.com \
--cc=balbi@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox