From: David Cohen <david.a.cohen@linux.intel.com>
To: Joe Perches <joe@perches.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Andy Whitcroft <apw@shadowen.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2] checkpatch: Improve "return is not a function" test
Date: Thu, 31 Oct 2013 18:03:35 -0700 [thread overview]
Message-ID: <5272FDE7.4060000@linux.intel.com> (raw)
In-Reply-To: <1383261164.2769.6.camel@joe-AO722>
On 10/31/2013 04:12 PM, Joe Perches wrote:
> Find a few more cases where parentheses are used around
> the value of a return statement.
>
> This now uses the "$balanced_parens" test and also makes
> the test depend on perl v5.10 and higher.
>
> This now finds return with parenthesis uses the old code
> did not find like:
>
> ERROR: return is not a function, parentheses are not required
> #211: FILE: arch/m68k/include/asm/sun3xflop.h:211:
> + return ((error == 0) ? 0 : -1);
>
> Signed-off-by: Joe Perches <joe@perches.com>
It catches the previous false-negative I had.
Acked-by: David Cohen <david.a.cohen@linux.intel.com>
next prev parent reply other threads:[~2013-11-01 1:05 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-29 18:05 [PATCH 1/2] spi: add Intel Mid SSP driver David Cohen
2013-10-29 18:05 ` [PATCH 2/2] MAINTAINERS: add Intel MID SSP SPI maintainers David Cohen
2013-10-29 18:20 ` Joe Perches
2013-10-29 18:33 ` David Cohen
2013-10-29 18:57 ` Mark Brown
2013-10-29 18:19 ` [PATCH 1/2] spi: add Intel Mid SSP driver Joe Perches
2013-10-29 18:30 ` David Cohen
2013-10-29 18:35 ` Joe Perches
2013-10-29 19:32 ` David Cohen
2013-10-29 19:38 ` Joe Perches
2013-10-29 20:28 ` [PATCH] checkpatch: Improve "return is not a function" test Joe Perches
2013-10-31 23:12 ` [PATCH V2] " Joe Perches
2013-11-01 1:03 ` David Cohen [this message]
2013-11-04 22:21 ` Andrew Morton
2013-11-04 22:24 ` Joe Perches
2013-10-29 18:29 ` [PATCH 1/2] spi: add Intel Mid SSP driver Randy Dunlap
2013-10-29 18:35 ` David Cohen
2013-10-29 18:31 ` Felipe Balbi
2013-10-29 20:18 ` David Cohen
2013-10-30 3:26 ` Ning Li
2013-10-29 18:56 ` Mark Brown
2013-10-29 20:08 ` David Cohen
2013-10-30 1:42 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5272FDE7.4060000@linux.intel.com \
--to=david.a.cohen@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=apw@shadowen.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox