From: Jens Axboe <axboe@kernel.dk>
To: Mike Snitzer <snitzer@redhat.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Kent Overstreet <kmo@daterainc.com>,
linux-kernel@vger.kernel.org
Subject: Re: stec skd block driver needs updating for immutable biovec
Date: Fri, 01 Nov 2013 10:34:23 -0600 [thread overview]
Message-ID: <5273D80F.5070205@kernel.dk> (raw)
In-Reply-To: <20131101162823.GB23501@redhat.com>
On 11/01/2013 10:28 AM, Mike Snitzer wrote:
> On Fri, Nov 01 2013 at 12:02pm -0400,
> Jens Axboe <axboe@kernel.dk> wrote:
>
>> On 11/01/2013 09:50 AM, Christoph Hellwig wrote:
>>> On Fri, Nov 01, 2013 at 11:43:39AM -0400, Mike Snitzer wrote:
>>>> All the bi_sector ones are low hanging fruit, but the conversion for
>>>> skd_preop_sg_list_bio()'s bio_vec code is more involved.
>>>>
>>>> Kent, any chance you could crank through it?
>>>>
>>>> If not I can come back to trying to fix this later.. but I'm working
>>>> through a test merge of linux-dm.git's 'for-next' with linux-block.git's
>>>> 'for-next'.
>>>
>>> The right thing for 3.13 is to rip out the bio base code path, and
>>> for 3.14 to convert it to blk-mq.
>>
>> It is. I will kill it.
>
> I just cranked through it.. hope this helps (think I got everything but
> may have missed something):
You lost out, I committed it 20 min ago :-0
http://git.kernel.dk/?p=linux-block.git;a=commit;h=1d36f7a5fb577afaaead6c5e2fc8e01e0c95235d
Looks like you missed some of the skd_device removal, while I neglected
killing bio/start_time in the skd_request_context.
--
Jens Axboe
next prev parent reply other threads:[~2013-11-01 16:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-01 13:59 [PATCH for-next] dm: fix missing bi_remaining accounting Mike Snitzer
2013-11-01 15:03 ` Jens Axboe
2013-11-01 15:43 ` stec skd block driver needs updating for immutable biovec Mike Snitzer
2013-11-01 15:50 ` Christoph Hellwig
2013-11-01 16:02 ` Jens Axboe
2013-11-01 16:28 ` Mike Snitzer
2013-11-01 16:34 ` Jens Axboe [this message]
2013-11-01 17:46 ` Mike Snitzer
2013-11-04 11:25 ` Bartlomiej Zolnierkiewicz
2013-11-04 15:06 ` [PATCH for-next] dm: fix missing bi_remaining accounting Mikulas Patocka
2013-11-04 15:20 ` Mike Snitzer
2013-11-04 15:25 ` Mikulas Patocka
2013-11-04 16:04 ` Mike Snitzer
2013-11-04 17:49 ` Mikulas Patocka
2013-11-05 0:56 ` Mike Snitzer
2013-11-04 20:12 ` Kent Overstreet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5273D80F.5070205@kernel.dk \
--to=axboe@kernel.dk \
--cc=hch@infradead.org \
--cc=kmo@daterainc.com \
--cc=linux-kernel@vger.kernel.org \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox